{"thread":{"id":"29173","subject":"Re: [PATCH] gitk: fix the display of files when filtered by path","startedAt":"2011-12-15T21:18:19Z","lastAt":"2011-12-15T21:18:19Z","messageCount":1,"participants":["Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"181253","messageId":"CABNJ2GJaCW5QtLWB+SJosGyFF3MBVvG4B_u+z0V0Ug2723S_kA@mail.gmail.com","threadId":"29173","inReplyTo":null,"subject":"Re: [PATCH] gitk: fix the display of files when filtered by path","fromName":"Pat Thoyts","fromEmail":"patthoyts@gmail.com","sentAt":"2011-12-15T21:18:19Z","receivedAt":"2011-12-15T21:18:19Z","isPatch":true,"sender":{"key":"patthoyts@gmail.com","avatar":"https://gravatar.com/avatar/bee887a777c790bd241f398217723fbe4b854428671db83db32216a28654cb25?d=mp&s=160"},"body":"On Dec 15, 2011 8:01 PM, \"Martin von Zweigbergk\" <\nmartin.von.zweigbergk@gmail.com> wrote:\n>\n> Hi,\n>\n> On Thu, Dec 15, 2011 at 1:24 AM, Johannes Schindelin\n> wrote:\n> > Hi,\n> >\n> > On Wed, 14 Dec 2011, David Aguilar wrote:\n> >\n> >> On Tue, Dec 13, 2011 at 8:50 AM, Pat Thoyts\n> >> wrote:\n> >> > Launching 'gitk -- .' or 'gitk -- ..\\t' restricts the display to\nfiles\n> >> > under the given directory but the file list is left empty. This is\nbecause\n> >> > the path_filter function fails to match the filenames which are\nrelative\n> >> > to the working tree to the filter which is filessytem relative.\n> >> > This solves the problem by making both names fully qualified\nfilesystem\n> >> > paths before performing the comparison.\n>\n> How is this related to my patches from April? See\n> http://thread.gmane.org/gmane.comp.version-control.git/170853. It's\n> clearly not the same problem, but will the patches conflict? Will some\n> of mine be unnecessary?\n>\n> > Thanks for reminding me that I did not yet apply and push. Did so now.\n>\n> What do you mean by this? Push to where?\n> git://git.kernel.org/pub/scm/gitk/gitk.git is still down.\n\nThis is about msysgit as I also posted this there.\n\n> Paul and Junio, the patches I sent in April are still not in git.git,\n> are they? Can we use another repo until the kernel.org one is up? More\n> than eight months to get a patch (or eight) merged is way too long,\n> IMO.\n>\n> Martin\n\nI'm not sure how this might relate to your patches. I've got a version\nmerged on top of the last version of the gitk report that I have which\nincludes those and it seems fine. As stated I did this work against\ngit-core as the gitk repository continues to be unavailable. However as I\nhave a pretty current snapshot I have pushed this to github to provide\nsome visibility of things I know are not present within git-core. See\nhttp://github.com/patthoyts/gitk.git\nOn Dec 15, 2011 8:01 PM, \"Martin von Zweigbergk\" <\nmartin.von.zweigbergk@gmail.com> wrote:\n"}]}