{"thread":{"id":"29141","subject":"BUG: git-p4: can't add files with special chars","startedAt":"2011-12-12T20:48:10Z","lastAt":"2011-12-17T13:27:54Z","messageCount":2,"participants":["Luke Diamand","Pete Wyckoff"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"180964","messageId":"4EE6688A.2030105@diamand.org","threadId":"29141","inReplyTo":null,"subject":"BUG: git-p4: can't add files with special chars","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2011-12-12T20:48:10Z","receivedAt":"2011-12-12T20:48:10Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"I just noticed this today. You can't add a file from git to perforce \nthat contains a p4 special character (@,#,% or *).\n\nThere is code to cope going the other way round (p4 file with special \ncharacter in it) but if you create a file in git and then try to git-p4 \nsubmit, it fails.\n\nI've just tried a quick and simple fix, and it turns out that it's not \nthat easy as the special characters get expanded to %40, %2A and so-on. \nThe % seems to get further expanded by python...\n\nLuke\n"},{"id":"181400","messageId":"20111217132754.GB31271@padd.com","threadId":"29141","inReplyTo":"4EE6688A.2030105@diamand.org","subject":"Re: BUG: git-p4: can't add files with special chars","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2011-12-17T13:27:54Z","receivedAt":"2011-12-17T13:27:54Z","isPatch":false,"sender":{"key":"pw@padd.com","avatar":null},"body":"luke@diamand.org wrote on Mon, 12 Dec 2011 20:48 +0000:\n> I just noticed this today. You can't add a file from git to perforce\n> that contains a p4 special character (@,#,% or *).\n> \n> There is code to cope going the other way round (p4 file with\n> special character in it) but if you create a file in git and then\n> try to git-p4 submit, it fails.\n> \n> I've just tried a quick and simple fix, and it turns out that it's\n> not that easy as the special characters get expanded to %40, %2A and\n> so-on. The % seems to get further expanded by python...\n\nEntertaining.  Probably p4_add() and friends should stop using\nsystem.  And add option \"-f\" when wildcards are detected.  I\nwouldn't be surprised if this turned into a larger set of issues.\n\n\t\t-- Pete\n"}]}