{"thread":{"id":"29113","subject":"[PATCH] am: don't persist keepcr flag","startedAt":"2011-12-09T07:30:45Z","lastAt":"2011-12-09T18:50:07Z","messageCount":2,"participants":["Martin von Zweigbergk","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"180634","messageId":"1323415845-11826-1-git-send-email-martin.von.zweigbergk@gmail.com","threadId":"29113","inReplyTo":null,"subject":"[PATCH] am: don't persist keepcr flag","fromName":"Martin von Zweigbergk","fromEmail":"martin.von.zweigbergk@gmail.com","sentAt":"2011-12-09T07:30:45Z","receivedAt":"2011-12-09T07:30:45Z","isPatch":true,"sender":{"key":"martinvonz@gmail.com","avatar":"https://avatars.githubusercontent.com/u/891642?v=4"},"body":"The keepcr flag is only used in the split_patches function, which is\nonly called before a patch application has to stopped for user input,\nnot after resuming. It is therefore unnecessary to persist the\nflag. This seems to have been the case since it was introduced in\nad2c928 (git-am: Add command line parameter `--keep-cr` passing it to\ngit-mailsplit, 2010-02-27).\n\nSigned-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>\n---\n git-am.sh |    7 -------\n 1 files changed, 0 insertions(+), 7 deletions(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex 9042432..1c13b13 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -530,7 +530,6 @@ else\n \techo \"$sign\" >\"$dotest/sign\"\n \techo \"$utf8\" >\"$dotest/utf8\"\n \techo \"$keep\" >\"$dotest/keep\"\n-\techo \"$keepcr\" >\"$dotest/keepcr\"\n \techo \"$scissors\" >\"$dotest/scissors\"\n \techo \"$no_inbody_headers\" >\"$dotest/no_inbody_headers\"\n \techo \"$GIT_QUIET\" >\"$dotest/quiet\"\n@@ -576,12 +575,6 @@ if test \"$(cat \"$dotest/keep\")\" = t\n then\n \tkeep=-k\n fi\n-case \"$(cat \"$dotest/keepcr\")\" in\n-t)\n-\tkeepcr=--keep-cr ;;\n-f)\n-\tkeepcr=--no-keep-cr ;;\n-esac\n case \"$(cat \"$dotest/scissors\")\" in\n t)\n \tscissors=--scissors ;;\n-- \n1.7.8.237.gcc4e3\n"},{"id":"180704","messageId":"7v1usdebnf.fsf@alter.siamese.dyndns.org","threadId":"29113","inReplyTo":"1323415845-11826-1-git-send-email-martin.von.zweigbergk@gmail.com","subject":"Re: [PATCH] am: don't persist keepcr flag","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-12-09T18:50:07Z","receivedAt":"2011-12-09T18:50:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Makes sense; thanks.\n"}]}