{"thread":{"id":"29064","subject":"[PATCH] compat/getpass.c: Fix a sparse \"symbol not declared\" warning","startedAt":"2011-11-30T20:54:27Z","lastAt":"2011-12-01T18:19:57Z","messageCount":2,"participants":["Ramsay Jones","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"180208","messageId":"4ED69803.6070508@ramsay1.demon.co.uk","threadId":"29064","inReplyTo":null,"subject":"[PATCH] compat/getpass.c: Fix a sparse \"symbol not declared\" warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-11-30T20:54:27Z","receivedAt":"2011-11-30T20:54:27Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, sparse complains as follows:\n\n        SP compat/getpass.c\n    compat/getpass.c:5:6: warning: symbol 'getpass_echo' was not \\\n        declared. Should it be static?\n\nIn order to suppress the warning, we include the getpass.h header\nfile which contains an appropriate extern declaration.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Jeff,\n\nWhen you next re-roll your most recent credentials/getpass series, could\nyou please squash this patch in. (This patch was against pu @ 1cc922af,\nbut I guess you need to apply a similar patch to commit 8eca119c \"stub out\ngetpass_echo function\", 27-11-2011 instead)\n\nThanks!\n\nATB,\nRamsay Jones\n\n compat/getpass.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/compat/getpass.c b/compat/getpass.c\nindex b5bd1dd..a145d27 100644\n--- a/compat/getpass.c\n+++ b/compat/getpass.c\n@@ -1,4 +1,5 @@\n #include \"../git-compat-util.h\"\n+#include \"getpass.h\"\n \n #ifdef HAVE_DEV_TTY\n \n-- \n1.7.7\n"},{"id":"180209","messageId":"20111201181957.GA29456@sigill.intra.peff.net","threadId":"29064","inReplyTo":"4ED69803.6070508@ramsay1.demon.co.uk","subject":"Re: [PATCH] compat/getpass.c: Fix a sparse \"symbol not declared\" warning","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-12-01T18:19:57Z","receivedAt":"2011-12-01T18:19:57Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 30, 2011 at 08:54:27PM +0000, Ramsay Jones wrote:\n\n> When you next re-roll your most recent credentials/getpass series, could\n> you please squash this patch in. (This patch was against pu @ 1cc922af,\n> but I guess you need to apply a similar patch to commit 8eca119c \"stub out\n> getpass_echo function\", 27-11-2011 instead)\n\nSure, makes sense. Thanks.\n\n-Peff\n"}]}