{"thread":{"id":"29063","subject":"[PATCH] Makefile: Add missing \"sparse object\" to gettext target-specific rule","startedAt":"2011-11-30T20:43:52Z","lastAt":"2011-11-30T20:43:52Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"180207","messageId":"4ED69588.9020207@ramsay1.demon.co.uk","threadId":"29063","inReplyTo":null,"subject":"[PATCH] Makefile: Add missing \"sparse object\" to gettext target-specific rule","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-11-30T20:43:52Z","receivedAt":"2011-11-30T20:43:52Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, we add gettext.sp to the target-specific rule which\nadds the GIT_LOCALE_PATH setting to EXTRA_CPPFLAGS, otherwise sparse\ncomplains thus:\n\n        SP gettext.c\n    gettext.c:125:25: error: undefined identifier 'GIT_LOCALE_PATH'\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Avar,\n\nIf you are going to re-roll your latest i18n patch (commit 6c856c48,\n\"i18n: add infrastructure for translating Git with gettext\", 18-11-2011),\ncould you please squash this patch into it.\n\nThanks!\n\nATB,\nRamsay Jones\n\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex ac8c76d..f926b5f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2129,7 +2129,7 @@ config.sp config.s config.o: EXTRA_CPPFLAGS = \\\n attr.sp attr.s attr.o: EXTRA_CPPFLAGS = \\\n \t-DETC_GITATTRIBUTES='\"$(ETC_GITATTRIBUTES_SQ)\"'\n \n-gettext.s gettext.o: EXTRA_CPPFLAGS = \\\n+gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \\\n \t-DGIT_LOCALE_PATH='\"$(localedir_SQ)\"'\n \n http.sp http.s http.o: EXTRA_CPPFLAGS = \\\n-- \n1.7.7\n"}]}