{"thread":{"id":"29032","subject":"[PATCH] gitweb: Output site name with valid utf8 in OPML","startedAt":"2011-11-28T01:45:46Z","lastAt":"2011-11-29T19:35:21Z","messageCount":2,"participants":["Jürgen Kreileder","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"180029","messageId":"CAKD0UuyJDaHyofM5VYG-R03mgYi_1QBJvQufv927+x6YYzPU2w@mail.gmail.com","threadId":"29032","inReplyTo":null,"subject":"[PATCH] gitweb: Output site name with valid utf8 in OPML","fromName":"Jürgen Kreileder","fromEmail":"jk@blackdown.de","sentAt":"2011-11-28T01:45:46Z","receivedAt":"2011-11-28T01:45:46Z","isPatch":true,"sender":{"key":"jk@blackdown.de","avatar":"https://avatars.githubusercontent.com/u/4390544?v=4"},"body":"Signed-off-by: Juergen Kreileder <jk@blackdown.de>\n---\n gitweb/gitweb.perl |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 4f0c3bd..df747c1 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -7699,11 +7699,12 @@ sub git_opml {\n \t\t-charset => 'utf-8',\n \t\t-content_disposition => 'inline; filename=\"opml.xml\"');\n\n+\tmy $title = esc_html($site_name);\n \tprint <<XML;\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <opml version=\"1.0\">\n <head>\n-  <title>$site_name OPML Export</title>\n+  <title>$title OPML Export</title>\n </head>\n <body>\n <outline text=\"git RSS feeds\">\n-- \n1.7.5.4\n"},{"id":"180105","messageId":"m3hb1mlo1z.fsf@localhost.localdomain","threadId":"29032","inReplyTo":"CAKD0UuyJDaHyofM5VYG-R03mgYi_1QBJvQufv927+x6YYzPU2w@mail.gmail.com","subject":"Re: [PATCH] gitweb: Output site name with valid utf8 in OPML","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-11-29T19:35:21Z","receivedAt":"2011-11-29T19:35:21Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Jürgen Kreileder <jk@blackdown.de> writes:\n\n> Signed-off-by: Juergen Kreileder <jk@blackdown.de>\n> ---\n>  gitweb/gitweb.perl |    3 ++-\n>  1 files changed, 2 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 4f0c3bd..df747c1 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -7699,11 +7699,12 @@ sub git_opml {\n>  \t\t-charset => 'utf-8',\n>  \t\t-content_disposition => 'inline; filename=\"opml.xml\"');\n> \n> +\tmy $title = esc_html($site_name);\n>  \tprint <<XML;\n>  <?xml version=\"1.0\" encoding=\"utf-8\"?>\n>  <opml version=\"1.0\">\n>  <head>\n> -  <title>$site_name OPML Export</title>\n> +  <title>$title OPML Export</title>\n>  </head>\n>  <body>\n>  <outline text=\"git RSS feeds\">\n> -- \n\nThanks.  That is certainly correct... but it is more than just\nhandling utf8, isn't it.  It was also about not escaping XML\n(think of site name containing eg. '<< foo >>' etc.).\n\nSo the subject / commit message should be corrected.\n\n-- \nJakub Narębski\n"}]}