{"thread":{"id":"29030","subject":"[PATCH] Make feed title valid utf8","startedAt":"2011-11-27T22:37:44Z","lastAt":"2011-11-29T20:11:32Z","messageCount":3,"participants":["Jürgen Kreileder","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"180024","messageId":"CAKD0UuxFVtCRT+hqO5vkDRanaX3Gvwf9MAFqNUwAiFA+wEwxXg@mail.gmail.com","threadId":"29030","inReplyTo":null,"subject":"[PATCH] Make feed title valid utf8","fromName":"Jürgen Kreileder","fromEmail":"jk@blackdown.de","sentAt":"2011-11-27T22:37:44Z","receivedAt":"2011-11-27T22:37:44Z","isPatch":true,"sender":{"key":"jk@blackdown.de","avatar":"https://avatars.githubusercontent.com/u/4390544?v=4"},"body":"gitweb doesn't properly handle UTF8 site names when generating feed titles.\n\nSigned-off-by: Juergen Kreileder <jk@blackdown.de>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 4f0c3bd..a2838c3 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -7482,7 +7482,7 @@ sub git_feed {\n \treturn if ($cgi->request_method() eq 'HEAD');\n\n \t# header variables\n-\tmy $title = \"$site_name - $project/$action\";\n+\tmy $title = to_utf8($site_name) . \" - \" . to_utf8($project) . \"/$action\";\n \tmy $feed_type = 'log';\n \tif (defined $hash) {\n \t\t$title .= \" - '$hash'\";\n-- \n1.7.5.4\n"},{"id":"180107","messageId":"m38vmylnfu.fsf@localhost.localdomain","threadId":"29030","inReplyTo":"CAKD0UuxFVtCRT+hqO5vkDRanaX3Gvwf9MAFqNUwAiFA+wEwxXg@mail.gmail.com","subject":"Re: [PATCH] Make feed title valid utf8","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-11-29T19:48:39Z","receivedAt":"2011-11-29T19:48:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Subject: gitweb: Make feed title valid utf8\n\nJürgen Kreileder <jk@blackdown.de> writes:\n\n> gitweb doesn't properly handle UTF8 site names when generating feed titles.\n> \n> Signed-off-by: Juergen Kreileder <jk@blackdown.de>\n> ---\n>  gitweb/gitweb.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 4f0c3bd..a2838c3 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -7482,7 +7482,7 @@ sub git_feed {\n>  \treturn if ($cgi->request_method() eq 'HEAD');\n> \n>  \t# header variables\n> -\tmy $title = \"$site_name - $project/$action\";\n> +\tmy $title = to_utf8($site_name) . \" - \" . to_utf8($project) . \"/$action\";\n>  \tmy $feed_type = 'log';\n>  \tif (defined $hash) {\n>  \t\t$title .= \" - '$hash'\";\n> -- \n\nThanks.  With the minor nit of prefixing subject with subsystem\ndesignation, i.e. with \"gitweb: \" -- ACK.\n\n-- \nJakub Narębski\n"},{"id":"180109","messageId":"7vfwh6sn7v.fsf@alter.siamese.dyndns.org","threadId":"29030","inReplyTo":"m38vmylnfu.fsf@localhost.localdomain","subject":"Re: [PATCH] Make feed title valid utf8","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-11-29T20:11:32Z","receivedAt":"2011-11-29T20:11:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks for patches and reviews.\n\nI am not keeping track of what is acked unconditionally, what is acked\nwith reservation i.e. \"with this tweak on top\", and what is rejected with\nsuggestion of an alternative, though. I hope I can expect to see a series\nthat is finished between you two to be resent for application after 1.7.8\nships.\n"}]}