{"thread":{"id":"29015","subject":"[PATCH] make git-svn resilient to log.abbrevcommit = true","startedAt":"2011-11-24T07:16:28Z","lastAt":"2011-11-24T18:32:33Z","messageCount":3,"participants":["Shahid Alam","Thomas Rast","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"179930","messageId":"3A78B8F7-803C-4278-8B5F-4A1B02C9FF04@gmail.com","threadId":"29015","inReplyTo":null,"subject":"[PATCH] make git-svn resilient to log.abbrevcommit = true","fromName":"Shahid Alam","fromEmail":"shahid.alam@gmail.com","sentAt":"2011-11-24T07:16:28Z","receivedAt":"2011-11-24T07:16:28Z","isPatch":true,"sender":{"key":"shahid.alam@gmail.com","avatar":null},"body":"Add --no-abbrev-commit arg to working_head_Info()'s invocation\nof git log.\n---\ngit-svn.perl |    2 +-\n1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 351e743..da4c240 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {\nsub working_head_info {\n\tmy ($head, $refs) = @_;\n\tmy @args = qw/log --no-color --no-decorate --first-parent\n-\t              --pretty=medium/;\n+\t              --no-abbrev-commit --pretty=medium/;\n\tmy ($fh, $ctx) = command_output_pipe(@args, $head);\n\tmy $hash;\n\tmy %max;\n-- \n1.7.7.2\n"},{"id":"179950","messageId":"201111241411.05655.trast@student.ethz.ch","threadId":"29015","inReplyTo":"3A78B8F7-803C-4278-8B5F-4A1B02C9FF04@gmail.com","subject":"Re: [PATCH] make git-svn resilient to log.abbrevcommit = true","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-11-24T13:11:05Z","receivedAt":"2011-11-24T13:11:05Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"[add Eric to Cc]\n\nShahid Alam wrote:\n> Add --no-abbrev-commit arg to working_head_Info()'s invocation\n> of git log.\n[...]\n> @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {\n> sub working_head_info {\n> \tmy ($head, $refs) = @_;\n> \tmy @args = qw/log --no-color --no-decorate --first-parent\n> -\t              --pretty=medium/;\n> +\t              --no-abbrev-commit --pretty=medium/;\n\nUndeniably a bug, but to prevent the same from happening again,\nwouldn't it be better to rewrite it using simply\n\n  rev-list --first-parent --pretty=medium\n\n?\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"179953","messageId":"20111124183233.GA22111@dcvr.yhbt.net","threadId":"29015","inReplyTo":"201111241411.05655.trast@student.ethz.ch","subject":"Re: [PATCH] make git-svn resilient to log.abbrevcommit = true","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2011-11-24T18:32:33Z","receivedAt":"2011-11-24T18:32:33Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Thomas Rast <trast@student.ethz.ch> wrote:\n> Shahid Alam wrote:\n> > Add --no-abbrev-commit arg to working_head_Info()'s invocation\n> > of git log.\n> [...]\n> > @@ -1803,7 +1803,7 @@ sub cmt_sha2rev_batch {\n> > sub working_head_info {\n> > \tmy ($head, $refs) = @_;\n> > \tmy @args = qw/log --no-color --no-decorate --first-parent\n> > -\t              --pretty=medium/;\n> > +\t              --no-abbrev-commit --pretty=medium/;\n> \n> Undeniably a bug, but to prevent the same from happening again,\n> wouldn't it be better to rewrite it using simply\n> \n>   rev-list --first-parent --pretty=medium\n\nYes, I've never been happy with using \"git log\" for any internals since\nit's a porcelain.  I'll gladly accept a tested patch which uses rev-list\ninstead.  Thanks!\n"}]}