{"thread":{"id":"2896","subject":"[PATCH] Avoid misleading success message on error","startedAt":"2005-12-21T16:53:29Z","lastAt":"2005-12-21T20:47:19Z","messageCount":2,"participants":["Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"13869","messageId":"Pine.LNX.4.63.0512211752340.16125@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"2896","inReplyTo":null,"subject":"[PATCH] Avoid misleading success message on error","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2005-12-21T16:53:29Z","receivedAt":"2005-12-21T16:53:29Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nWhen a push fails (for example when the remote head does not fast forward \nto the desired ref) it is not correct to print \"Everything up-to-date\".\n\nSigned-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>\n\n---\n\n send-pack.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\n67819bb187daa5a976bc3d721d5c9f920f52e4ba\ndiff --git a/send-pack.c b/send-pack.c\nindex a41bbe5..5bc2f01 100644\n--- a/send-pack.c\n+++ b/send-pack.c\n@@ -272,7 +272,7 @@ static int send_pack(int in, int out, in\n \tpacket_flush(out);\n \tif (new_refs)\n \t\tpack_objects(out, remote_refs);\n-\telse\n+\telse if (ret == 0)\n \t\tfprintf(stderr, \"Everything up-to-date\\n\");\n \tclose(out);\n \treturn ret;\n-- \n0.99.9.GIT\n"},{"id":"13885","messageId":"7vmziu6uug.fsf@assigned-by-dhcp.cox.net","threadId":"2896","inReplyTo":"Pine.LNX.4.63.0512211752340.16125@wbgn013.biozentrum.uni-wuerzburg.de","subject":"Re: [PATCH] Avoid misleading success message on error","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-12-21T20:47:19Z","receivedAt":"2005-12-21T20:47:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> When a push fails (for example when the remote head does not fast forward \n> to the desired ref) it is not correct to print \"Everything up-to-date\".\n\nThanks.\n"}]}