{"thread":{"id":"28950","subject":"Re: gitweb ignores git-daemon-export-ok and displays all repositories","startedAt":"2011-11-16T22:47:06Z","lastAt":"2011-11-26T14:37:51Z","messageCount":2,"participants":["Jonathan Nieder","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"179600","messageId":"20111116224706.GA17851@elie.hsd1.il.comcast.net","threadId":"28950","inReplyTo":"D765D350-947E-4DB2-8A91-4B9653064F80@code.de","subject":"Re: gitweb ignores git-daemon-export-ok and displays all repositories","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-11-16T22:47:06Z","receivedAt":"2011-11-16T22:47:06Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi gitwebbers,\n\nErik Wenzel wrote[1]:\n> Am 13.11.2011 um 02.19 schrieb Jonathan Nieder:\n\n>> The git-daemon(1) manpage describes git daemon, not gitweb, so I guess\n>> you mean that\n>>\n>>\t# Do not list projects without git-daemon-export-ok in the\n>>\t# projects list.\n>>\tour $export_ok = \"git-daemon-export-ok\";\n>>\n>>\t# Do not allow access to projects not listed in the projects\n>>\t# list.\n>>\tour $strict_export = 1;\n>>\n>> should be the default.\n[...]\n> Because I think this is the way a user is expecting the behavior of gitweb.\n> As I do. Don't let gitweb overwrite the meaning of \"git-daemon-export-ok\".\n> Just act like git-daemon. Keep it simple and stupid.\n\nMy first thought was that if we could turn back time, it would\nprobably be best for both git-daemon and gitweb to look for a file\nnamed git-export-ok.  In the present world, maybe git-daemon-export-ok\nis a good substitute for that.\n\nWhat do you think?  Should the default in the makefile be changed?  If\nso, how could we go about it to avoid disturbing existing\ninstallations?  (For example, in a system where no repositories have\nthe export-ok files and \"git daemon\" is configured to run with\n--export-all, the effect would be to make repos suddenly disappear\nfrom the projects list in gitweb.  Unpleasant.)\n\nLooking forward to your thoughts,\nJonathan\n\n[1] http://bugs.debian.org/648561\n"},{"id":"179986","messageId":"201111261537.52613.jnareb@gmail.com","threadId":"28950","inReplyTo":"20111116224706.GA17851@elie.hsd1.il.comcast.net","subject":"Re: gitweb ignores git-daemon-export-ok and displays all repositories","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-11-26T14:37:51Z","receivedAt":"2011-11-26T14:37:51Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"I'm sorry for the delay in responding.\n\nOn Wed, 16 Nov 2011, Jonathan Nieder wrote:\n> Erik Wenzel wrote (http://bugs.debian.org/648561):\n>> Am 13.11.2011 um 02.19 schrieb Jonathan Nieder:\n>> \n>>> The git-daemon(1) manpage describes git daemon, not gitweb, so I guess\n>>> you mean that\n>>>\n>>>\t# Do not list projects without git-daemon-export-ok in the\n>>>\t# projects list.\n>>>\tour $export_ok = \"git-daemon-export-ok\";\n>>>\n>>>\t# Do not allow access to projects not listed in the projects\n>>>\t# list.\n>>>\tour $strict_export = 1;\n>>>\n>>> should be the default.\n>> [...]\n>> Because I think this is the way a user is expecting the behavior of gitweb.\n>> As I do. Don't let gitweb overwrite the meaning of \"git-daemon-export-ok\".\n>> Just act like git-daemon. Keep it simple and stupid.\n> \n> My first thought was that if we could turn back time, it would\n> probably be best for both git-daemon and gitweb to look for a file\n> named git-export-ok.  In the present world, maybe git-daemon-export-ok\n> is a good substitute for that.\n> \n> What do you think?  Should the default in the makefile be changed?  If\n> so, how could we go about it to avoid disturbing existing\n> installations?  (For example, in a system where no repositories have\n> the export-ok files and \"git daemon\" is configured to run with\n> --export-all, the effect would be to make repos suddenly disappear\n> from the projects list in gitweb.  Unpleasant.)\n\nI think the best solution would be to leave it up to the tool that\nmanages both git-daemon and git (manages access to git repositories),\nlike e.g. gitolite.  It would be this tool that is to be responsible\nfor synchronizing git-daemon and gitweb behavior, i.e. make either\nboth use 'git-daemon-export-ok', or both export all.\n\n-- \nJakub Narebski\nPoland\n"}]}