{"thread":{"id":"28933","subject":"[PATCH] svn: Create config options for common args","startedAt":"2011-11-14T20:25:10Z","lastAt":"2011-11-14T21:46:02Z","messageCount":2,"participants":["Ted Percival","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"179440","messageId":"1321302310-28793-1-git-send-email-ted.percival@quest.com","threadId":"28933","inReplyTo":null,"subject":"[PATCH] svn: Create config options for common args","fromName":"Ted Percival","fromEmail":"ted.percival@quest.com","sentAt":"2011-11-14T20:25:10Z","receivedAt":"2011-11-14T20:25:10Z","isPatch":true,"sender":{"key":"ted@midg3t.net","avatar":"https://avatars.githubusercontent.com/u/253416?v=4"},"body":"These config options may be set to apply to all commands on the\nrepository in lieu of providing the command-line options each time:\n  svn.localtime: --localtime\n  svn.useLogAuthor: --use-log-author\n  svn.addAuthorFrom: --add-author-from\n\nSince these flags apply to multiple operations, it's easier to set them\nonce rather than remembering to use them every time for every operation.\n\nSigned-off-by: Ted Percival <ted.percival@quest.com>\n---\n Documentation/git-svn.txt |   10 ++++++++++\n git-svn.perl              |    3 +++\n 2 files changed, 13 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 34ee785..20f8edd 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -113,6 +113,9 @@ repository you cloned from, but if you wish for your local Git\n repository to be able to interoperate with someone else's local Git\n repository, either don't use this option or you should both use it in\n the same local timezone.\n++\n+[verse]\n+config key: svn.localtime\n \n --parent;;\n \tFetch only from the SVN parent of the current HEAD.\n@@ -596,12 +599,19 @@ creating the branch or tag.\n \tWhen retrieving svn commits into git (as part of 'fetch', 'rebase', or\n \t'dcommit' operations), look for the first `From:` or `Signed-off-by:` line\n \tin the log message and use that as the author string.\n++\n+[verse]\n+config key: svn.useLogAuthor\n+\n --add-author-from::\n \tWhen committing to svn from git (as part of 'commit-diff', 'set-tree' or 'dcommit'\n \toperations), if the existing log message doesn't already have a\n \t`From:` or `Signed-off-by:` line, append a `From:` line based on the\n \tgit commit's author string.  If you use this, then `--use-log-author`\n \twill retrieve a valid author string for all commits.\n++\n+[verse]\n+config key: svn.addAuthorFrom\n \n \n ADVANCED OPTIONS\ndiff --git a/git-svn.perl b/git-svn.perl\nindex e30df22..d69b0d7 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -21,6 +21,9 @@ $Git::SVN::default_repo_id = 'svn';\n $Git::SVN::default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';\n $Git::SVN::Ra::_log_window_size = 100;\n $Git::SVN::_minimize_url = 'unset';\n+$Git::SVN::_localtime = Git::config_bool('svn.localtime');\n+$Git::SVN::_add_author_from = Git::config_bool('svn.addAuthorFrom');\n+$Git::SVN::_use_log_author = Git::config_bool('svn.useLogAuthor');\n \n if (! exists $ENV{SVN_SSH} && exists $ENV{GIT_SSH}) {\n \t$ENV{SVN_SSH} = $ENV{GIT_SSH};\n-- \n1.7.7.1\n"},{"id":"179449","messageId":"20111114214602.GA22399@dcvr.yhbt.net","threadId":"28933","inReplyTo":"1321302310-28793-1-git-send-email-ted.percival@quest.com","subject":"Re: [PATCH] svn: Create config options for common args","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2011-11-14T21:46:02Z","receivedAt":"2011-11-14T21:46:02Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Ted Percival <ted.percival@quest.com> wrote:\n>  Documentation/git-svn.txt |   10 ++++++++++\n\nThanks, documentation part is very much appreciated\n\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -21,6 +21,9 @@ $Git::SVN::default_repo_id = 'svn';\n>  $Git::SVN::default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn';\n>  $Git::SVN::Ra::_log_window_size = 100;\n>  $Git::SVN::_minimize_url = 'unset';\n> +$Git::SVN::_localtime = Git::config_bool('svn.localtime');\n> +$Git::SVN::_add_author_from = Git::config_bool('svn.addAuthorFrom');\n> +$Git::SVN::_use_log_author = Git::config_bool('svn.useLogAuthor');\n\nI don't think these are needed.  The read_git_config() function /should/\nbe checking all GIT_CONFIG equivalents of the Getopt::Long option specs.\nCan you verify?  Thanks.\n"}]}