{"thread":{"id":"28911","subject":"[PATCH/RFC] Restore line limit option in post-receive-email","startedAt":"2011-11-11T06:35:11Z","lastAt":"2012-01-12T21:01:10Z","messageCount":4,"participants":["Cheng Leong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"179301","messageId":"1320993311-27112-1-git-send-email-leongc@alumni.rice.edu","threadId":"28911","inReplyTo":null,"subject":"[PATCH/RFC] Restore line limit option in post-receive-email","fromName":"Cheng Leong","fromEmail":"leongc@alumni.rice.edu","sentAt":"2011-11-11T06:35:11Z","receivedAt":"2011-11-11T06:35:11Z","isPatch":true,"sender":{"key":"leongc@alumni.rice.edu","avatar":null},"body":"The hooks.emailmaxlines config currently has no effect. Stop\nprep_for_email from clobbering the already-initialized maxlines\nvariable in the contrib/hooks/post-receive-email example.\n\nSigned-off-by: Cheng Leong <leongc@alumni.rice.edu>\n---\n contrib/hooks/post-receive-email |    1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex ba077c1..ac2e0ed 100755\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -85,7 +85,6 @@ prep_for_email()\n \toldrev=$(git rev-parse $1)\n \tnewrev=$(git rev-parse $2)\n \trefname=\"$3\"\n-\tmaxlines=$4\n \n \t# --- Interpret\n \t# 0000->1234 (create)\n-- \n1.7.7.1.msysgit.0\n"},{"id":"179302","messageId":"7v4nybrvug.fsf@alter.siamese.dyndns.org","threadId":"28911","inReplyTo":"1320993311-27112-1-git-send-email-leongc@alumni.rice.edu","subject":"Re: [PATCH/RFC] Restore line limit option in post-receive-email","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-11-11T06:56:07Z","receivedAt":"2011-11-11T06:56:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Cheng Leong <leongc@alumni.rice.edu> writes:\n\n> The hooks.emailmaxlines config currently has no effect. Stop\n> prep_for_email from clobbering the already-initialized maxlines\n> variable in the contrib/hooks/post-receive-email example.\n>\n> Signed-off-by: Cheng Leong <leongc@alumni.rice.edu>\n> ---\n>  contrib/hooks/post-receive-email |    1 -\n>  1 files changed, 0 insertions(+), 1 deletions(-)\n>\n> diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\n> index ba077c1..ac2e0ed 100755\n> --- a/contrib/hooks/post-receive-email\n> +++ b/contrib/hooks/post-receive-email\n> @@ -85,7 +85,6 @@ prep_for_email()\n>  \toldrev=$(git rev-parse $1)\n>  \tnewrev=$(git rev-parse $2)\n>  \trefname=\"$3\"\n> -\tmaxlines=$4\n>  \n>  \t# --- Interpret\n>  \t# 0000->1234 (create)\n\nUmm, there is another place where $maxlines is used without\nmerit. Shouldn't we do something like below as well?\n\n contrib/hooks/post-receive-email |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex ba077c1..e27ca3c 100755\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -743,6 +743,6 @@ else\n \twhile read oldrev newrev refname\n \tdo\n \t\tprep_for_email $oldrev $newrev $refname || continue\n-\t\tgenerate_email $maxlines | send_mail\n+\t\tgenerate_email | send_mail\n \tdone\n fi\n"},{"id":"179304","messageId":"CACor6wGkDPSkA_G117YtnsQA7H_cROKKW69m-jW_rb2SrVWo1w@mail.gmail.com","threadId":"28911","inReplyTo":"7v4nybrvug.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH/RFC] Restore line limit option in post-receive-email","fromName":"Cheng Leong","fromEmail":"leongc@alumni.rice.edu","sentAt":"2011-11-11T07:08:36Z","receivedAt":"2011-11-11T07:08:36Z","isPatch":true,"sender":{"key":"leongc@alumni.rice.edu","avatar":null},"body":"Junio C Hamano <gitster@pobox.com> wrote:\n> Umm, there is another place where $maxlines is used without\n> merit. Shouldn't we do something like below as well?\n...\n> -               generate_email $maxlines | send_mail\n> +               generate_email | send_mail\n\nAgree. $maxlines is harmless, but extraneous here.\nWould you like me to reroll a patch with both or is this a trivial fixup?\n\nCheng\n"},{"id":"182468","messageId":"loom.20120112T215910-481@post.gmane.org","threadId":"28911","inReplyTo":"CACor6wGkDPSkA_G117YtnsQA7H_cROKKW69m-jW_rb2SrVWo1w@mail.gmail.com","subject":"Re: [PATCH/RFC] Restore line limit option in post-receive-email","fromName":"Cheng Leong","fromEmail":"cleong@netspend.com","sentAt":"2012-01-12T21:01:10Z","receivedAt":"2012-01-12T21:01:10Z","isPatch":true,"sender":{"key":"cleong@netspend.com","avatar":null},"body":"> Would you like me to reroll a patch with both or is this a trivial fixup?\n\nBump. What do I need to do to contribute this patch?\n\nThanks,\nCheng\n"}]}