{"thread":{"id":"2890","subject":"Random notes about qgit","startedAt":"2005-12-21T02:48:20Z","lastAt":"2005-12-21T16:56:59Z","messageCount":3,"participants":["Pavel Roskin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"13851","messageId":"1135133300.3202.6.camel@dv","threadId":"2890","inReplyTo":null,"subject":"Random notes about qgit","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-12-21T02:48:20Z","receivedAt":"2005-12-21T02:48:20Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"Hello, Marco!\n\nHere's some assorted notes about current qgit.\n\nThanks for making the range dialog optional, but now I don't see any way\nto see the local changes unless I re-enable the dialog.  I think it\nshould be an action activated from the menu - \"diff local files to this\nrevision\".  Or maybe the \"local\" radio button in the diff pane.\n\nCurrent qgit seems to have another crash, also annotation related.  Run\nqgit on its own repository.  Select \"Add range select dialog options\",\nthen double click on src/commitimpl.cpp in the file list.  Sometimes it\nworks, sometimes it crashes like this:\n\nASSERT getFileAnnotation: no revision\n9771bea705024b3d0a59e1b9144adf5d77ca82d1\n\nSometimes you need to select other revisions and double click on other\nfiles.  Another assert I got was:\n\nASSERT getFileAnnotation: no revision\nbbf2abcbcafc2e458343034c8f249ac4956ec4fb\n\n\"git-cat-file commit\" works fine on both revisions.  Just in case, I'm\nseeing this on x86_64.\n\n\"View->Revision Diff\" and \"View->Archive Tree\" work differently.  The\nformer doesn't allow to turn the pane off.  I'd like it to work like\n\"View->Archive Tree\".  Neither can \"Revision Diff\" be closed from the\npopup menu.\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"13866","messageId":"1135182156.5602.15.camel@dv","threadId":"2890","inReplyTo":"e5bfff550512210417p1d363017p9d08e3c55fc841d5@mail.gmail.com","subject":"Re: Random notes about qgit","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-12-21T16:22:36Z","receivedAt":"2005-12-21T16:22:36Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"On Wed, 2005-12-21 at 13:17 +0100, Marco Costalba wrote:\n> On 12/21/05, Pavel Roskin <proski@gnu.org> wrote:\n> \n> > Thanks for making the range dialog optional, but now I don't see any way\n> > to see the local changes unless I re-enable the dialog.  I think it\n> > should be an action activated from the menu - \"diff local files to this\n> > revision\".  Or maybe the \"local\" radio button in the diff pane.\n> >\n> \n> Actually you could re-enable working dir diffs from\n> menu->edit->settings->'git index'\n\nIndeed.  Thank you!\n\n> Do you think is too hidden?\n\nIt shouldn't be an option.  It should be an action, available on demand,\nregardless of options.  In the majority of cases, only diff to the head\nrevision is needed, but some users may want to see diff against other\nrevisions, e.g. when verifying manual merge.\n\nMaybe there should be an option to check the local diff on startup and\nindicate it somehow (not necessarily in the revision list) if it's not\nempty.\n\nBut I'm not a GUI expert and I don't know how to make it easy to\ndiscover without being constantly in the way.\n\n> > Current qgit seems to have another crash, also annotation related.  Run\n> > qgit on its own repository.  Select \"Add range select dialog options\",\n> > then double click on src/commitimpl.cpp in the file list.  Sometimes it\n> > works, sometimes it crashes like this:\n> >\n> > ASSERT getFileAnnotation: no revision\n> > 9771bea705024b3d0a59e1b9144adf5d77ca82d1\n> \n> I cannot reproduce the bug but please Pavel, add qDebug() lines\n> in git.cpp as following:\n\nOK, this will be a in separate thread.\n\n> > \"View->Revision Diff\" and \"View->Archive Tree\" work differently.  The\n> > former doesn't allow to turn the pane off.  I'd like it to work like\n> > \"View->Archive Tree\".  Neither can \"Revision Diff\" be closed from the\n> > popup menu.\n> >\n> \n> Yes, \"View->Revision Diff\" should be a toggle action.  ;-)\n\nOK\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"13870","messageId":"1135184219.5602.25.camel@dv","threadId":"2890","inReplyTo":"e5bfff550512210417p1d363017p9d08e3c55fc841d5@mail.gmail.com","subject":"getFileAnnotation: no revision","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-12-21T16:56:59Z","receivedAt":"2005-12-21T16:56:59Z","isPatch":false,"sender":{"key":"proski@gnu.org","avatar":null},"body":"On Wed, 2005-12-21 at 13:17 +0100, Marco Costalba wrote:\n> I cannot reproduce the bug but please Pavel, add qDebug() lines\n> in git.cpp as following:\n\nPlease use a mail client that doesn't damage inline attachments, or use\nattachments.  The diff was wrapped before it was base64 encoded.  I had\nto unwrap it manually.  Although, I guess you don't have much choice\nwith Google.\n\nI had to replace %i with %li and (int) with (long) to make the compiler\nhappy.  It's a 64-bit platform.\n\n> Then, please, try to reproduce the crash and send me the output.\n\n$ bin/qgit\nGit::cancelAnnotate 0\nGit::getFileHistory src/commitimpl.cpp\nGit::startAnnotate 7943344\nGit::runAnnotate 7943344\nASSERT getFileAnnotation: no revision\nbbf2abcbcafc2e458343034c8f249ac4956ec4fb\ncancelingAnnotate 0\nSegmentation fault\n\n-- \nRegards,\nPavel Roskin\n"}]}