{"thread":{"id":"28889","subject":"git-svn: t9155 fails against subversion 1.7.0","startedAt":"2011-11-08T22:09:30Z","lastAt":"2012-02-07T20:15:19Z","messageCount":6,"participants":["Frans Klaver","Robin H. Johnson","Eric Wong","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"179167","messageId":"op.v4neh4q20aolir@keputer","threadId":"28889","inReplyTo":null,"subject":"git-svn: t9155 fails against subversion 1.7.0","fromName":"Frans Klaver","fromEmail":"fransklaver@gmail.com","sentAt":"2011-11-08T22:09:30Z","receivedAt":"2011-11-08T22:09:30Z","isPatch":false,"sender":{"key":"fransklaver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1876483?v=4"},"body":"For kicks I decided to run the tests and noticed that on master \nt9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an \nassertion in subversion's dirent_uri.c, stating that we don't provide a \ncanonical url. I haven't tested against other subversion versions. I dare \nassume that this issue doesn't arise on earlier versions. It probably \nwon't affect a lot of users right now, but it will in the future.\n\nHere's some verbose test output:\nexpecting success:\n\tgit svn init --stdlayout \"$svnrepo\" git_project &&\n\tcd git_project &&\n\tgit svn fetch &&\n\n\tgit diff --exit-code mybranch:trunk/subdir/file tags/mytag:file &&\n\tgit diff --exit-code master:subdir/file tags/mytag^:file\n\nInitialized empty Git repository in /home/frans/devsw/git/t/trash \ndirectory.t9155-git-svn-fetch-deleted-tag/git_project/.git/\nsvn: E235000: In file 'subversion/libsvn_subr/dirent_uri.c' line 2291: \nassertion failed (svn_uri_is_canonical(url, pool))\nerror: git-svn died of signal 6\nnot ok - 2 fetch deleted tags from same revision with checksum error\n\nI've been trying to debug and got down to:\nGit::SVN::Ra::new(/home/frans/devsw/git/git-svn:5496):\n5496:\t\tmy $self = SVN::Ra->new(url => escape_url($url), auth => $baton,\n5497:\t\t config => $config,\n5498:\t\t\t\t pool => SVN::Pool->new,\n5499:\t\t auth_provider_callbacks => $callbacks);\n...\nSVN::Ra::new(/usr/lib/perl5/vendor_perl/5.12.4/i686-linux/SVN/Ra.pm:529):\n529:\t $self->{session} = SVN::_Ra::svn_ra_open($self->{url}, $callback, \n$self->{config} || {}, $pool);\n DB<3> p $self->{url}\nfile:///home/frans/devsw/git/t/trash \ndirectory.t9155-git-svn-fetch-deleted-tag/svnrepo\n\nThe url looks like that throughout the stack (as far as I've seen), so if \nit is wrong, it is probably wrong at top-level. Hope someone with a bit \nmore experience knows how to deal with this.\n\nThanks,\nFrans\n"},{"id":"179236","messageId":"op.v4pu1zcq0aolir@keputer","threadId":"28889","inReplyTo":"op.v4neh4q20aolir@keputer","subject":"Re: git-svn: t9155 fails against subversion 1.7.0","fromName":"Frans Klaver","fromEmail":"fransklaver@gmail.com","sentAt":"2011-11-10T06:02:13Z","receivedAt":"2011-11-10T06:02:13Z","isPatch":false,"sender":{"key":"fransklaver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1876483?v=4"},"body":"I missed $gmane/184644 in my search for this issue.\n\n\nOn Tue, 08 Nov 2011 23:09:30 +0100, Frans Klaver \nwrote:\n\n> For kicks I decided to run the tests and noticed that on master \n> t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an \n> assertion in subversion's dirent_uri.c, stating that we don't provide a \n> canonical url. I haven't tested against other subversion versions. I \n> dare assume that this issue doesn't arise on earlier versions. It \n> probably won't affect a lot of users right now, but it will in the \n> future.\n>\n> Here's some verbose test output:\n> expecting success:\n> \tgit svn init --stdlayout \"$svnrepo\" git_project &&\n> \tcd git_project &&\n> \tgit svn fetch &&\n>\n> \tgit diff --exit-code mybranch:trunk/subdir/file tags/mytag:file &&\n> \tgit diff --exit-code master:subdir/file tags/mytag^:file\n>\n> Initialized empty Git repository in /home/frans/devsw/git/t/trash \n> directory.t9155-git-svn-fetch-deleted-tag/git_project/.git/\n> svn: E235000: In file 'subversion/libsvn_subr/dirent_uri.c' line 2291: \n> assertion failed (svn_uri_is_canonical(url, pool))\n> error: git-svn died of signal 6\n> not ok - 2 fetch deleted tags from same revision with checksum error\n>\n> I've been trying to debug and got down to:\n> Git::SVN::Ra::new(/home/frans/devsw/git/git-svn:5496):\n> 5496:\t\tmy $self = SVN::Ra->new(url => escape_url($url), auth => $baton,\n> 5497:\t\t config => $config,\n> 5498:\t\t\t\t pool => SVN::Pool->new,\n> 5499:\t\t auth_provider_callbacks => $callbacks);\n> ...\n> SVN::Ra::new(/usr/lib/perl5/vendor_perl/5.12.4/i686-linux/SVN/Ra.pm:529):\n> 529:\t $self->{session} = SVN::_Ra::svn_ra_open($self->{url}, \n> $callback, $self->{config} || {}, $pool);\n> DB<3> p $self->{url}\n> file:///home/frans/devsw/git/t/trash \n> directory.t9155-git-svn-fetch-deleted-tag/svnrepo\n>\n> The url looks like that throughout the stack (as far as I've seen), so \n> if it is wrong, it is probably wrong at top-level. Hope someone with a \n> bit more experience knows how to deal with this.\n>\n> Thanks,\n> Frans\n\n\n-- \nUsing Opera's revolutionary e-mail client: http://www.opera.com/mail/\n"},{"id":"183923","messageId":"robbat2-20120205T212444-523294742Z@orbis-terrarum.net","threadId":"28889","inReplyTo":"op.v4pu1zcq0aolir@keputer","subject":"Re: git-svn: t9155 fails against subversion 1.7.0","fromName":"Robin H. Johnson","fromEmail":"robbat2@gentoo.org","sentAt":"2012-02-05T21:25:21Z","receivedAt":"2012-02-05T21:25:21Z","isPatch":false,"sender":{"key":"robbat2@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/373898?v=4"},"body":"On Thu, Nov 10, 2011 at 07:02:13AM +0100, Frans Klaver wrote:\n> I missed $gmane/184644 in my search for this issue.\nDid you make any progress in fixing this?\n\n> On Tue, 08 Nov 2011 23:09:30 +0100, Frans Klaver \n> wrote:\n> \n> > For kicks I decided to run the tests and noticed that on master \n> > t9155-git-svn-fetch-deleted-tag fails against svn 1.7.0. We hit an \n> > assertion in subversion's dirent_uri.c, stating that we don't provide a \n> > canonical url. I haven't tested against other subversion versions. I \n> > dare assume that this issue doesn't arise on earlier versions. It \n> > probably won't affect a lot of users right now, but it will in the \n> > future.\n\n-- \nRobin Hugh Johnson\nGentoo Linux: Developer, Trustee & Infrastructure Lead\nE-Mail : robbat2@gentoo.org\nGnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85\n"},{"id":"183995","messageId":"CAH6sp9ORKvXt2_V4UgESTY7Tn2=9ysjWS3dO4eGgxCuZY1a5Yw@mail.gmail.com","threadId":"28889","inReplyTo":"robbat2-20120205T212444-523294742Z@orbis-terrarum.net","subject":"Re: git-svn: t9155 fails against subversion 1.7.0","fromName":"Frans Klaver","fromEmail":"fransklaver@gmail.com","sentAt":"2012-02-06T08:02:28Z","receivedAt":"2012-02-06T08:02:28Z","isPatch":false,"sender":{"key":"fransklaver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1876483?v=4"},"body":"Hi Robin,\n\nOn Sun, Feb 5, 2012 at 10:25 PM, Robin H. Johnson wrote:\n> On Thu, Nov 10, 2011 at 07:02:13AM +0100,  Frans Klaver wrote:\n>> I missed $gmane/184644 in my search for this issue.\n> Did you make any progress in fixing this?\n\nI haven't invested time in this, and the tests still seem to fail on\nsubversion 1.7.x. Maybe one of the people involved in $gmane/184644\nknows more?\n\nCheers,\nFrans\n"},{"id":"184073","messageId":"20120206225900.GA23830@dcvr.yhbt.net","threadId":"28889","inReplyTo":"CAH6sp9ORKvXt2_V4UgESTY7Tn2=9ysjWS3dO4eGgxCuZY1a5Yw@mail.gmail.com","subject":"Re: git-svn: t9155 fails against subversion 1.7.0","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2012-02-06T22:59:00Z","receivedAt":"2012-02-06T22:59:00Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Frans Klaver wrote:\n> I haven't invested time in this, and the tests still seem to fail on\n> subversion 1.7.x. Maybe one of the people involved in $gmane/184644\n> knows more?\n\nNot me. I haven't had time/interest in dealing with SVN in a while.\n\nI've always hoped somebody else has the time+interest for git-svn, but\ngiven the self-obsoleting nature of git-svn, it's hard to find\nmotivation.\n"},{"id":"184162","messageId":"20120207201518.GA6630@burratino","threadId":"28889","inReplyTo":"1328575605-sup-4117@pinkfloyd.chass.utoronto.ca","subject":"Re: git-svn: t9155 fails against subversion 1.7.0","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2012-02-07T20:15:19Z","receivedAt":"2012-02-07T20:15:19Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ben Walton wrote:\n\n> This is still on my todo list as I'd like to have a working bridge\n> (and to be able to run the svn test suite when packaging for\n> solaris). I've not had the required time to dig into this once it\n> proved to be non-trivial breakage though.\n\nThanks. Just a quick update: I can confirm that\n\n - Something like your original patch will probably take care of this,\n once a few residual svn bugs are ironed out.\n\n - Unfortunately, there are a few residual svn bugs, such as\n .\n\n - The svn developers are very helpful. Hopefully among us we should\n eventually make progress, given enough time. ;-)\n\nAh, but time is hard to find here, too...\n\nProposal: I'm willing to maintain drafts of a patch to fix the test\nbreakage. Send me patches and I'll blindly apply them to a dedicated\nbranch in a repo on repo.or.cz, so small improvements are easier to\nmake. (Or if someone else wants to take care of the same, I'd be even\nhappier.) Once it's working, we can send the result in some more\nlogical form to the list for application to mainline.\n\nCiao,\nJonathan\n"}]}