{"thread":{"id":"2888","subject":"[PATCH] gqit: enable compiler warnings","startedAt":"2005-12-21T02:11:08Z","lastAt":"2005-12-21T07:11:54Z","messageCount":2,"participants":["Pavel Roskin","Marco Costalba"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"13848","messageId":"1135131068.1183.6.camel@dv","threadId":"2888","inReplyTo":null,"subject":"[PATCH] gqit: enable compiler warnings","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-12-21T02:11:08Z","receivedAt":"2005-12-21T02:11:08Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"The \"-O2\" flag should be separated from the threading support.  Besides,\nit belongs to CCFLAGS (compile flags common to C and C++), not to\nCPPFLAGS (preprocessor flags).  While at that, enable all warnings by\n-Wall, except those about non-virtual destructors, which are \"inherited\"\nfrom Qt.  Portability is not affected since -O2 was already\ngcc-specific.\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/SConstruct b/SConstruct\nindex 55fd206..b0b5d0f 100644\n--- a/SConstruct\n+++ b/SConstruct\n@@ -27,8 +27,10 @@ env['ENV']['HOME'] = os.environ['HOME'] \n \n installDir = env['HOME']+'/bin'\n \n+env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] )\n+\n ## Uncomment the following if you need threading support threading\n-env.Append( CPPFLAGS = ['-O2', '-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )\n+env.Append( CPPFLAGS = ['-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )\n if os.uname()[0] == \"FreeBSD\":\n \tenv.Append(LINKFLAGS=[\"-pthread\"])\n \n\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"13859","messageId":"43A9003A.8010408@yahoo.it","threadId":"2888","inReplyTo":"1135131068.1183.6.camel@dv","subject":"Re: [PATCH] gqit: enable compiler warnings","fromName":"Marco Costalba","fromEmail":"mcostalba@yahoo.it","sentAt":"2005-12-21T07:11:54Z","receivedAt":"2005-12-21T07:11:54Z","isPatch":true,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Pavel Roskin wrote:\n> The \"-O2\" flag should be separated from the threading support.  Besides,\n> it belongs to CCFLAGS (compile flags common to C and C++), not to\n> CPPFLAGS (preprocessor flags).  While at that, enable all warnings by\n> -Wall, except those about non-virtual destructors, which are \"inherited\"\n> from Qt.  Portability is not affected since -O2 was already\n> gcc-specific.\n> \n> Signed-off-by: Pavel Roskin <proski@gnu.org>\n> \nThanks applied.\n\n\t\t\n___________________________________ \nYahoo! Messenger: chiamate gratuite in tutto il mondo \nhttp://it.messenger.yahoo.com\n"}]}