{"thread":{"id":"28865","subject":"[PATCH] remote: fix remote set-url usage","startedAt":"2011-11-07T03:36:57Z","lastAt":"2011-11-07T09:48:41Z","messageCount":5,"participants":["Felipe Contreras","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"178995","messageId":"1320637017-30863-1-git-send-email-felipe.contreras@gmail.com","threadId":"28865","inReplyTo":null,"subject":"[PATCH] remote: fix remote set-url usage","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2011-11-07T03:36:57Z","receivedAt":"2011-11-07T03:36:57Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Bad copy-paste.\n\nOtherwise the help would be for a different command:\n git remote set-url --help\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n builtin/remote.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex e1285be..2add79a 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -1427,7 +1427,7 @@ static int set_url(int argc, const char **argv)\n \t\t\t    \"delete URLs\"),\n \t\tOPT_END()\n \t};\n-\targc = parse_options(argc, argv, NULL, options, builtin_remote_update_usage,\n+\targc = parse_options(argc, argv, NULL, options, builtin_remote_seturl_usage,\n \t\t\t     PARSE_OPT_KEEP_ARGV0);\n \n \tif (add_mode && delete_mode)\n-- \n1.7.7\n"},{"id":"178998","messageId":"7vk47c4klf.fsf@alter.siamese.dyndns.org","threadId":"28865","inReplyTo":"1320637017-30863-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] remote: fix remote set-url usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-11-07T04:34:04Z","receivedAt":"2011-11-07T04:34:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Good eyes; thanks.\n"},{"id":"178999","messageId":"7vfwi04itx.fsf@alter.siamese.dyndns.org","threadId":"28865","inReplyTo":"1320637017-30863-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] remote: fix remote set-url usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-11-07T05:12:10Z","receivedAt":"2011-11-07T05:12:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> Bad copy-paste.\n>\n> Otherwise the help would be for a different command:\n>  git remote set-url --help\n>\n> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n> ---\n\nDoesn't the same thing apply to set-branches?\n\n builtin/remote.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex c4d17b5..06741ec 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -1336,7 +1336,7 @@ static int set_branches(int argc, const char **argv)\n \t\t\t     builtin_remote_setbranches_usage, 0);\n \tif (argc == 0) {\n \t\terror(\"no remote specified\");\n-\t\tusage_with_options(builtin_remote_seturl_usage, options);\n+\t\tusage_with_options(builtin_remote_setbranches_usage, options);\n \t}\n \targv[argc] = NULL;\n \n"},{"id":"179001","messageId":"7v7h3c4hcn.fsf@alter.siamese.dyndns.org","threadId":"28865","inReplyTo":"7vfwi04itx.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] remote: fix remote set-url usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-11-07T05:44:08Z","receivedAt":"2011-11-07T05:44:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"By the way, these two are low-impact fixes to relatively ancient problems,\nso while it is not urgent enough to include them to the upcoming 1.7.8\n(the users lived with the bug long enough and survived), I do not see much\nproblem to include them in it, either.\n"},{"id":"179018","messageId":"20111107094841.GE30641@elie.hsd1.il.comcast.net","threadId":"28865","inReplyTo":"7vfwi04itx.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] remote: fix remote set-url usage","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-11-07T09:48:41Z","receivedAt":"2011-11-07T09:48:41Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n\n> --- a/builtin/remote.c\n> +++ b/builtin/remote.c\n> @@ -1336,7 +1336,7 @@ static int set_branches(int argc, const char **argv)\n>  \t\t\t     builtin_remote_setbranches_usage, 0);\n>  \tif (argc == 0) {\n>  \t\terror(\"no remote specified\");\n> -\t\tusage_with_options(builtin_remote_seturl_usage, options);\n> +\t\tusage_with_options(builtin_remote_setbranches_usage, options);\n\nGood eyes.  Thanks for catching it.\n"}]}