{"thread":{"id":"28801","subject":"[PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.","startedAt":"2011-10-30T17:18:44Z","lastAt":"2017-10-11T20:02:33Z","messageCount":8,"participants":["Dejan Ribič","Erik Faye-Lund","Pat Thoyts","Takahito Ogawa","Thomas Gummerer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"178531","messageId":"1319995124-7509-1-git-send-email-dejan.ribic@gmail.com","threadId":"28801","inReplyTo":"n","subject":"[PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.","fromName":"Dejan Ribič","fromEmail":"dejan.ribic@gmail.com","sentAt":"2011-10-30T17:18:44Z","receivedAt":"2011-10-30T17:18:44Z","isPatch":true,"sender":{"key":"dejan.ribic@gmail.com","avatar":null},"body":"\"succeded\" changed to \"succeeded\".\n\nReference Launchpad bug #879427.\n\nmodified: git-gui/lib/sshkey.tcl\n\nSigned-off-by: Dejan Ribič \n---\n git-gui/lib/sshkey.tcl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-gui/lib/sshkey.tcl b/git-gui/lib/sshkey.tcl\nindex 5f75bc9..aa6457b 100644\n--- a/git-gui/lib/sshkey.tcl\n+++ b/git-gui/lib/sshkey.tcl\n@@ -117,7 +117,7 @@ proc read_sshkey_output {fd w} {\n \t} else {\n \t\tset finfo [find_ssh_key]\n \t\tif {$finfo eq {}} {\n-\t\t\tset sshkey_title [mc \"Generation succeded, but no keys found.\"]\n+\t\t\tset sshkey_title [mc \"Generation succeeded, but no keys found.\"]\n \t\t\t$w.contents insert end $sshkey_output\n \t\t} else {\n \t\t\tset sshkey_title [mc \"Your key is in: %s\" [lindex $finfo 0]]\n-- \n1.7.5.4\n"},{"id":"178546","messageId":"CABPQNSaLsS9P8hWMEBYVe4FEo5x11+J+pMw29NN+EF2siCO35w@mail.gmail.com","threadId":"28801","inReplyTo":"1319995124-7509-1-git-send-email-dejan.ribic@gmail.com","subject":"Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.","fromName":"Erik Faye-Lund","fromEmail":"kusmabite@gmail.com","sentAt":"2011-10-30T23:57:29Z","receivedAt":"2011-10-30T23:57:29Z","isPatch":true,"sender":{"key":"kusmabite@gmail.com","avatar":"https://avatars.githubusercontent.com/u/47073?v=4"},"body":"Thanks for re-posting inline and with a sign-off. But there's still a\nfew minor nits:\n\n2011/10/30 Dejan Ribič :\n> \"succeded\" changed to \"succeeded\".\n\nWe write commit messages in imperative mood, so this should be\nsomething like 'change \"succeded\" to \"succeeded\"' instead. This is\ndocumented in Documentation/SubmittingPatches.\n\n> modified:   git-gui/lib/sshkey.tcl\n\nWe don't normally include a list of changed files in the commit\nmessage; the diffstat already provides that information.\n"},{"id":"178552","messageId":"87aa8h7d4w.fsf@fox.patthoyts.tk","threadId":"28801","inReplyTo":"CABPQNSaLsS9P8hWMEBYVe4FEo5x11+J+pMw29NN+EF2siCO35w@mail.gmail.com","subject":"Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2011-10-31T08:56:31Z","receivedAt":"2011-10-31T08:56:31Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Erik Faye-Lund writes:\n\n>Thanks for re-posting inline and with a sign-off. But there's still a\n>few minor nits:\n>\n>2011/10/30 Dejan Ribič :\n>> \"succeded\" changed to \"succeeded\".\n>\n>We write commit messages in imperative mood, so this should be\n>something like 'change \"succeded\" to \"succeeded\"' instead. This is\n>documented in Documentation/SubmittingPatches.\n>\n>> modified:   git-gui/lib/sshkey.tcl\n>\n>We don't normally include a list of changed files in the commit\n>message; the diffstat already provides that information.\n>\n\nThe change is fine so I've applied this to the git-gui repository with a\nfixed commit message. Thank you.\n\ngit-gui is hosted separately and merged into git-core at intervals so\nthe development version of git-gui is in fact hosted at \ngit://repo.or.cz/git-gui.git although patches against the git-core\nversion seldom pose a problem to apply and are gratefully received.\n(git am -p2 usually fixes them).\n\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"},{"id":"330190","messageId":"20171011180627.153-1-takahito.ogawa@datagrid.co.jp","threadId":"28801","inReplyTo":"n","subject":"[PATCH 1/1] git-stash.txt: correct \"git stash\" behavior with no arguments","fromName":"Takahito Ogawa","fromEmail":"aiueogawa217@gmail.com","sentAt":"2017-10-11T18:06:27Z","receivedAt":"2017-10-11T18:06:49Z","isPatch":true,"sender":{"key":"aiueogawa217@gmail.com","avatar":null},"body":"\"git stash\" behavior without any arguments was changed in\n1ada5020b (\"stash: use stash_push for no verb form\", 2017-02-28).\nThis is equivalent to \"git stash push\" but document says\n\"git stash save\".\n\nCorrect it.\n\nSigned-off-by: Takahito Ogawa \n---\n Documentation/git-stash.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 00f95fee1..63642c145 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.\n The modifications stashed away by this command can be listed with\n `git stash list`, inspected with `git stash show`, and restored\n (potentially on top of a different commit) with `git stash apply`.\n-Calling `git stash` without any arguments is equivalent to `git stash save`.\n+Calling `git stash` without any arguments is equivalent to `git stash push`.\n A stash is by default listed as \"WIP on 'branchname' ...\", but\n you can give a more descriptive message on the command line when\n you create one.\n-- \n2.13.1\n\n"},{"id":"330196","messageId":"20171011183718.2404-1-aiueogawa217@gmail.com","threadId":"28801","inReplyTo":"n","subject":"[PATCH 1/1] git-stash.txt: correct \"git stash\" behavior with no arguments","fromName":"Takahito Ogawa","fromEmail":"aiueogawa217@gmail.com","sentAt":"2017-10-11T18:37:18Z","receivedAt":"2017-10-11T18:37:42Z","isPatch":true,"sender":{"key":"aiueogawa217@gmail.com","avatar":null},"body":"\"git stash\" behavior without any arguments was changed in\n1ada5020b (\"stash: use stash_push for no verb form\", 2017-02-28).\nThis is equivalent to \"git stash push\" but documents says\n\"git stash save\".\n\nCorrect it.\n\nSigned-off-by: Takahito Ogawa \n---\n Documentation/git-stash.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 00f95fee1..63642c145 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.\n The modifications stashed away by this command can be listed with\n `git stash list`, inspected with `git stash show`, and restored\n (potentially on top of a different commit) with `git stash apply`.\n-Calling `git stash` without any arguments is equivalent to `git stash save`.\n+Calling `git stash` without any arguments is equivalent to `git stash push`.\n A stash is by default listed as \"WIP on 'branchname' ...\", but\n you can give a more descriptive message on the command line when\n you create one.\n-- \n2.13.1\n\n"},{"id":"330199","messageId":"20171011190935.GA15399@hank","threadId":"28801","inReplyTo":"20171011183718.2404-1-aiueogawa217@gmail.com","subject":"Re: [PATCH 1/1] git-stash.txt: correct \"git stash\" behavior with no arguments","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-10-11T19:09:35Z","receivedAt":"2017-10-11T19:08:46Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 10/12, Takahito Ogawa wrote:\n> \"git stash\" behavior without any arguments was changed in\n> 1ada5020b (\"stash: use stash_push for no verb form\", 2017-02-28).\n> This is equivalent to \"git stash push\" but documents says\n> \"git stash save\".\n> \n> Correct it.\n\nThanks for fixing this! I recently sent a patch that would advertise\ngit stash push more in general, which would also fix this occurrence [1], \nbut it didn't seem like it got much interest. However this is\nobviously correct, and should definitely be fixed, while the other\nplaces can still mention 'git stash save'.\n\nFor what it's worth this is\n\nReviewed-by: Thomas Gummerer \n\n\n> Signed-off-by: Takahito Ogawa \n> ---\n> Documentation/git-stash.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\n> index 00f95fee1..63642c145 100644\n> --- a/Documentation/git-stash.txt\n> +++ b/Documentation/git-stash.txt\n> @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.\n> The modifications stashed away by this command can be listed with\n> `git stash list`, inspected with `git stash show`, and restored\n> (potentially on top of a different commit) with `git stash apply`.\n> -Calling `git stash` without any arguments is equivalent to `git stash save`.\n> +Calling `git stash` without any arguments is equivalent to `git stash push`.\n> A stash is by default listed as \"WIP on 'branchname' ...\", but\n> you can give a more descriptive message on the command line when\n> you create one.\n> -- \n> 2.13.1\n> \n"},{"id":"330200","messageId":"20171011191214.GB15399@hank","threadId":"28801","inReplyTo":"20171011190935.GA15399@hank","subject":"Re: [PATCH 1/1] git-stash.txt: correct \"git stash\" behavior with no arguments","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2017-10-11T19:12:14Z","receivedAt":"2017-10-11T19:11:25Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 10/11, Thomas Gummerer wrote:\n> On 10/12, Takahito Ogawa wrote:\n> > \"git stash\" behavior without any arguments was changed in\n> > 1ada5020b (\"stash: use stash_push for no verb form\", 2017-02-28).\n> > This is equivalent to \"git stash push\" but documents says\n> > \"git stash save\".\n> > \n> > Correct it.\n> \n> Thanks for fixing this! I recently sent a patch that would advertise\n> git stash push more in general, which would also fix this occurrence [1], \n> but it didn't seem like it got much interest. However this is\n> obviously correct, and should definitely be fixed, while the other\n> places can still mention 'git stash save'.\n> \n> For what it's worth this is\n> \n> Reviewed-by: Thomas Gummerer \n\nAnd I forgot to include the link, sorry. Here it is:\n\n[1]: https://public-inbox.org/git/20171005200049.GF30301@hank/\n\n> \n> > Signed-off-by: Takahito Ogawa \n> > ---\n> > Documentation/git-stash.txt | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\n> > index 00f95fee1..63642c145 100644\n> > --- a/Documentation/git-stash.txt\n> > +++ b/Documentation/git-stash.txt\n> > @@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.\n> > The modifications stashed away by this command can be listed with\n> > `git stash list`, inspected with `git stash show`, and restored\n> > (potentially on top of a different commit) with `git stash apply`.\n> > -Calling `git stash` without any arguments is equivalent to `git stash save`.\n> > +Calling `git stash` without any arguments is equivalent to `git stash push`.\n> > A stash is by default listed as \"WIP on 'branchname' ...\", but\n> > you can give a more descriptive message on the command line when\n> > you create one.\n> > -- \n> > 2.13.1\n> > \n"},{"id":"330206","messageId":"20171011200147.4377-1-aiueogawa217@gmail.com","threadId":"28801","inReplyTo":"n","subject":"[PATCH 1/1] git-stash.txt: correct \"git stash\" behavior with no arguments","fromName":"Takahito Ogawa","fromEmail":"aiueogawa217@gmail.com","sentAt":"2017-10-11T20:01:47Z","receivedAt":"2017-10-11T20:02:33Z","isPatch":true,"sender":{"key":"aiueogawa217@gmail.com","avatar":null},"body":"\"git stash\" behavior without any arguments was changed in\n1ada5020b (\"stash: use stash_push for no verb form\", 2017-02-28).\nThis is equivalent to \"git stash push\" but documents says\n\"git stash save\".\n\nCorrect it.\n\nReviewed-by: Thomas Gummerer \nSigned-off-by: Takahito Ogawa \n---\n Documentation/git-stash.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 00f95fee1..63642c145 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -33,7 +33,7 @@ and reverts the working directory to match the `HEAD` commit.\n The modifications stashed away by this command can be listed with\n `git stash list`, inspected with `git stash show`, and restored\n (potentially on top of a different commit) with `git stash apply`.\n-Calling `git stash` without any arguments is equivalent to `git stash save`.\n+Calling `git stash` without any arguments is equivalent to `git stash push`.\n A stash is by default listed as \"WIP on 'branchname' ...\", but\n you can give a more descriptive message on the command line when\n you create one.\n-- \n2.13.1\n\n"}]}