{"thread":{"id":"2878","subject":"[PATCH] cg-update quotes too much","startedAt":"2005-12-19T12:19:12Z","lastAt":"2005-12-19T12:19:12Z","messageCount":1,"participants":["Tero Roponen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"13810","messageId":"Pine.GSO.4.58.0512191417180.3752@kanto","threadId":"2878","inReplyTo":null,"subject":"[PATCH] cg-update quotes too much","fromName":"Tero Roponen","fromEmail":"teanropo@cc.jyu.fi","sentAt":"2005-12-19T12:19:12Z","receivedAt":"2005-12-19T12:19:12Z","isPatch":true,"sender":{"key":"teanropo@cc.jyu.fi","avatar":null},"body":"Hi,\n\nIt seems that cogito commit e5ca051c1d3900f7fbc1592d018ab3aab6a9573a\nbroke cg-update, as expected (\"Such a large patch is bound to introduce\nsome (probably mostly trivial) bugs\").\n\nQuoting $force and $squash gives cg-fetch and cg-merge an empty argument\nif they are not set. If they are not quoted they will be omitted if they\nare empty, which is the right thing.\n\nSigned-off-by: Tero Roponen <teanropo@cc.jyu.fi>\n\n---\n\ndiff --git a/cg-update b/cg-update\nindex d586631..1d6e0a0 100755\n--- a/cg-update\n+++ b/cg-update\n@@ -55,10 +55,10 @@ name=\"${ARGS[0]}\"\n [ -s \"$_git/refs/heads/$name\" ] && export _cg_orig_head=\"$(cat \"$_git/refs/heads/$name\")\"\n\n if [ -s \"$_git/branches/$name\" ]; then\n-\tcg-fetch \"$force\" \"$name\" || exit 1\n+\tcg-fetch $force \"$name\" || exit 1\n else\n \techo \"Updating from a local branch.\"\n fi\n echo\n echo \"Applying changes...\"\n-cg-merge \"$squash\" \"$name\"\n+cg-merge $squash \"$name\"\n"}]}