{"thread":{"id":"28774","subject":"[PATCH] Fix 'Cloning into' message","startedAt":"2011-10-26T17:05:48Z","lastAt":"2011-10-27T18:34:36Z","messageCount":4,"participants":["Richard Hartmann","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"178325","messageId":"1319648748-9150-1-git-send-email-richih.mailinglist@gmail.com","threadId":"28774","inReplyTo":null,"subject":"[PATCH] Fix 'Cloning into' message","fromName":"Richard Hartmann","fromEmail":"richih.mailinglist@gmail.com","sentAt":"2011-10-26T17:05:48Z","receivedAt":"2011-10-26T17:05:48Z","isPatch":true,"sender":{"key":"richih.mailinglist@gmail.com","avatar":"https://avatars.githubusercontent.com/u/754723?v=4"},"body":"Without this patch,\n\n    git clone foo .\n\nresults in this:\n\n    Cloning into ....\n    done.\n\nWith it:\n\n    Cloning into '.'...\n    done.\n---\n builtin/clone.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 488f48e..efe8b6c 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \n \tif (0 <= option_verbosity) {\n \t\tif (option_bare)\n-\t\t\tprintf(_(\"Cloning into bare repository %s...\\n\"), dir);\n+\t\t\tprintf(_(\"Cloning into bare repository '%s'...\\n\"), dir);\n \t\telse\n-\t\t\tprintf(_(\"Cloning into %s...\\n\"), dir);\n+\t\t\tprintf(_(\"Cloning into '%s'...\\n\"), dir);\n \t}\n \tinit_db(option_template, INIT_DB_QUIET);\n \twrite_config(&option_config);\n-- \n1.7.7\n"},{"id":"178357","messageId":"1319734013-8956-1-git-send-email-richih.mailinglist@gmail.com","threadId":"28774","inReplyTo":"1319648748-9150-1-git-send-email-richih.mailinglist@gmail.com","subject":"[PATCH] Fix 'Cloning into' message","fromName":"Richard Hartmann","fromEmail":"richih.mailinglist@gmail.com","sentAt":"2011-10-27T16:46:53Z","receivedAt":"2011-10-27T16:46:53Z","isPatch":true,"sender":{"key":"richih.mailinglist@gmail.com","avatar":"https://avatars.githubusercontent.com/u/754723?v=4"},"body":"Without this patch,\n\n    git clone foo .\n\nresults in this:\n\n    Cloning into ....\n    done.\n\nWith it:\n\n    Cloning into '.'...\n    done.\n\nSigned-off-by: Richard Hartmann <richih.mailinglist@gmail.com>\n---\n builtin/clone.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 488f48e..efe8b6c 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -577,9 +577,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \n \tif (0 <= option_verbosity) {\n \t\tif (option_bare)\n-\t\t\tprintf(_(\"Cloning into bare repository %s...\\n\"), dir);\n+\t\t\tprintf(_(\"Cloning into bare repository '%s'...\\n\"), dir);\n \t\telse\n-\t\t\tprintf(_(\"Cloning into %s...\\n\"), dir);\n+\t\t\tprintf(_(\"Cloning into '%s'...\\n\"), dir);\n \t}\n \tinit_db(option_template, INIT_DB_QUIET);\n \twrite_config(&option_config);\n-- \n1.7.7\n"},{"id":"178362","messageId":"7vvcraz64i.fsf@alter.siamese.dyndns.org","threadId":"28774","inReplyTo":"1319734013-8956-1-git-send-email-richih.mailinglist@gmail.com","subject":"Re: [PATCH] Fix 'Cloning into' message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-10-27T17:39:09Z","receivedAt":"2011-10-27T17:39:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Richard Hartmann <richih.mailinglist@gmail.com> writes:\n\n> Without this patch,\n>\n>     git clone foo .\n>\n> results in this:\n>\n>     Cloning into ....\n>     done.\n>\n> With it:\n>\n>     Cloning into '.'...\n>     done.\n>\n> Signed-off-by: Richard Hartmann <richih.mailinglist@gmail.com>\n\nWe try to be consistent and many places do quote user supplied paths in\npair of single quotes in human readable messages, and this is in line with\nthat pattern.\n\n    $ git clone foo \"joey's foo\"\n\nwould result in\n\n    Cloning into 'joey's foo'...\n\nbut that is probably Ok ;-)\n\nThanks.\n"},{"id":"178371","messageId":"CAD77+gQWhatFyo22au-k_ygjohPJ_HhkNvNSgqzX1wRaoiWgBw@mail.gmail.com","threadId":"28774","inReplyTo":"7vvcraz64i.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Fix 'Cloning into' message","fromName":"Richard Hartmann","fromEmail":"richih.mailinglist@gmail.com","sentAt":"2011-10-27T18:34:36Z","receivedAt":"2011-10-27T18:34:36Z","isPatch":true,"sender":{"key":"richih.mailinglist@gmail.com","avatar":"https://avatars.githubusercontent.com/u/754723?v=4"},"body":"On Thu, Oct 27, 2011 at 19:39, Junio C Hamano <gitster@pobox.com> wrote:\n\n\n> We try to be consistent and many places do quote user supplied paths in\n> pair of single quotes in human readable messages, and this is in line with\n> that pattern.\n\nExactly. That is why I chose single quotes. Sorry for not including\nthe signed-off the first time.\n\n\n>    $ git clone foo \"joey's foo\"\n\nIn that case, the user has other problems ;)\n\n\nRichard\n"}]}