{"thread":{"id":"28756","subject":"Possible diff regression in v1.7.6-473-g27af01d","startedAt":"2011-10-24T09:23:47Z","lastAt":"2011-10-24T10:11:02Z","messageCount":3,"participants":["Franz Schrober","Thomas Rast","Tay Ray Chuan"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"178229","messageId":"1319448227.70497.YahooMailNeo@web29402.mail.ird.yahoo.com","threadId":"28756","inReplyTo":null,"subject":"Possible diff regression in v1.7.6-473-g27af01d","fromName":"Franz Schrober","fromEmail":"franzschrober@yahoo.de","sentAt":"2011-10-24T09:23:47Z","receivedAt":"2011-10-24T09:23:47Z","isPatch":false,"sender":{"key":"franzschrober@yahoo.de","avatar":null},"body":"Hi,\n\nI am using git to manage some patches on top of the actual upstream files, but noticed that the result of git-format-patch changed between 4bfe7cb6668c43c1136304bbb17eea1b3ddf0237 and 27af01d552331eacf1ed2671b2b4b6ad4c268106\n\nI've attached two input files (I tried to provide a minimal example... I am not sure if a smaller example is possible but at least both files are smaller than 10 lines) and the results with version 1.7.6.3 and and 1.7.7. The diffs were created using: git diff anonymized_orig anonymized_new\n\nMy .gitconfig file is empty.\n\nThanks"},{"id":"178230","messageId":"201110241138.51448.trast@student.ethz.ch","threadId":"28756","inReplyTo":"1319448227.70497.YahooMailNeo@web29402.mail.ird.yahoo.com","subject":"Re: Possible diff regression in v1.7.6-473-g27af01d","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-10-24T09:38:51Z","receivedAt":"2011-10-24T09:38:51Z","isPatch":false,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Franz Schrober wrote:\n> Hi,\n> \n> I am using git to manage some patches on top of the actual upstream files, but noticed that the result of git-format-patch changed between 4bfe7cb6668c43c1136304bbb17eea1b3ddf0237 and 27af01d552331eacf1ed2671b2b4b6ad4c268106\n> \n> I've attached two input files (I tried to provide a minimal example... I am not sure if a smaller example is possible but at least both files are smaller than 10 lines) and the results with version 1.7.6.3 and and 1.7.7. The diffs were created using: git diff anonymized_orig anonymized_new\n> \n> My .gitconfig file is empty.\n\nI'm not sure why you call this a regression.  For the benefit of\npeople who hate saving attachments, you used\n\n  $ paste anonymized_orig anonymized_new  | xclip\n  0       1\n  0       2\n  0       0\n  0       3\n          4\n          5\n          6\n          7\n\nthe old diff was\n\n  --- a/anonymized_orig\n  +++ b/anonymized_new\n  @@ -1,4 +1,8 @@\n  -0\n  -0\n  -0\n  -0\n  +1\n  +2\n  +0\n  +3\n  +4\n  +5\n  +6\n  +7\n\nand the new diff is\n\n  --- a/anonymized_orig\n  +++ b/anonymized_new\n  @@ -1,4 +1,8 @@\n  +1\n  +2\n   0\n  -0\n  -0\n  -0\n  +3\n  +4\n  +5\n  +6\n  +7\n \nSo the new diff correctly represents the change, and on top of that is\nshorter (by only one line, admittedly).  What makes it a regression?\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"178231","messageId":"CALUzUxoc00DxB75Qu5qz+R9k4_xHx13RJGwwX8vJpbet1jf0Aw@mail.gmail.com","threadId":"28756","inReplyTo":"201110241138.51448.trast@student.ethz.ch","subject":"Re: Possible diff regression in v1.7.6-473-g27af01d","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2011-10-24T10:11:02Z","receivedAt":"2011-10-24T10:11:02Z","isPatch":false,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"On Mon, Oct 24, 2011 at 5:38 PM, Thomas Rast <trast@student.ethz.ch> wrote:\n>\n> I'm not sure why you call this a regression.  For the benefit of\n> people who hate saving attachments, you used\n>\n>  $ paste anonymized_orig anonymized_new  | xclip\n>  0       1\n>  0       2\n>  0       0\n>  0       3\n>          4\n>          5\n>          6\n>          7\n>\n> the old diff was\n>\n>  --- a/anonymized_orig\n>  +++ b/anonymized_new\n>  @@ -1,4 +1,8 @@\n>  -0\n>  -0\n>  -0\n>  -0\n>  +1\n>  +2\n>  +0\n>  +3\n>  +4\n>  +5\n>  +6\n>  +7\n>\n> and the new diff is\n>\n>  --- a/anonymized_orig\n>  +++ b/anonymized_new\n>  @@ -1,4 +1,8 @@\n>  +1\n>  +2\n>   0\n>  -0\n>  -0\n>  -0\n>  +3\n>  +4\n>  +5\n>  +6\n>  +7\n>\n> So the new diff correctly represents the change, and on top of that is\n> shorter (by only one line, admittedly).  What makes it a regression?\n\nThanks for inlining it, Thomas.\n\n> Franz Schrober wrote:>> Hi,>>>> I am using git to manage some patches on top of the actual upstream files, but noticed that the result of git-format-patch changed between 4bfe7cb6668c43c1136304bbb17eea1b3ddf0237 and 27af01d552331eacf1ed2671b2b4b6ad4c268106>>>> I've attached two input files (I tried to provide a minimal example... I am not sure if a smaller example is possible but at least both files are smaller than 10 lines) and the results with version 1.7.6.3 and and 1.7.7. The diffs were created using: git diff anonymized_orig anonymized_new>>>> My .gitconfig file is empty.\nThis has been \"fixed\" in v1.7.7.1, with 713b85c (Merge branch\n'rs/diff-cleanup-records-fix' into maint) - \"fixed\" in that it gives\nback the old behaviour, not that the diff produced is incorrect and\nneeds fixing.\n(I'm running 1.7.7.1.599.g03eec, I get the same diff as diff.1.7.6.3)\n\n-- \nCheers,\nRay Chuan\n"}]}