{"thread":{"id":"28693","subject":"Higher-level change review?","startedAt":"2011-10-16T14:31:51Z","lastAt":"2011-10-16T18:03:25Z","messageCount":3,"participants":["Dave Abrahams","Tay Ray Chuan","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"177780","messageId":"m27h450zzc.fsf@pluto.luannocracy.com","threadId":"28693","inReplyTo":null,"subject":"Higher-level change review?","fromName":"Dave Abrahams","fromEmail":"dave-xt6nqnoqrpdwk0htik3j/w@public.gmane.org","sentAt":"2011-10-16T14:31:51Z","receivedAt":"2011-10-16T14:31:51Z","isPatch":false,"sender":{"key":"dave-xt6nqnoqrpdwk0htik3j/w@public.gmane.org","avatar":null},"body":"\nI've been working on a fairly large Org outline and also merging\nupstream code changes in a project that does a lot of refactoring, and\nI've discovered that Git's diff format is poorly-suited to reviewing the\nkinds of structural modifications I often deal with, where indentation\nchanges and large parts of documents are reorganized.  Are there better\nways to review, stage, etc. this kind of change than by using\nstraight-ahead diffs?  And, for the magit list, has anyone integrated\nan improved review capability with magit?\n\nHints most appreciated,\n\n-- \nDave Abrahams\nBoostPro Computing\nhttp://www.boostpro.com\n"},{"id":"177791","messageId":"CALUzUxpr4FhjJ8OpYcpZOJLZuvveBNzKWd7soY6LQrz0Do1TDg@mail.gmail.com","threadId":"28693","inReplyTo":"m27h450zzc.fsf-NtBv8x4kbP9fRAUK6RR3EeqUGfbH9hYC@public.gmane.org","subject":"Re: Higher-level change review?","fromName":"Tay Ray Chuan","fromEmail":"rctay89-re5jqeeqqe8avxtiumwx3w@public.gmane.org","sentAt":"2011-10-16T15:05:33Z","receivedAt":"2011-10-16T15:05:33Z","isPatch":false,"sender":{"key":"rctay89-re5jqeeqqe8avxtiumwx3w@public.gmane.org","avatar":null},"body":"On Sun, Oct 16, 2011 at 10:31 PM, Dave Abrahams <dave-xT6NqnoQrPdWk0Htik3J/w@public.gmane.org> wrote:\n> I've discovered that Git's diff format is poorly-suited to reviewing the\n> kinds of structural modifications I often deal with, where indentation\n> changes and large parts of documents are reorganized.\n\nSomething off the top of my head:\n\n  git (diff|show) -w\n\n?\n\n-- \nCheers,\nRay Chuan\n"},{"id":"177797","messageId":"m3hb387r2l.fsf@localhost.localdomain","threadId":"28693","inReplyTo":"CALUzUxpr4FhjJ8OpYcpZOJLZuvveBNzKWd7soY6LQrz0Do1TDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org","subject":"Re: Higher-level change review?","fromName":"Jakub Narebski","fromEmail":"jnareb-re5jqeeqqe8avxtiumwx3w@public.gmane.org","sentAt":"2011-10-16T18:03:25Z","receivedAt":"2011-10-16T18:03:25Z","isPatch":false,"sender":{"key":"jnareb-re5jqeeqqe8avxtiumwx3w@public.gmane.org","avatar":null},"body":"[Sending via email, not via GMane; sorry if you got duplications]\n\nTay Ray Chuan writes:\n> On Sun, Oct 16, 2011 at 10:31 PM, Dave Abrahams wrote:\n> >\n> > I've discovered that Git's diff format is poorly-suited to reviewing the\n> > kinds of structural modifications I often deal with, where indentation\n> > changes and large parts of documents are reorganized.\n> \n> Something off the top of my head:\n> \n>   git (diff|show) -w\n\nWhile -w, --ignore-all-space (and its lesser variant -b, --ignore-space-change)\nare nice and good, they cannot deal with code movement.\n\nI have saved somewhere a shell script involving \"git blame -w -C -C HEAD^..\"\nplus some filtering to see what changed beside reordering... but I seem to\nhave it misplaced.\n\nFound it:\n\nFrom: Junio C Hamano <gitster-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>\nhttp://permalink.gmane.org/gmane.comp.version-control.git/174966\nhttp://thread.gmane.org/gmane.comp.version-control.git/174954/focus=174966\nJH>\nJH> \"git blame\" tip of the day. After applying a series like this on a topic\nJH> branch, running\nJH>\nJH>   $ git blame -C master.. -- gitweb/INSTALL | grep -C 3 -e '^[^^]' | less -S\nJH>\nJH> lets us view the lines without drowning in the bulk of lines that were\nJH> merely moved.\n\nHTH\n-- \nJakub Narębski\n"}]}