{"thread":{"id":"28679","subject":"[BUG] remote-curl.c: honor pushurl","startedAt":"2011-10-14T15:37:40Z","lastAt":"2011-10-14T15:48:53Z","messageCount":2,"participants":["Michael Schubert","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"177653","messageId":"4E985744.6050904@elegosoft.com","threadId":"28679","inReplyTo":null,"subject":"[BUG] remote-curl.c: honor pushurl","fromName":"Michael Schubert","fromEmail":"mschub@elegosoft.com","sentAt":"2011-10-14T15:37:40Z","receivedAt":"2011-10-14T15:37:40Z","isPatch":false,"sender":{"key":"mschub@elegosoft.com","avatar":null},"body":"When doing a push (fetch, ..) over http(s), git calls git-remote-http to\ncommunicate with the server.\n\n\tgit-remote-http <remote> [<url>]\n\nGit correctly honors a configured pushurl and passes it to git-remote-http,\nbut git-remote-http is initiating the http connection with the url defined\nfor remote (remote->url) rather than the passed url. This undermines the\npurpose of a config like\n\n\turl = https://example.com/repo.git\n\tpushurl = https://user@example.com/repo.git\n\nIntroduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was\nworking before, though.)\n"},{"id":"177654","messageId":"20111014154853.GA10722@sigill.intra.peff.net","threadId":"28679","inReplyTo":"4E985744.6050904@elegosoft.com","subject":"Re: [BUG] remote-curl.c: honor pushurl","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-10-14T15:48:53Z","receivedAt":"2011-10-14T15:48:53Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Oct 14, 2011 at 05:37:40PM +0200, Michael Schubert wrote:\n\n> When doing a push (fetch, ..) over http(s), git calls git-remote-http to\n> communicate with the server.\n> \n> \tgit-remote-http <remote> [<url>]\n> \n> Git correctly honors a configured pushurl and passes it to git-remote-http,\n> but git-remote-http is initiating the http connection with the url defined\n> for remote (remote->url) rather than the passed url. This undermines the\n> purpose of a config like\n> \n> \turl = https://example.com/repo.git\n> \tpushurl = https://user@example.com/repo.git\n> \n> Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was\n> working before, though.)\n\nAlready noticed and fixed last week.\n\nSee this thread, starting at the focused message.\n\n  http://thread.gmane.org/gmane.comp.version-control.git/182752/focus=182872\n\n-Peff\n"}]}