{"thread":{"id":"28588","subject":"[PATCHv3 5/5] Add test showing git-fetch groks gitfiles","startedAt":"2011-10-05T13:35:45Z","lastAt":"2011-10-06T03:13:42Z","messageCount":2,"participants":["Phil Hord","Nguyen Thai Ngoc Duy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"176921","messageId":"4E8C5D31.2000406@cisco.com","threadId":"28588","inReplyTo":null,"subject":"[PATCHv3 5/5] Add test showing git-fetch groks gitfiles","fromName":"Phil Hord","fromEmail":"hordp@cisco.com","sentAt":"2011-10-05T13:35:45Z","receivedAt":"2011-10-05T13:35:45Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"Add a test for two subtly different cases: 'git fetch path/.git'\nand 'git fetch path' to confirm that transport recognizes both\npaths as git repositories when using the gitfile mechanism.\n\nSigned-off-by: Phil Hord <hordp@cisco.com>\n\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex e810314..87ee016 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -206,6 +206,20 @@ test_expect_success 'clone from .git file' '\n \tgit clone dst/.git dst2\n '\n \n+test_expect_success 'fetch from .git gitfile' '\n+\t(\n+\t\tcd dst2 &&\n+\t\tgit fetch ../dst/.git\n+\t)\n+'\n+\n+test_expect_success 'fetch from gitfile parent' '\n+\t(\n+\t\tcd dst2 &&\n+\t\tgit fetch ../dst\n+\t)\n+'\n+\n test_expect_success 'clone separate gitdir where target already exists' '\n \trm -rf dst &&\n \ttest_must_fail git clone --separate-git-dir realgitdir src dst\n-- \n1.7.7.505.ga09f6\n"},{"id":"176998","messageId":"CACsJy8ANRyqpsuCu+Nir4ux18E-U9Evwa07Eosi1REROo1U_og@mail.gmail.com","threadId":"28588","inReplyTo":"4E8C5D31.2000406@cisco.com","subject":"Re: [PATCHv3 5/5] Add test showing git-fetch groks gitfiles","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2011-10-06T03:13:42Z","receivedAt":"2011-10-06T03:13:42Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Thu, Oct 6, 2011 at 12:35 AM, Phil Hord <hordp@cisco.com> wrote:\n> Add a test for two subtly different cases: 'git fetch path/.git'\n> and 'git fetch path' to confirm that transport recognizes both\n> paths as git repositories when using the gitfile mechanism.\n\nIt'd be interesting to test failed cases too. I can think of two: .git\nfile is not a valid file and .git points to an invalid repo.\n-- \nDuy\n"}]}