{"thread":{"id":"28538","subject":"[PATCH] gitk: Show patch for initial commit","startedAt":"2011-09-30T21:50:21Z","lastAt":"2011-10-01T20:20:44Z","messageCount":4,"participants":["Marcus Karlsson","Zbigniew Jędrzejewski-Szmek","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"176598","messageId":"20110930215021.GA3005@kennedy.acc.umu.se","threadId":"28538","inReplyTo":null,"subject":"[PATCH] gitk: Show patch for initial commit","fromName":"Marcus Karlsson","fromEmail":"mk@acc.umu.se","sentAt":"2011-09-30T21:50:21Z","receivedAt":"2011-09-30T21:50:21Z","isPatch":true,"sender":{"key":"mk@acc.umu.se","avatar":null},"body":"Make gitk show the patch for the initial commit.\n\nSigned-off-by: Marcus Karlsson <mk@acc.umu.se>\n---\n gitk-git/gitk |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 4cde0c4..20aeae6 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {\n \t    lappend cmd HEAD\n \t}\n     } else {\n-\tset cmd [concat | git diff-tree -r $flags $ids]\n+\tset cmd [concat | git diff-tree -r --root $flags $ids]\n     }\n     return $cmd\n }\n-- \n1.7.7.rc3.4.g8d714\n"},{"id":"176629","messageId":"4E86E343.5070704@in.waw.pl","threadId":"28538","inReplyTo":"20110930215021.GA3005@kennedy.acc.umu.se","subject":"Re: [PATCH] gitk: Show patch for initial commit","fromName":"Zbigniew Jędrzejewski-Szmek","fromEmail":"zbyszek@in.waw.pl","sentAt":"2011-10-01T09:54:11Z","receivedAt":"2011-10-01T09:54:11Z","isPatch":true,"sender":{"key":"zbyszek@in.waw.pl","avatar":"https://avatars.githubusercontent.com/u/349618?v=4"},"body":"On 09/30/2011 11:50 PM, Marcus Karlsson wrote:\n> Make gitk show the patch for the initial commit.\n>\n> Signed-off-by: Marcus Karlsson<mk@acc.umu.se>\n> ---\n>   gitk-git/gitk |    2 +-\n>   1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/gitk-git/gitk b/gitk-git/gitk\n> index 4cde0c4..20aeae6 100755\n> --- a/gitk-git/gitk\n> +++ b/gitk-git/gitk\n> @@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {\n>   \t    lappend cmd HEAD\n>   \t}\n>       } else {\n> -\tset cmd [concat | git diff-tree -r $flags $ids]\n> +\tset cmd [concat | git diff-tree -r --root $flags $ids]\n>       }\n>       return $cmd\n>   }\nCool, this works for me! But I think I would be really nice if gitk \nrespected the configuration value of log.showroot. This would give nice \nconsistency amongst the various tools.\n\nZbyszek\n"},{"id":"176651","messageId":"20111001184216.GA5796@kennedy.acc.umu.se","threadId":"28538","inReplyTo":"4E86E343.5070704@in.waw.pl","subject":"Re: [PATCH] gitk: Show patch for initial commit","fromName":"Marcus Karlsson","fromEmail":"mk@acc.umu.se","sentAt":"2011-10-01T18:42:16Z","receivedAt":"2011-10-01T18:42:16Z","isPatch":true,"sender":{"key":"mk@acc.umu.se","avatar":null},"body":"On Sat, Oct 01, 2011 at 11:54:11AM +0200, Zbigniew J??drzejewski-Szmek wrote:\n> On 09/30/2011 11:50 PM, Marcus Karlsson wrote:\n> >Make gitk show the patch for the initial commit.\n> >\n> >Signed-off-by: Marcus Karlsson<mk@acc.umu.se>\n> >---\n> >  gitk-git/gitk |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> >\n> >diff --git a/gitk-git/gitk b/gitk-git/gitk\n> >index 4cde0c4..20aeae6 100755\n> >--- a/gitk-git/gitk\n> >+++ b/gitk-git/gitk\n> >@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {\n> >  \t    lappend cmd HEAD\n> >  \t}\n> >      } else {\n> >-\tset cmd [concat | git diff-tree -r $flags $ids]\n> >+\tset cmd [concat | git diff-tree -r --root $flags $ids]\n> >      }\n> >      return $cmd\n> >  }\n> Cool, this works for me! But I think I would be really nice if gitk\n> respected the configuration value of log.showroot. This would give\n> nice consistency amongst the various tools.\n\nI agree, that would be reasonable. I'll prepare a new patch with that\nbehavior.\n\nMarcus\n"},{"id":"176656","messageId":"7vaa9kmpk3.fsf@alter.siamese.dyndns.org","threadId":"28538","inReplyTo":"20111001184216.GA5796@kennedy.acc.umu.se","subject":"Re: [PATCH] gitk: Show patch for initial commit","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-10-01T20:20:44Z","receivedAt":"2011-10-01T20:20:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marcus Karlsson <mk@acc.umu.se> writes:\n\n>> >diff --git a/gitk-git/gitk b/gitk-git/gitk\n>> >index 4cde0c4..20aeae6 100755\n>> >--- a/gitk-git/gitk\n>> >+++ b/gitk-git/gitk\n>> >@@ -7436,7 +7436,7 @@ proc diffcmd {ids flags} {\n>> >  \t    lappend cmd HEAD\n>> >  \t}\n>> >      } else {\n>> >-\tset cmd [concat | git diff-tree -r $flags $ids]\n>> >+\tset cmd [concat | git diff-tree -r --root $flags $ids]\n>> >      }\n>> >      return $cmd\n>> >  }\n>> Cool, this works for me! But I think I would be really nice if gitk\n>> respected the configuration value of log.showroot. This would give\n>> nice consistency amongst the various tools.\n>\n> I agree, that would be reasonable. I'll prepare a new patch with that\n> behavior.\n\nThat would be good, but whatever you do please keep the maintainer of\ngitk, Paul Mackerras <paulus@samba.org>, in the loop.\n"}]}