{"thread":{"id":"28471","subject":"[BUG] git-p4 can't cope with dollars in filenames","startedAt":"2011-09-23T19:38:59Z","lastAt":"2011-09-23T19:38:59Z","messageCount":1,"participants":["Luke Diamand"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"176093","messageId":"4E7CE053.2020309@diamand.org","threadId":"28471","inReplyTo":null,"subject":"[BUG] git-p4 can't cope with dollars in filenames","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2011-09-23T19:38:59Z","receivedAt":"2011-09-23T19:38:59Z","isPatch":false,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"Hi!\n\nIf you have a dollar in a filename and attempt to submit it to Perforce \nvia git-p4 it fails.\n\ne.g. this sequence:\n\n% touch foo\\$bar.c\n% git commit -m 'whatever' foo\\$bar.c\n% git-p4 submit\n\n....\n....\nSubmit aborted -- fix problems then use 'p4 submit -c 3'.\n\nThe problem is all the places that use the git-p4 read_pipe() function, \nwhich is a wrapper around os.popen(). popen() does shell expansion which \ndoes hilarious things to files with dollars in their name.\n\nYou can have hours of fun and entertainment with this. Adding a file \ncalled foo\\`fortune\\`.h is especially amusing.\n\nI'm going to try to come up with a fix for this.\n\nLuke\n"}]}