{"thread":{"id":"28262","subject":"[PATCH] stash: Don't paginate by default with list command","startedAt":"2011-08-30T17:21:18Z","lastAt":"2011-08-31T18:18:13Z","messageCount":8,"participants":["Ingo Brückl","Ben Walton","Raphael Zimmerer","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174563","messageId":"4e5d1e5c.438d9c87.bm000@wupperonline.de","threadId":"28262","inReplyTo":null,"subject":"[PATCH] stash: Don't paginate by default with list command","fromName":"Ingo Brückl","fromEmail":"ib@wupperonline.de","sentAt":"2011-08-30T17:21:18Z","receivedAt":"2011-08-30T17:21:18Z","isPatch":true,"sender":{"key":"ib@wupperonline.de","avatar":"https://avatars.githubusercontent.com/u/123327?v=4"},"body":"The output of \"stash list\" is such that piping into a pager\nnormally isn't necessary but annoying, so disable it by default.\n\nSigned-off-by: Ingo Brückl <ib@wupperonline.de>\n---\n git-stash.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 31dec0a..b92d986 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -264,7 +264,7 @@ have_stash () {\n\n list_stash () {\n \thave_stash || return 0\n-\tgit log --format=\"%gd: %gs\" -g \"$@\" $ref_stash --\n+\tgit --no-pager log --format=\"%gd: %gs\" -g \"$@\" $ref_stash --\n }\n\n show_stash () {\n--\n1.7.6\n"},{"id":"174566","messageId":"1314726104-sup-5174@pinkfloyd.chass.utoronto.ca","threadId":"28262","inReplyTo":"4e5d1e5c.438d9c87.bm000@wupperonline.de","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Ben Walton","fromEmail":"bwalton@artsci.utoronto.ca","sentAt":"2011-08-30T17:43:46Z","receivedAt":"2011-08-30T17:43:46Z","isPatch":true,"sender":{"key":"bdwalton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/396061?v=4"},"body":"Excerpts from Ingo Brückl's message of Tue Aug 30 13:21:18 -0400 2011:\n\n> The output of \"stash list\" is such that piping into a pager\n> normally isn't necessary but annoying, so disable it by default.\n\nIf you $PAGER is less and you use the default LESS environment value\nFRXS, this shouldn't be annoying at all.  Are you using either a\ndifferent pager or a different value for LESS?\n\nThanks\n-Ben\n--\nBen Walton\nSystems Programmer - CHASS\nUniversity of Toronto\nC:416.407.5610 | W:416.978.4302\n"},{"id":"174570","messageId":"20110830175748.GA19715@rdrz.de","threadId":"28262","inReplyTo":"4e5d1e5c.438d9c87.bm000@wupperonline.de","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Raphael Zimmerer","fromEmail":"killekulla@rdrz.de","sentAt":"2011-08-30T17:57:48Z","receivedAt":"2011-08-30T17:57:48Z","isPatch":true,"sender":{"key":"killekulla@rdrz.de","avatar":"https://avatars.githubusercontent.com/u/35472983?v=4"},"body":"On Tue, Aug 30, 2011 at 07:21:18PM +0200, Ingo Brückl wrote:\n> The output of \"stash list\" is such that piping into a pager\n> normally isn't necessary but annoying, so disable it by default.\n\nWhy is the current behaviour annoying?\n\nHere on my (default) setup the pager automatically exits if the entire\noutput can be displayed on the screen, as with any other git\ncommand. Is there any chance you have set the LESS environment\nvariable somewhere? To disable the pager for some commands, cou can\nhave a look at the *.pager config variables (man git-confg). However,\n'pager.stash' is not recognized... The 'alias.*' config variables may\nbe interesting, too.\n\nRaphael\n"},{"id":"174572","messageId":"4e5d2ac6.64676448.bm000@wupperonline.de","threadId":"28262","inReplyTo":"1314726104-sup-5174@pinkfloyd.chass.utoronto.ca","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Ingo Brückl","fromEmail":"ib@wupperonline.de","sentAt":"2011-08-30T18:24:04Z","receivedAt":"2011-08-30T18:24:04Z","isPatch":true,"sender":{"key":"ib@wupperonline.de","avatar":"https://avatars.githubusercontent.com/u/123327?v=4"},"body":"Ben Walton wrote on Tue, 30 Aug 2011 13:43:46 -0400:\n\n> Excerpts from Ingo Brückl's message of Tue Aug 30 13:21:18 -0400 2011:\n\n>> The output of \"stash list\" is such that piping into a pager\n>> normally isn't necessary but annoying, so disable it by default.\n\n> If you $PAGER is less and you use the default LESS environment value\n> FRXS, this shouldn't be annoying at all.  Are you using either a\n> different pager or a different value for LESS?\n\nFor some reason I have '-c' in LESS which must be convenient for a case\nI currently don't remember.\n\nIngo\n"},{"id":"174576","messageId":"20110830190818.GB19715@rdrz.de","threadId":"28262","inReplyTo":"4e5d2ac6.64676448.bm000@wupperonline.de","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Raphael Zimmerer","fromEmail":"killekulla@rdrz.de","sentAt":"2011-08-30T19:08:18Z","receivedAt":"2011-08-30T19:08:18Z","isPatch":true,"sender":{"key":"killekulla@rdrz.de","avatar":"https://avatars.githubusercontent.com/u/35472983?v=4"},"body":"On Tue, Aug 30, 2011 at 08:24:04PM +0200, Ingo Brückl wrote:\n> Ben Walton wrote on Tue, 30 Aug 2011 13:43:46 -0400:\n> \n> > Excerpts from Ingo Brückl's message of Tue Aug 30 13:21:18 -0400 2011:\n> \n> >> The output of \"stash list\" is such that piping into a pager\n> >> normally isn't necessary but annoying, so disable it by default.\n> \n> > If you $PAGER is less and you use the default LESS environment value\n> > FRXS, this shouldn't be annoying at all.  Are you using either a\n> > different pager or a different value for LESS?\n> \n> For some reason I have '-c' in LESS which must be convenient for a case\n> I currently don't remember.\n\nWhen you don't require the '-c' option for paging in git, please try\n'core.pager = less -FRXS'. That forces git's default behaviour\nregardless of the LESS environment variable.\n\nRaphael\n"},{"id":"174578","messageId":"7vk49u1z1n.fsf@alter.siamese.dyndns.org","threadId":"28262","inReplyTo":"20110830175748.GA19715@rdrz.de","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-08-30T19:26:12Z","receivedAt":"2011-08-30T19:26:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Raphael Zimmerer <killekulla@rdrz.de> writes:\n\n> On Tue, Aug 30, 2011 at 07:21:18PM +0200, Ingo Brückl wrote:\n>> The output of \"stash list\" is such that piping into a pager\n>> normally isn't necessary but annoying, so disable it by default.\n>\n> Why is the current behaviour annoying?\n>\n> Here on my (default) setup the pager automatically exits if the entire\n> output can be displayed on the screen, as with any other git\n> command.\n\nBen Walton pointed out exactly the same thing, but there needs one bit of\ncaution/consideration. If you tend to use longer and more descriptive\nbranch name (which is encouraged) and create a lazy stash without giving\nany message, the default description of the stash would need a fairly wide\nterminal window to fit on one line, e.g.\n\n    \"stash@{N}: WIP on some-long-ish-branch-name:\" followed by\n    \"09997df a one line description of the commit your changes are made on\"\n\nconcatenated on the same line. \"S\" in \"FRSX\" (the default value of \"LESS\"\nenvironment variable we give to those who do not have any) is a good thing\nto have while reviewing long-ish patches via \"git log -p\", but having a\nlong line that \"S\" causes to be chopped counts as not being able to show\nthe entire file on the first screen for the purpose of \"F\", and introduces\na minor irritation of having to exit explicitly with a 'q'.\n"},{"id":"174581","messageId":"20110830201918.GC19715@rdrz.de","threadId":"28262","inReplyTo":"7vk49u1z1n.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Raphael Zimmerer","fromEmail":"killekulla@rdrz.de","sentAt":"2011-08-30T20:19:18Z","receivedAt":"2011-08-30T20:19:18Z","isPatch":true,"sender":{"key":"killekulla@rdrz.de","avatar":"https://avatars.githubusercontent.com/u/35472983?v=4"},"body":"On Tue, Aug 30, 2011 at 12:26:12PM -0700, Junio C Hamano wrote:\n[...]\n> to have while reviewing long-ish patches via \"git log -p\", but having a\n> long line that \"S\" causes to be chopped counts as not being able to show\n> the entire file on the first screen for the purpose of \"F\", and introduces\n> a minor irritation of having to exit explicitly with a 'q'.\n\nYes, you are right. That can be annoying. Same issue when showing the\nreflog, but as it has lots of entries, the automatic pager is really\nhandy. I seldom use 'stash clear' (stash is a nice way for storing\nworking copy history somewhere...), so I don't like to miss the\npager in stash list. Maybe 'pager.stash.list' as mentioned before is\nthe way to go.\n\nBut as Ingo has set the LESS environment variable to some value\n('-c'), he always has to press 'q', what may be his problem (beside of\nthe annoyance that his less now displays '~' on each empty line).\n\nRaphael\n"},{"id":"174639","messageId":"4e5e7b19.1b946de8.bm000@wupperonline.de","threadId":"28262","inReplyTo":"4e5d2ac6.64676448.bm000@wupperonline.de","subject":"Re: [PATCH] stash: Don't paginate by default with list command","fromName":"Ingo Brückl","fromEmail":"ib@wupperonline.de","sentAt":"2011-08-31T18:18:13Z","receivedAt":"2011-08-31T18:18:13Z","isPatch":true,"sender":{"key":"ib@wupperonline.de","avatar":"https://avatars.githubusercontent.com/u/123327?v=4"},"body":"I wrote on Tue, 30 Aug 2011 20:24:04 +0200:\n\n> Ben Walton wrote on Tue, 30 Aug 2011 13:43:46 -0400:\n\n>> Excerpts from Ingo Brückl's message of Tue Aug 30 13:21:18 -0400 2011:\n\n>>> The output of \"stash list\" is such that piping into a pager\n>>> normally isn't necessary but annoying, so disable it by default.\n\n>> If you $PAGER is less and you use the default LESS environment value\n>> FRXS, this shouldn't be annoying at all.  Are you using either a\n>> different pager or a different value for LESS?\n\n> For some reason I have '-c' in LESS which must be convenient for a case\n> I currently don't remember.\n\nNow I know again. '-c' is within my LESS because I like small \"git diff\"\noutput printed on an erased terminal. I think it is easier to overview that\nway.\n\nWith \"git stash list\" I'd like it the other way, because that output is\njust a simple list (and usually very small in my case).\n\nIngo\n"}]}