{"thread":{"id":"28256","subject":"[PATCH] Documentation: point to \"History Simplification\" from -- ","startedAt":"2011-08-29T23:18:19Z","lastAt":"2011-08-30T18:03:38Z","messageCount":4,"participants":["Thomas Rast","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174522","messageId":"307fe311ad448ecd3d0643040008954a217d7ddb.1314659821.git.trast@student.ethz.ch","threadId":"28256","inReplyTo":null,"subject":"[PATCH] Documentation: point to \"History Simplification\" from -- ","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-08-29T23:18:19Z","receivedAt":"2011-08-29T23:18:19Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"'git log -- ' does not \"show commits that affect the specified\npaths\" in a literal sense unless --full-history is given (for example,\na file that only existed on a side branch will turn up no commits at\nall!).\n\nPoint the user to the \"History Simplification\" section to avoid\nsurprises.\n\nSigned-off-by: Thomas Rast \n---\n\nSparked by an IRC discussion minutes ago, where I got the paragraph\nquoted back to me verbatim to \"prove\" it shows *all* commits affecting\na file.\n\n\n Documentation/git-log.txt | 10 ++++++----\n 1 files changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 6c93466..437f06e 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -69,10 +69,12 @@ produced by --stat etc.\n \tits size is not included.\n \n [\\--] ...::\n-\tShow only commits that affect any of the specified paths. To\n-\tprevent confusion with options and branch names, paths may need\n-\tto be prefixed with \"\\-- \" to separate them from options or\n-\trefnames.\n+\tShow only commits that affect any of the specified paths.\n+\tSee \"History Simplification\" below for a precise definition of\n+\tthe filtering applied.\n++\n+To prevent confusion with options and branch names, paths may need to\n+be prefixed with \"\\-- \" to separate them from options or refnames.\n \n include::rev-list-options.txt[]\n \n-- \n1.7.7.rc0.370.gdcae57\n"},{"id":"174524","messageId":"7vbov74w25.fsf@alter.siamese.dyndns.org","threadId":"28256","inReplyTo":"307fe311ad448ecd3d0643040008954a217d7ddb.1314659821.git.trast@student.ethz.ch","subject":"Re: [PATCH] Documentation: point to \"History Simplification\" from -- ","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-08-29T23:50:10Z","receivedAt":"2011-08-29T23:50:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> 'git log -- ' does not \"show commits that affect the specified\n> paths\" in a literal sense unless --full-history is given (for example,\n> a file that only existed on a side branch will turn up no commits at\n> all!).\n>\n> Point the user to the \"History Simplification\" section to avoid\n> surprises.\n\nHmm, or perhaps replace it with a brief explanation instead of redirecting\nthe readers to a separate section without telling them anything here?\n\n Show only commits that are enough to explain how the files that match\n the specified paths came to be.\n\n(this is my attempt to paraphrase $gmane/90659)\n\n> [\\--] ...::\n> +\tShow only commits that affect any of the specified paths.\n> +\tSee \"History Simplification\" below for a precise definition of\n> +\tthe filtering applied.\n"},{"id":"174541","messageId":"73058a4801ea2707f5ffa12150682ee0522385eb.1314695984.git.trast@student.ethz.ch","threadId":"28256","inReplyTo":"7vbov74w25.fsf@alter.siamese.dyndns.org","subject":"[PATCH v2] Documentation: clarify effects of -- arguments","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2011-08-30T09:21:07Z","receivedAt":"2011-08-30T09:21:07Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"'git log -- ' does not \"show commits that affect the specified\npaths\" in a literal sense unless --full-history is given (for example,\na file that only existed on a side branch will turn up no commits at\nall!).\n\nReword it to specify the actual intent of the filtering, and point to\nthe \"History Simplification\" section.\n\nThe first new sentence was suggested by Junio.\n\nSigned-off-by: Thomas Rast \n---\n\nJunio C Hamano wrote:\n> Thomas Rast writes:\n> \n> > 'git log -- ' does not \"show commits that affect the specified\n> > paths\" in a literal sense unless --full-history is given (for example,\n> > a file that only existed on a side branch will turn up no commits at\n> > all!).\n> >\n> > Point the user to the \"History Simplification\" section to avoid\n> > surprises.\n> \n> Hmm, or perhaps replace it with a brief explanation instead of redirecting\n> the readers to a separate section without telling them anything here?\n> \n> Show only commits that are enough to explain how the files that match\n> the specified paths came to be.\n> \n> (this is my attempt to paraphrase $gmane/90659)\n\nOr both? I really like your version; I tried to come up with a\nconcise wording and couldn't. But the user may still want to read\nabout it in detail.\n\n\n Documentation/git-log.txt | 11 +++++++----\n 1 files changed, 7 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-log.txt b/Documentation/git-log.txt\nindex 6c93466..249fc87 100644\n--- a/Documentation/git-log.txt\n+++ b/Documentation/git-log.txt\n@@ -69,10 +69,13 @@ produced by --stat etc.\n \tits size is not included.\n \n [\\--] ...::\n-\tShow only commits that affect any of the specified paths. To\n-\tprevent confusion with options and branch names, paths may need\n-\tto be prefixed with \"\\-- \" to separate them from options or\n-\trefnames.\n+\tShow only commits that are enough to explain how the files\n+\tthat match the specified paths came to be. See \"History\n+\tSimplification\" below for details and other simplification\n+\tmodes.\n++\n+To prevent confusion with options and branch names, paths may need to\n+be prefixed with \"\\-- \" to separate them from options or refnames.\n \n include::rev-list-options.txt[]\n \n-- \n1.7.7.rc0.370.gdcae57\n"},{"id":"174568","messageId":"7vvcte22v9.fsf@alter.siamese.dyndns.org","threadId":"28256","inReplyTo":"73058a4801ea2707f5ffa12150682ee0522385eb.1314695984.git.trast@student.ethz.ch","subject":"Re: [PATCH v2] Documentation: clarify effects of -- arguments","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-08-30T18:03:38Z","receivedAt":"2011-08-30T18:03:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> Or both?\n\nCertainly; I didn't mean to reject the \"see also\". It just didn't look\nright not to update the original sentence that seemed to have caused\nconfusion to new people.\n\nApplied.\n"}]}