{"thread":{"id":"2825","subject":"git cole give unexpected error message","startedAt":"2005-12-13T21:28:20Z","lastAt":"2005-12-14T21:20:03Z","messageCount":5,"participants":["Sam Ravnborg","Petr Baudis","Andreas Ericsson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"13579","messageId":"20051213212820.GB5232@mars.ravnborg.org","threadId":"2825","inReplyTo":null,"subject":"git cole give unexpected error message","fromName":"Sam Ravnborg","fromEmail":"sam@ravnborg.org","sentAt":"2005-12-13T21:28:20Z","receivedAt":"2005-12-13T21:28:20Z","isPatch":false,"sender":{"key":"sam@ravnborg.org","avatar":"https://gravatar.com/avatar/168a912606ed0742d840bb365e3cc21db390c36531a58341dc7a069cc1f15f62?d=mp&s=160"},"body":"Encountered following minor issue today:\n\nExecuted:\nsam@mars ~/work $ git clone git://git.kernel.org/pub/scm/lib/klibc/klibc.git viggo\ndefaulting to local storage area\nfatal: unexpected EOF\n\nThe errormessage \"fatal: unexpected EOF\" did not immediately tell me\nthat the requested git repository did not exists.\n\nBut I corrected the path and tried again:\nsam@mars ~/work $ git clone git://git.kernel.org/pub/scm/libs/klibc/klibc.git viggo\nviggo already exists.\n\nSo one can see that git did not clean up after the faulty clone.\n\nIt would be nice if git:\n1) Displayed a more meaningfull error message\n2) Cleaned up so I did not have to do a manual rm -rf viggo\n\n\ncogito being a nice porcelain gives the git errormessage but manage to\nclean up when the clone fails.\nSo also cogito would benefit from a more descriptive errormessage.\n\n\tSam\n"},{"id":"13582","messageId":"20051213222829.GE22159@pasky.or.cz","threadId":"2825","inReplyTo":"20051213212820.GB5232@mars.ravnborg.org","subject":"Re: git cole give unexpected error message","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-12-13T22:28:29Z","receivedAt":"2005-12-13T22:28:29Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter\nwhere Sam Ravnborg said that...\n> cogito being a nice porcelain gives the git errormessage but manage to\n> clean up when the clone fails.\n> So also cogito would benefit from a more descriptive errormessage.\n\nWell, git clone can fail for many reasons and I don't think the \"no such\nrepository\" one is completely overwhelming, so hinting that by Cogito\ncould be quite confusing (theme of the day: usability ;-)).\n\nThe real solution would be proper error reporting by the git daemon.\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"},{"id":"13613","messageId":"439FE7AD.6080602@op5.se","threadId":"2825","inReplyTo":"20051213222829.GE22159@pasky.or.cz","subject":"Re: git cole give unexpected error message","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2005-12-14T09:36:45Z","receivedAt":"2005-12-14T09:36:45Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Petr Baudis wrote:\n> Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter\n> where Sam Ravnborg said that...\n> \n>>cogito being a nice porcelain gives the git errormessage but manage to\n>>clean up when the clone fails.\n>>So also cogito would benefit from a more descriptive errormessage.\n> \n> \n> Well, git clone can fail for many reasons and I don't think the \"no such\n> repository\" one is completely overwhelming, so hinting that by Cogito\n> could be quite confusing (theme of the day: usability ;-)).\n> \n> The real solution would be proper error reporting by the git daemon.\n> \n\nBut that would open up for an information disclosure. If someone's \nhacking on a patch, please make it configurable at least.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"13616","messageId":"20051214114156.GG22159@pasky.or.cz","threadId":"2825","inReplyTo":"439FE7AD.6080602@op5.se","subject":"Re: git cole give unexpected error message","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-12-14T11:41:56Z","receivedAt":"2005-12-14T11:41:56Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Wed, Dec 14, 2005 at 10:36:45AM CET, I got a letter\nwhere Andreas Ericsson said that...\n> Petr Baudis wrote:\n> >Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter\n> >where Sam Ravnborg said that...\n> >\n> >>cogito being a nice porcelain gives the git errormessage but manage to\n> >>clean up when the clone fails.\n> >>So also cogito would benefit from a more descriptive errormessage.\n> >\n> >\n> >Well, git clone can fail for many reasons and I don't think the \"no such\n> >repository\" one is completely overwhelming, so hinting that by Cogito\n> >could be quite confusing (theme of the day: usability ;-)).\n> >\n> >The real solution would be proper error reporting by the git daemon.\n> >\n> \n> But that would open up for an information disclosure. If someone's \n> hacking on a patch, please make it configurable at least.\n\nWhen it breaks at this stage, it's either some bad internal error (I\nguess memory allocation error might do this), permission problem, or\nrepository not being found. We might then report a more generic error\nmessage \"Repository not found or access denied.\".\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"},{"id":"13632","messageId":"20051214212003.GA17495@mars.ravnborg.org","threadId":"2825","inReplyTo":"20051213222829.GE22159@pasky.or.cz","subject":"Re: git cole give unexpected error message","fromName":"Sam Ravnborg","fromEmail":"sam@ravnborg.org","sentAt":"2005-12-14T21:20:03Z","receivedAt":"2005-12-14T21:20:03Z","isPatch":false,"sender":{"key":"sam@ravnborg.org","avatar":"https://gravatar.com/avatar/168a912606ed0742d840bb365e3cc21db390c36531a58341dc7a069cc1f15f62?d=mp&s=160"},"body":"On Tue, Dec 13, 2005 at 11:28:29PM +0100, Petr Baudis wrote:\n> Dear diary, on Tue, Dec 13, 2005 at 10:28:20PM CET, I got a letter\n> where Sam Ravnborg said that...\n> > cogito being a nice porcelain gives the git errormessage but manage to\n> > clean up when the clone fails.\n> > So also cogito would benefit from a more descriptive errormessage.\n> \n> Well, git clone can fail for many reasons and I don't think the \"no such\n> repository\" one is completely overwhelming, so hinting that by Cogito\n> could be quite confusing (theme of the day: usability ;-)).\n> \n> The real solution would be proper error reporting by the git daemon.\nWhich was my point too.\nWhen using cogito it displyed the git error message so having git to\nprint a sensible error message would also benefit cogito.\n\n\tSam\n"}]}