{"thread":{"id":"28247","subject":"[PATCH] am: format is in $patch_format, not parse_patch","startedAt":"2011-08-29T15:22:06Z","lastAt":"2011-08-29T16:46:42Z","messageCount":3,"participants":["Giuseppe Bilotta","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174458","messageId":"1314631326-11796-1-git-send-email-giuseppe.bilotta@gmail.com","threadId":"28247","inReplyTo":null,"subject":"[PATCH] am: format is in $patch_format, not parse_patch","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2011-08-29T15:22:06Z","receivedAt":"2011-08-29T15:22:06Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"The error message given when the patch format was not recognized was\nwrong, since the variable checked was $parse_patch rather than\n$patch_format. Fix by checking the non-emptyness of the correct\nvariable.\n\nSigned-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>\n---\n git-am.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-am.sh b/git-am.sh\nindex e78cb54..4fff195 100755\n--- a/git-am.sh\n+++ b/git-am.sh\n@@ -312,7 +312,7 @@ split_patches ()\n \t\tmsgnum=\n \t\t;;\n \t*)\n-\t\tif test -n \"$parse_patch\" ; then\n+\t\tif test -n \"$patch_format\" ; then\n \t\t\tclean_abort \"$(eval_gettext \"Patch format \\$patch_format is not supported.\")\"\n \t\telse\n \t\t\tclean_abort \"$(gettext \"Patch format detection failed.\")\"\n-- \n1.7.7.rc0.328.g626f7.dirty\n"},{"id":"174461","messageId":"7vaaas6vtt.fsf@alter.siamese.dyndns.org","threadId":"28247","inReplyTo":"1314631326-11796-1-git-send-email-giuseppe.bilotta@gmail.com","subject":"Re: [PATCH] am: format is in $patch_format, not parse_patch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-08-29T16:12:14Z","receivedAt":"2011-08-29T16:12:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:\n\n> The error message given when the patch format was not recognized was\n> wrong, since the variable checked was $parse_patch rather than\n> $patch_format. Fix by checking the non-emptyness of the correct\n> variable.\n\nThanks for a fix to a problem that is from more than two years ago ;-)\n"},{"id":"174465","messageId":"CAOxFTcwcBgCNpwNNdsQXwE92w6948cfjwMTum03D+SJ0Rq-Yuw@mail.gmail.com","threadId":"28247","inReplyTo":"7vaaas6vtt.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] am: format is in $patch_format, not parse_patch","fromName":"Giuseppe Bilotta","fromEmail":"giuseppe.bilotta@gmail.com","sentAt":"2011-08-29T16:46:42Z","receivedAt":"2011-08-29T16:46:42Z","isPatch":true,"sender":{"key":"giuseppe.bilotta@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1464?v=4"},"body":"On Mon, Aug 29, 2011 at 6:12 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:\n>\n>> The error message given when the patch format was not recognized was\n>> wrong, since the variable checked was $parse_patch rather than\n>> $patch_format. Fix by checking the non-emptyness of the correct\n>> variable.\n>\n> Thanks for a fix to a problem that is from more than two years ago ;-)\n\nYou're welcome. I'm actually surprised that wasn't something _I_ did\nby mistake ;-)\n\nThat part of the code isn't being stressed too much. I've just found\nanother issue. Patch coming, plus another enhancement.\n\n-- \nGiuseppe \"Oblomov\" Bilotta\n"}]}