{"thread":{"id":"28240","subject":"[PATCH] t3005: do not assume a particular order of stdout and stderr of git-ls-files","startedAt":"2011-08-28T07:34:56Z","lastAt":"2011-08-28T07:34:56Z","messageCount":1,"participants":["Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"174408","messageId":"4E59EFA0.7020209@kdbg.org","threadId":"28240","inReplyTo":null,"subject":"[PATCH] t3005: do not assume a particular order of stdout and stderr of git-ls-files","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2011-08-28T07:34:56Z","receivedAt":"2011-08-28T07:34:56Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"There is no guarantee that stderr is flushed before stdout when both\nchannels are redirected to a file. Check the channels using independent\nfiles.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n t/t3005-ls-files-relative.sh |   22 ++++++++++++----------\n 1 files changed, 12 insertions(+), 10 deletions(-)\n\ndiff --git a/t/t3005-ls-files-relative.sh b/t/t3005-ls-files-relative.sh\nindex a2b63e2..3778694 100755\n--- a/t/t3005-ls-files-relative.sh\n+++ b/t/t3005-ls-files-relative.sh\n@@ -45,11 +45,12 @@ test_expect_success 'ls-files -c' '\n \t\tfor f in ../y*\n \t\tdo\n \t\t\techo \"error: pathspec $sq$f$sq did not match any file(s) known to git.\"\n-\t\tdone >expect &&\n-\t\techo \"Did you forget to ${sq}git add${sq}?\" >>expect &&\n-\t\tls ../x* >>expect &&\n-\t\ttest_must_fail git ls-files -c --error-unmatch ../[xy]* >actual 2>&1 &&\n-\t\ttest_cmp expect actual\n+\t\tdone >expect.err &&\n+\t\techo \"Did you forget to ${sq}git add${sq}?\" >>expect.err &&\n+\t\tls ../x* >expect.out &&\n+\t\ttest_must_fail git ls-files -c --error-unmatch ../[xy]* >actual.out 2>actual.err &&\n+\t\ttest_cmp expect.out actual.out &&\n+\t\ttest_cmp expect.err actual.err\n \t)\n '\n \n@@ -59,11 +60,12 @@ test_expect_success 'ls-files -o' '\n \t\tfor f in ../x*\n \t\tdo\n \t\t\techo \"error: pathspec $sq$f$sq did not match any file(s) known to git.\"\n-\t\tdone >expect &&\n-\t\techo \"Did you forget to ${sq}git add${sq}?\" >>expect &&\n-\t\tls ../y* >>expect &&\n-\t\ttest_must_fail git ls-files -o --error-unmatch ../[xy]* >actual 2>&1 &&\n-\t\ttest_cmp expect actual\n+\t\tdone >expect.err &&\n+\t\techo \"Did you forget to ${sq}git add${sq}?\" >>expect.err &&\n+\t\tls ../y* >expect.out &&\n+\t\ttest_must_fail git ls-files -o --error-unmatch ../[xy]* >actual.out 2>actual.err &&\n+\t\ttest_cmp expect.out actual.out &&\n+\t\ttest_cmp expect.err actual.err\n \t)\n '\n \n-- \n1.7.7.rc0.92.g0cd2b\n"}]}