{"thread":{"id":"28137","subject":"Issue: Mails sent twice if patch is mentioned twice while sending mail.","startedAt":"2011-08-17T06:11:41Z","lastAt":"2011-08-17T09:58:49Z","messageCount":4,"participants":["viresh kumar","Ramkumar Ramachandra","vireshk","Matthieu Moy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"173663","messageId":"4E4B5B9D.1070901@st.com","threadId":"28137","inReplyTo":null,"subject":"Issue: Mails sent twice if patch is mentioned twice while sending mail.","fromName":"viresh kumar","fromEmail":"viresh.kumar@st.com","sentAt":"2011-08-17T06:11:41Z","receivedAt":"2011-08-17T06:11:41Z","isPatch":false,"sender":{"key":"viresh.kumar@st.com","avatar":null},"body":"Hello,\n\nI found something which look wrong to me, but may not be wrong.\nSuppose if we do:\n\ngit send-email --to=abc@xyz.com 0001-xyz.patch 0001-xyz.patch\n\nWhat should be the desired behavior of this command, Should we get\nmail only once or twice?\n\nCurrently we are getting it twice.\n\n-- \nviresh\n"},{"id":"173665","messageId":"CALkWK0nv=NrCzxfePL50GiJya+DbqdOmSMjPVEa-Sf1Qm5oAvg@mail.gmail.com","threadId":"28137","inReplyTo":"4E4B5B9D.1070901@st.com","subject":"Re: Issue: Mails sent twice if patch is mentioned twice while sending mail.","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2011-08-17T08:52:09Z","receivedAt":"2011-08-17T08:52:09Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Hi Viresh,\n\nViresh kumar writes:\n> git send-email --to=abc@xyz.com 0001-xyz.patch 0001-xyz.patch\n>\n> What should be the desired behavior of this command, Should we get\n> mail only once or twice?\n\nI'd expect it to send out two emails.  Why should 'git send-email'\ncheck the supplied command-line arguments for duplicates?  I can't\nthink of a usecase for it. It's a simple Perl script that mails out\nthe mbox files specified on the command-line.  Could you tell us your\nusecase?  If it's a shell script that calls 'git send-email' with\nduplicate arguments, I think you should fix the shell script, not 'git\nsend-email'.\n\nThanks.\n\n-- Ram\n"},{"id":"173667","messageId":"4E4B86F1.2010802@st.com","threadId":"28137","inReplyTo":"CALkWK0nv=NrCzxfePL50GiJya+DbqdOmSMjPVEa-Sf1Qm5oAvg@mail.gmail.com","subject":"Re: Issue: Mails sent twice if patch is mentioned twice while sending mail.","fromName":"vireshk","fromEmail":"viresh.kumar@st.com","sentAt":"2011-08-17T09:16:33Z","receivedAt":"2011-08-17T09:16:33Z","isPatch":false,"sender":{"key":"viresh.kumar@st.com","avatar":null},"body":"On 8/17/2011 2:22 PM, Ramkumar Ramachandra wrote:\n> Viresh kumar writes:\n>> git send-email --to=abc@xyz.com 0001-xyz.patch 0001-xyz.patch\n>>\n>> What should be the desired behavior of this command, Should we get\n>> mail only once or twice?\n> \n> I'd expect it to send out two emails.  Why should 'git send-email'\n> check the supplied command-line arguments for duplicates?  I can't\n> think of a usecase for it. It's a simple Perl script that mails out\n> the mbox files specified on the command-line.  Could you tell us your\n> usecase?  If it's a shell script that calls 'git send-email' with\n> duplicate arguments, I think you should fix the shell script, not 'git\n> send-email'.\n> \n\nHi Ram,\n\nActually i did this by mistake once and thought git send-email should\nhave taken care of this. I may be wrong, but it was just an thought.\n\n--\nviresh\n"},{"id":"173668","messageId":"vpq62lwjr52.fsf@bauges.imag.fr","threadId":"28137","inReplyTo":"4E4B86F1.2010802@st.com","subject":"Re: Issue: Mails sent twice if patch is mentioned twice while sending mail.","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2011-08-17T09:58:49Z","receivedAt":"2011-08-17T09:58:49Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"vireshk <viresh.kumar@st.com> writes:\n\n> Hi Ram,\n>\n> Actually i did this by mistake once and thought git send-email should\n> have taken care of this. I may be wrong, but it was just an thought.\n\ngit send-email could probably issue a warning if the same patch is\nmentionned twice, but I don't think it's sane to try to silently\nautocorrect user's mistake.\n\nIf users get used to \"git send-email 1.patch 1.patch\" sending the email\nonly once, then what should be the expected behavior of\n\n  git send-email 1.patch ./1.patch\n\n  git send-email 1.patch symlink-to-1.patch\n\n?\n\nThe nice thing with a warning is that you can't really blame the tool\nfor not issuing a warning, while it can be harmfull to have an\nautocorrection fail in a real user-senario.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}