{"thread":{"id":"28040","subject":"Suppressing auto-cc for specific addresses","startedAt":"2011-08-07T20:20:26Z","lastAt":"2011-08-09T07:40:28Z","messageCount":12,"participants":["Daniel Mack","Greg KH","Jeff King","Jonathan Nieder","Joe Perches"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"173103","messageId":"4E3EF38A.9010307@gmail.com","threadId":"28040","inReplyTo":null,"subject":"Suppressing auto-cc for specific addresses","fromName":"Daniel Mack","fromEmail":"zonque@gmail.com","sentAt":"2011-08-07T20:20:26Z","receivedAt":"2011-08-07T20:20:26Z","isPatch":false,"sender":{"key":"zonque@gmail.com","avatar":"https://gravatar.com/avatar/5ce636e56617f3619ba2b2f69b10e698c08f724f18dfd1708b55b4e85df40800?d=mp&s=160"},"body":"Hi,\n\nI'm looking for a way to suppress certain Cc: fields that are normally \nautomatically added for addresses mentioned in Cc: lines found in patches.\n\nIn particular, the kernel rules for marking patches for stable release \ninclusion wants users to add a \"Cc: stable@kernel.org\" line in the patch \nitself but to not actually send a copy of that patch to that address. It \nwill be picked automatically once the patch was applied upstream.\n\nI couldn't find a proper way to do that with git send-email, so I dare \nto come up with a patch proposal. Is that acceptable or is there any \nbetter way (which I'm not aware about) to achive this?\n\n\n\nThanks,\nDaniel\n\n\nFrom f1a17a4fbc0373283696cb560afff3afa05c2e8f Mon Sep 17 00:00:00 2001\nFrom: Daniel Mack \nDate: Sun, 7 Aug 2011 22:16:00 +0200\nSubject: [PATCH] send-email: Allow email addresses and domains as\n --suppress-cc options\n\nSigned-off-by: Daniel Mack \n---\n Documentation/git-send-email.txt | 10 +++++++---\n git-send-email.perl | 12 +++++++++++-\n 2 files changed, 18 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 327233c..5966abb 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -233,9 +233,9 @@ Automating\n \tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n \tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n---suppress-cc=::\n-\tSpecify an additional category of recipients to suppress the\n-\tauto-cc of:\n+--suppress-cc=::\n+\tSpecify an additional category, email address or domain of recipients\n+\tto suppress the auto-cc for. Possible categories are:\n +\n --\n - 'author' will avoid including the patch author\n@@ -251,6 +251,10 @@ Automating\n - 'all' will suppress all auto cc values.\n --\n +\n+If a full email address is given, auto-cc will be suppressed for this particular\n+address. This also works for entire domains if the parameter starts with the '@'\n+sign. All email addresses in that domain will hence be ignored by auto-cc.\n++\n Default is the value of 'sendemail.suppresscc' configuration value; if\n that is unspecified, default to 'self' if --suppress-from is\n specified, as well as 'body' if --no-signed-off-cc is specified.\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 98ab33a..22813e5 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -374,7 +374,7 @@ my(%suppress_cc);\n if (@suppress_cc) {\n \tforeach my $entry (@suppress_cc) {\n \t\tdie \"Unknown --suppress-cc field: '$entry'\\n\"\n-\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/;\n+\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|.*@.*)$/;\n \t\t$suppress_cc{$entry} = 1;\n \t}\n }\n@@ -1213,6 +1213,11 @@ foreach my $t (@files) {\n \t\t\t\t\t} else {\n \t\t\t\t\t\tnext if ($suppress_cc{'cc'});\n \t\t\t\t\t}\n+\t\t\t\t\tnext if ($suppress_cc{$addr});\n+\t\t\t\t\tif ($addr =~ /^(.+)(@.+)$/) {\n+\t\t\t\t\t\tmy $domain = $2;\n+\t\t\t\t\t\tnext if $suppress_cc{$domain};\n+\t\t\t\t\t}\n \t\t\t\t\tprintf(\"(mbox) Adding cc: %s from line '%s'\\n\",\n \t\t\t\t\t\t$addr, $_) unless $quiet;\n \t\t\t\t\tpush @cc, $addr;\n@@ -1261,6 +1266,11 @@ foreach my $t (@files) {\n \t\t\t\tnext if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;\n \t\t\t\tnext if $suppress_cc{'bodycc'} and $what =~ /Cc/i;\n \t\t\t}\n+\t\t\tnext if ($suppress_cc{$c});\n+\t\t\tif ($c =~ /^(.+)(@.+)$/) {\n+\t\t\t\tmy $domain = $2;\n+\t\t\t\tnext if $suppress_cc{$domain};\n+\t\t\t}\n \t\t\tpush @cc, $c;\n \t\t\tprintf(\"(body) Adding cc: %s from line '%s'\\n\",\n \t\t\t\t$c, $_) unless $quiet;\n-- \n1.7.6\n\n"},{"id":"173106","messageId":"20110807234634.GA3236@kroah.com","threadId":"28040","inReplyTo":"4E3EF38A.9010307@gmail.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Greg KH","fromEmail":"greg@kroah.com","sentAt":"2011-08-07T23:46:34Z","receivedAt":"2011-08-07T23:46:34Z","isPatch":false,"sender":{"key":"greg@kroah.com","avatar":"https://gravatar.com/avatar/5bb5aa0cc2e01c00ec899d11130c07796bc186e465bae57bc34873b13b72c7c8?d=mp&s=160"},"body":"On Sun, Aug 07, 2011 at 10:20:26PM +0200, Daniel Mack wrote:\n> Hi,\n> \n> I'm looking for a way to suppress certain Cc: fields that are\n> normally automatically added for addresses mentioned in Cc: lines\n> found in patches.\n> \n> In particular, the kernel rules for marking patches for stable\n> release inclusion wants users to add a \"Cc: stable@kernel.org\" line\n> in the patch itself but to not actually send a copy of that patch to\n> that address. It will be picked automatically once the patch was\n> applied upstream.\n\nThere is no \"rule\" that says you can not send a copy of the patch to\nstable@kernel.org, in fact that happens a lot and is fine and I have no\nproblem with that at all.\n\nSo please don't feel that you have to do anything different here with\ngit to properly follow the stable kernel rules, there should not be any\nneed.\n\nthanks,\n\ngreg k-h\n"},{"id":"173120","messageId":"CACTFLAOhApGVNZ7JsWhoHBEaQ_87stXjxkXvadmauNfhSuPD1g@mail.gmail.com","threadId":"28040","inReplyTo":"20110807234634.GA3236@kroah.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Daniel Mack","fromEmail":"zonque@gmail.com","sentAt":"2011-08-08T07:24:02Z","receivedAt":"2011-08-08T07:24:02Z","isPatch":false,"sender":{"key":"zonque@gmail.com","avatar":"https://gravatar.com/avatar/5ce636e56617f3619ba2b2f69b10e698c08f724f18dfd1708b55b4e85df40800?d=mp&s=160"},"body":"On Mon, Aug 8, 2011 at 1:46 AM, Greg KH wrote:\n> On Sun, Aug 07, 2011 at 10:20:26PM +0200, Daniel Mack wrote:\n>> I'm looking for a way to suppress certain Cc: fields that are\n>> normally automatically added for addresses mentioned in Cc: lines\n>> found in patches.\n>>\n>> In particular, the kernel rules for marking patches for stable\n>> release inclusion wants users to add a \"Cc: stable@kernel.org\" line\n>> in the patch itself but to not actually send a copy of that patch to\n>> that address. It will be picked automatically once the patch was\n>> applied upstream.\n>\n> There is no \"rule\" that says you can not send a copy of the patch to\n> stable@kernel.org, in fact that happens a lot and is fine and I have no\n> problem with that at all.\n\nOk, thanks for explaining. In fact, I've done it that way ever since,\nand never thought that there is any problem with it. But the topic\ncame up lately on the ALSA ML (and was continued off-list later), and\nreading Documentation/stable_kernel_rules.txt again, I became aware of\nthe fact that sending it to stable@ is not actually necessary (while\nat the same time, it doesn't seem to be frowned upon).\n\nAnyway, I found it strange not have a way in git to achive this, and\nmaybe this new feature has other uses, too?\n\n\nThanks,\nDaniel\n"},{"id":"173131","messageId":"CACTFLAN0gM-xvEU32KHEsaApH4apvGUwGkiDHx06PngHUvH0Ew@mail.gmail.com","threadId":"28040","inReplyTo":"D95ADFD4-2504-4BE6-BCD4-7B916F6F2FEB@gmail.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Daniel Mack","fromEmail":"zonque@gmail.com","sentAt":"2011-08-08T10:58:55Z","receivedAt":"2011-08-08T10:58:55Z","isPatch":false,"sender":{"key":"zonque@gmail.com","avatar":"https://gravatar.com/avatar/5ce636e56617f3619ba2b2f69b10e698c08f724f18dfd1708b55b4e85df40800?d=mp&s=160"},"body":"On Mon, Aug 8, 2011 at 12:56 PM, David Aguilar wrote:\n> git send-email has a --[no-]signed-off-by-cc option and configuration\n> variable. --\n\nI know, but that's not the point. It about having a certain address\nmetioned in a ^Cc: line inside the patch and suppress sending off\nemails to that specific address. And --suppress-cc currently only\nallows categories to be set, not addresses.\n\n\nDaniel\n"},{"id":"173156","messageId":"20110808204448.GF18294@sigill.intra.peff.net","threadId":"28040","inReplyTo":"CACTFLAN0gM-xvEU32KHEsaApH4apvGUwGkiDHx06PngHUvH0Ew@mail.gmail.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-08-08T20:44:48Z","receivedAt":"2011-08-08T20:44:48Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Aug 08, 2011 at 12:58:55PM +0200, Daniel Mack wrote:\n\n> On Mon, Aug 8, 2011 at 12:56 PM, David Aguilar wrote:\n> > git send-email has a --[no-]signed-off-by-cc option and configuration\n> > variable. --\n> \n> I know, but that's not the point. It about having a certain address\n> metioned in a ^Cc: line inside the patch and suppress sending off\n> emails to that specific address. And --suppress-cc currently only\n> allows categories to be set, not addresses.\n\nI'm kind of confused why you would mark an address as \"cc\", but not cc\nit. Wouldn't it make sense to call the header something else?\n\n-Peff\n"},{"id":"173159","messageId":"CACTFLAN1oXHtEtoo7kzvTqaiSv0zvmbkPU703iZsztCWdg4HhQ@mail.gmail.com","threadId":"28040","inReplyTo":"20110808204448.GF18294@sigill.intra.peff.net","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Daniel Mack","fromEmail":"zonque@gmail.com","sentAt":"2011-08-08T21:01:12Z","receivedAt":"2011-08-08T21:01:12Z","isPatch":false,"sender":{"key":"zonque@gmail.com","avatar":"https://gravatar.com/avatar/5ce636e56617f3619ba2b2f69b10e698c08f724f18dfd1708b55b4e85df40800?d=mp&s=160"},"body":"On Mon, Aug 8, 2011 at 10:44 PM, Jeff King wrote:\n> On Mon, Aug 08, 2011 at 12:58:55PM +0200, Daniel Mack wrote:\n>\n>> On Mon, Aug 8, 2011 at 12:56 PM, David Aguilar wrote:\n>> > git send-email has a --[no-]signed-off-by-cc option and configuration\n>> > variable. --\n>>\n>> I know, but that's not the point. It about having a certain address\n>> metioned in a ^Cc: line inside the patch and suppress sending off\n>> emails to that specific address. And --suppress-cc currently only\n>> allows categories to be set, not addresses.\n>\n> I'm kind of confused why you would mark an address as \"cc\", but not cc\n> it. Wouldn't it make sense to call the header something else?\n\nValid point. Even though Greg doesn't have a problem with the current\nprocedure as it stands, I see a problem in marking things for \"Cc:\nstable@kernel.org\" just as a search pattern once they hit the Linux\nmainline tree. Particularily because as it will end up in the\nrecipient list with git send-email, stable@ will get all the\nfollow-ups and discussions when people blindly hit the Reply-to-all\nbutton (which we tell them to do). I for one would add\nstable@kernel.org to my .gitconfig and be done with it, without ever\nthinking about it again.\n\nIt's really not a big thing, and we can drop this patch if anyone has\nreal objections, but as it doesn't break anything for existing use\ncases and might help others, why not apply it?\n\n\nDaniel\n"},{"id":"173161","messageId":"20110808210714.GA16512@elie.gateway.2wire.net","threadId":"28040","inReplyTo":"20110808204448.GF18294@sigill.intra.peff.net","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-08-08T21:07:14Z","receivedAt":"2011-08-08T21:07:14Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jeff King wrote:\n\n> I'm kind of confused why you would mark an address as \"cc\", but not cc\n> it. Wouldn't it make sense to call the header something else?\n\nMaybe the patch is a draft and he is seeking early feedback. The\nfinal version will be cc-ed to the indicated person later (and that's\npart of what it is time to get feedback on).\n\nOr maybe the Cc: line is from the original patch and he is using git\nsend-email to forward it without mangling.\n"},{"id":"173162","messageId":"20110808211102.GA3233@kroah.com","threadId":"28040","inReplyTo":"CACTFLAN1oXHtEtoo7kzvTqaiSv0zvmbkPU703iZsztCWdg4HhQ@mail.gmail.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Greg KH","fromEmail":"greg@kroah.com","sentAt":"2011-08-08T21:11:02Z","receivedAt":"2011-08-08T21:11:02Z","isPatch":false,"sender":{"key":"greg@kroah.com","avatar":"https://gravatar.com/avatar/5bb5aa0cc2e01c00ec899d11130c07796bc186e465bae57bc34873b13b72c7c8?d=mp&s=160"},"body":"On Mon, Aug 08, 2011 at 11:01:12PM +0200, Daniel Mack wrote:\n> On Mon, Aug 8, 2011 at 10:44 PM, Jeff King wrote:\n> > On Mon, Aug 08, 2011 at 12:58:55PM +0200, Daniel Mack wrote:\n> >\n> >> On Mon, Aug 8, 2011 at 12:56 PM, David Aguilar wrote:\n> >> > git send-email has a --[no-]signed-off-by-cc option and configuration\n> >> > variable. --\n> >>\n> >> I know, but that's not the point. It about having a certain address\n> >> metioned in a ^Cc: line inside the patch and suppress sending off\n> >> emails to that specific address. And --suppress-cc currently only\n> >> allows categories to be set, not addresses.\n> >\n> > I'm kind of confused why you would mark an address as \"cc\", but not cc\n> > it. Wouldn't it make sense to call the header something else?\n> \n> Valid point. Even though Greg doesn't have a problem with the current\n> procedure as it stands, I see a problem in marking things for \"Cc:\n> stable@kernel.org\" just as a search pattern once they hit the Linux\n> mainline tree. Particularily because as it will end up in the\n> recipient list with git send-email, stable@ will get all the\n> follow-ups and discussions when people blindly hit the Reply-to-all\n> button (which we tell them to do). I for one would add\n> stable@kernel.org to my .gitconfig and be done with it, without ever\n> thinking about it again.\n\nNo, that's a good thing, as the stable tree maintainer, I _want_ to see\nthat discussion to verify that this patch really is something that\nshould be applied to a stable kernel tree.\n\nLots of patches have originally been tagged in this manner, added to the\ngit tree, yet in discussion threads afterward, it's been determined that\nthis should not go to the stable tree. If I hadn't been on that thread\nin the first place, I would have missed that.\n\nSo again, I have no objection to cc: stable@kernel.org, and in fact,\nencourage it. Don't worry, I can handle the email load :)\n\nthanks,\n\ngreg k-h\n"},{"id":"173164","messageId":"20110808211726.GA18619@elie.gateway.2wire.net","threadId":"28040","inReplyTo":"4E3EF38A.9010307@gmail.com","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-08-08T21:17:26Z","receivedAt":"2011-08-08T21:17:26Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"(+cc: some send-email people)\nHi,\n\nDaniel Mack wrote:\n\n> I'm looking for a way to suppress certain Cc: fields that are normally\n> automatically added for addresses mentioned in Cc: lines found in patches.\n\nMakes sense. Could you please add a quick commit message, following\nthe guidelines in Documentation/SubmittingPatches (i.e., explaining\nthe problem this intends to solve and justifying how it is solved)?\n\nPatch left untrimmed for Joe and Ævar's convenience. Thanks and hope\nthat helps.\n\n> From: Daniel Mack \n> Date: Sun, 7 Aug 2011 22:16:00 +0200\n> Subject: [PATCH] send-email: Allow email addresses and domains as\n> --suppress-cc options\n> \n> Signed-off-by: Daniel Mack \n> ---\n> Documentation/git-send-email.txt | 10 +++++++---\n> git-send-email.perl | 12 +++++++++++-\n> 2 files changed, 18 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 327233c..5966abb 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -233,9 +233,9 @@ Automating\n> \tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n> \tvalue; if that is unspecified, default to --signed-off-by-cc.\n> \n> ---suppress-cc=::\n> -\tSpecify an additional category of recipients to suppress the\n> -\tauto-cc of:\n> +--suppress-cc=::\n> +\tSpecify an additional category, email address or domain of recipients\n> +\tto suppress the auto-cc for. Possible categories are:\n> +\n> --\n> - 'author' will avoid including the patch author\n> @@ -251,6 +251,10 @@ Automating\n> - 'all' will suppress all auto cc values.\n> --\n> +\n> +If a full email address is given, auto-cc will be suppressed for this particular\n> +address. This also works for entire domains if the parameter starts with the '@'\n> +sign. All email addresses in that domain will hence be ignored by auto-cc.\n> ++\n> Default is the value of 'sendemail.suppresscc' configuration value; if\n> that is unspecified, default to 'self' if --suppress-from is\n> specified, as well as 'body' if --no-signed-off-cc is specified.\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 98ab33a..22813e5 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -374,7 +374,7 @@ my(%suppress_cc);\n> if (@suppress_cc) {\n> \tforeach my $entry (@suppress_cc) {\n> \t\tdie \"Unknown --suppress-cc field: '$entry'\\n\"\n> -\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/;\n> +\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|.*@.*)$/;\n> \t\t$suppress_cc{$entry} = 1;\n> \t}\n> }\n> @@ -1213,6 +1213,11 @@ foreach my $t (@files) {\n> \t\t\t\t\t} else {\n> \t\t\t\t\t\tnext if ($suppress_cc{'cc'});\n> \t\t\t\t\t}\n> +\t\t\t\t\tnext if ($suppress_cc{$addr});\n> +\t\t\t\t\tif ($addr =~ /^(.+)(@.+)$/) {\n> +\t\t\t\t\t\tmy $domain = $2;\n> +\t\t\t\t\t\tnext if $suppress_cc{$domain};\n> +\t\t\t\t\t}\n> \t\t\t\t\tprintf(\"(mbox) Adding cc: %s from line '%s'\\n\",\n> \t\t\t\t\t\t$addr, $_) unless $quiet;\n> \t\t\t\t\tpush @cc, $addr;\n> @@ -1261,6 +1266,11 @@ foreach my $t (@files) {\n> \t\t\t\tnext if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;\n> \t\t\t\tnext if $suppress_cc{'bodycc'} and $what =~ /Cc/i;\n> \t\t\t}\n> +\t\t\tnext if ($suppress_cc{$c});\n> +\t\t\tif ($c =~ /^(.+)(@.+)$/) {\n> +\t\t\t\tmy $domain = $2;\n> +\t\t\t\tnext if $suppress_cc{$domain};\n> +\t\t\t}\n> \t\t\tpush @cc, $c;\n> \t\t\tprintf(\"(body) Adding cc: %s from line '%s'\\n\",\n> \t\t\t\t$c, $_) unless $quiet;\n> -- \n> 1.7.6\n"},{"id":"173192","messageId":"1312854103.1643.34.camel@Joe-Laptop","threadId":"28040","inReplyTo":"20110808211726.GA18619@elie.gateway.2wire.net","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Joe Perches","fromEmail":"joe@perches.com","sentAt":"2011-08-09T01:41:43Z","receivedAt":"2011-08-09T01:41:43Z","isPatch":false,"sender":{"key":"joe@perches.com","avatar":"https://avatars.githubusercontent.com/u/13122723?v=4"},"body":"On Mon, 2011-08-08 at 23:17 +0200, Jonathan Nieder wrote:\n> (+cc: some send-email people)\n> Daniel Mack wrote:\n> > I'm looking for a way to suppress certain Cc: fields that are normally\n> > automatically added for addresses mentioned in Cc: lines found in patches.\n> Makes sense. Could you please add a quick commit message, following\n> the guidelines in Documentation/SubmittingPatches (i.e., explaining\n> the problem this intends to solve and justifying how it is solved)?\n\nIt seems an odd use case to me.\nWhy are these added addresses undesired?\n\nAlso this does not work for cccmd addresses.\nYou'll need to add similar logic to recipient_cmd\nuses.\n\ncheers, Joe\n"},{"id":"173198","messageId":"20110809070141.GA13623@sigill.intra.peff.net","threadId":"28040","inReplyTo":"20110808210714.GA16512@elie.gateway.2wire.net","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2011-08-09T07:01:41Z","receivedAt":"2011-08-09T07:01:41Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Aug 08, 2011 at 11:07:14PM +0200, Jonathan Nieder wrote:\n\n> > I'm kind of confused why you would mark an address as \"cc\", but not cc\n> > it. Wouldn't it make sense to call the header something else?\n> \n> Maybe the patch is a draft and he is seeking early feedback. The\n> final version will be cc-ed to the indicated person later (and that's\n> part of what it is time to get feedback on).\n\nI suspect in that workflow, you would use --suppress-cc=all, and then\njust address it to whomever you are getting feedback from.\n\n> Or maybe the Cc: line is from the original patch and he is using git\n> send-email to forward it without mangling.\n\nIn that case, shouldn't the cc either be respected (since the original\npatch author wanted it so), or stripped (if the patch no longer has\nanything to do with that cc).\n\n\nStill, we are only guessing at possible workflows here. I don't have a\nproblem with the idea of per-address suppression; it makes git more\nflexible and doesn't hurt people who don't need the flexibility.\n\nI was more objecting to it as a solution to a workflow that is \"we want\na unique tag in the commit, so we called it 'cc', but don't want people\nto actually 'cc' it\". That's just wrong and silly. But it turns out that\nisn't happening here, anyway.\n\n-Peff\n"},{"id":"173200","messageId":"CACTFLAN4cg-7Z8WLVROZcAkOjSdf0_ZRbneTE=BasFz=zQwisA@mail.gmail.com","threadId":"28040","inReplyTo":"20110809070141.GA13623@sigill.intra.peff.net","subject":"Re: Suppressing auto-cc for specific addresses","fromName":"Daniel Mack","fromEmail":"zonque@gmail.com","sentAt":"2011-08-09T07:40:28Z","receivedAt":"2011-08-09T07:40:28Z","isPatch":false,"sender":{"key":"zonque@gmail.com","avatar":"https://gravatar.com/avatar/5ce636e56617f3619ba2b2f69b10e698c08f724f18dfd1708b55b4e85df40800?d=mp&s=160"},"body":"On Tue, Aug 9, 2011 at 9:01 AM, Jeff King wrote:\n> On Mon, Aug 08, 2011 at 11:07:14PM +0200, Jonathan Nieder wrote:\n>\n>> > I'm kind of confused why you would mark an address as \"cc\", but not cc\n>> > it. Wouldn't it make sense to call the header something else?\n>>\n>> Maybe the patch is a draft and he is seeking early feedback.  The\n>> final version will be cc-ed to the indicated person later (and that's\n>> part of what it is time to get feedback on).\n>\n> I suspect in that workflow, you would use --suppress-cc=all, and then\n> just address it to whomever you are getting feedback from.\n>\n>> Or maybe the Cc: line is from the original patch and he is using git\n>> send-email to forward it without mangling.\n>\n> In that case, shouldn't the cc either be respected (since the original\n> patch author wanted it so), or stripped (if the patch no longer has\n> anything to do with that cc).\n>\n>\n> Still, we are only guessing at possible workflows here. I don't have a\n> problem with the idea of per-address suppression; it makes git more\n> flexible and doesn't hurt people who don't need the flexibility.\n>\n> I was more objecting to it as a solution to a workflow that is \"we want\n> a unique tag in the commit, so we called it 'cc', but don't want people\n> to actually 'cc' it\". That's just wrong and silly. But it turns out that\n> isn't happening here, anyway.\n\nRight. I thought I might fix something here to improve a widely\nanticipated workflow, but as it turns out, it's not actually needed. I\ndon't personally have any other use for this feature, so I don't care\nmuch whether it will be applied eventually. Except for the fact that\nit would be my first contribution to git, of course ;)\n\nSo - up to you to decide.\n\n\nThanks,\nDaniel\n"}]}