{"thread":{"id":"28005","subject":"[PATCH] Skip archive --remote tests on Windows","startedAt":"2011-08-03T08:20:08Z","lastAt":"2011-08-03T10:40:04Z","messageCount":3,"participants":["Johannes Sixt","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"172735","messageId":"4E3904B8.7080208@viscovery.net","threadId":"28005","inReplyTo":null,"subject":"[PATCH] Skip archive --remote tests on Windows","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2011-08-03T08:20:08Z","receivedAt":"2011-08-03T08:20:08Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <j6t@kdbg.org>\n\nThese depend on a working git-upload-archive, which is broken on Windows,\nbecause it depends on fork().\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n These prerequisites are needed in current master, but would have to be\n patched out again by Erik's upload-archive series.\n\n t/t5000-tar-tree.sh |    8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh\nindex 9e3ba98..d906898 100755\n--- a/t/t5000-tar-tree.sh\n+++ b/t/t5000-tar-tree.sh\n@@ -266,7 +266,7 @@ test_expect_success 'archive --list mentions user filter' '\n \tgrep \"^bar\\$\" output\n '\n \n-test_expect_success 'archive --list shows only enabled remote filters' '\n+test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '\n \tgit archive --list --remote=. >output &&\n \t! grep \"^tar\\.foo\\$\" output &&\n \tgrep \"^bar\\$\" output\n@@ -298,7 +298,7 @@ test_expect_success 'extension matching requires dot' '\n \ttest_cmp b.tar config-implicittar.foo\n '\n \n-test_expect_success 'only enabled filters are available remotely' '\n+test_expect_success NOT_MINGW 'only enabled filters are available remotely' '\n \ttest_must_fail git archive --remote=. --format=tar.foo HEAD \\\n \t\t>remote.tar.foo &&\n \tgit archive --remote=. --format=bar >remote.bar HEAD &&\n@@ -341,12 +341,12 @@ test_expect_success GZIP,GUNZIP 'extract tgz file' '\n \ttest_cmp b.tar j.tar\n '\n \n-test_expect_success GZIP 'remote tar.gz is allowed by default' '\n+test_expect_success GZIP,NOT_MINGW 'remote tar.gz is allowed by default' '\n \tgit archive --remote=. --format=tar.gz HEAD >remote.tar.gz &&\n \ttest_cmp j.tgz remote.tar.gz\n '\n \n-test_expect_success GZIP 'remote tar.gz can be disabled' '\n+test_expect_success GZIP,NOT_MINGW 'remote tar.gz can be disabled' '\n \tgit config tar.tar.gz.remote false &&\n \ttest_must_fail git archive --remote=. --format=tar.gz HEAD \\\n \t\t>remote.tar.gz\n-- \n1.7.6.1572.g1f80c3\n"},{"id":"172737","messageId":"m3hb5yrhfw.fsf@localhost.localdomain","threadId":"28005","inReplyTo":"4E3904B8.7080208@viscovery.net","subject":"Re: [PATCH] Skip archive --remote tests on Windows","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-08-03T09:09:11Z","receivedAt":"2011-08-03T09:09:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Johannes Sixt <j.sixt@viscovery.net> writes:\n\n> From: Johannes Sixt <j6t@kdbg.org>\n> \n> These depend on a working git-upload-archive, which is broken on Windows,\n> because it depends on fork().\n> \n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n> ---\n>  These prerequisites are needed in current master, but would have to be\n>  patched out again by Erik's upload-archive series.\n[...]\n\n> -test_expect_success 'archive --list shows only enabled remote filters' '\n> +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '\n\nShouldn't the prerequisite be called FORK rather than NON_MINGW?\n\n-- \nJakub Narębski\n"},{"id":"172744","messageId":"4E392584.6060509@viscovery.net","threadId":"28005","inReplyTo":"m3hb5yrhfw.fsf@localhost.localdomain","subject":"Re: [PATCH] Skip archive --remote tests on Windows","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2011-08-03T10:40:04Z","receivedAt":"2011-08-03T10:40:04Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 8/3/2011 11:09, schrieb Jakub Narebski:\n> Johannes Sixt <j.sixt@viscovery.net> writes:\n>> -test_expect_success 'archive --list shows only enabled remote filters' '\n>> +test_expect_success NOT_MINGW 'archive --list shows only enabled remote filters' '\n> \n> Shouldn't the prerequisite be called FORK rather than NON_MINGW?\n\nYes, it should. But we already have one instance of NOT_MINGW in\nconnection with archive --remote in this file before this patch, and with\nErik's efforts, these particular prerequisites should go away anyway RSN.\n\n-- Hannes\n"}]}