{"thread":{"id":"27858","subject":"[PATCH] Makefile: add Minix configuration options.","startedAt":"2011-07-19T20:26:59Z","lastAt":"2011-07-19T21:39:14Z","messageCount":2,"participants":["Thomas Cort","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"171701","messageId":"20110719162659.81020d7c.tcort@minix3.org","threadId":"27858","inReplyTo":null,"subject":"[PATCH] Makefile: add Minix configuration options.","fromName":"Thomas Cort","fromEmail":"tcort@minix3.org","sentAt":"2011-07-19T20:26:59Z","receivedAt":"2011-07-19T20:26:59Z","isPatch":true,"sender":{"key":"tcort@minix3.org","avatar":null},"body":" * Adds a $(uname_S) case for Minix with the correct options.\n\n * Adds NEEDS_SSL_WITH_CURL and NEEDS_CRYPTO_WITH_SSL to the\n   libcurl section. On Minix both -lssl and -lcrypto are\n   needed when using -lcurl.\n\n * Changes OPENSSL_LINK to OPENSSL_LIBSSL in the\n   NEEDS_CRYPTO_WITH_SSL conditional in the libopenssl section.\n   The -lcrypto needs to be in OPENSSL_LIBSSL.\n\nSigned-off-by: Thomas Cort <tcort@minix3.org>\n---\n Makefile |   26 +++++++++++++++++++++++++-\n 1 files changed, 25 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 46793d1..e8280fc 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1146,6 +1146,20 @@ ifeq ($(uname_S),Interix)\n \t\tNO_FNMATCH_CASEFOLD = YesPlease\n \tendif\n endif\n+ifeq ($(uname_S),Minix)\n+\tNO_IPV6 = YesPlease\n+\tNO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease\n+\tNO_NSEC = YesPlease\n+\tNEEDS_LIBGEN =\n+\tNEEDS_CRYPTO_WITH_SSL = YesPlease\n+\tNEEDS_IDN_WITH_CURL = YesPlease\n+\tNEEDS_SSL_WITH_CURL = YesPlease\n+\tNEEDS_RESOLV =\n+\tNO_HSTRERROR = YesPlease\n+\tNO_MMAP = YesPlease\n+\tNO_CURL =\n+\tNO_EXPAT =\n+endif\n ifneq (,$(findstring MINGW,$(uname_S)))\n \tpathsep = ;\n \tNO_PREAD = YesPlease\n@@ -1290,6 +1304,16 @@ else\n \telse\n \t\tCURL_LIBCURL = -lcurl\n \tendif\n+\tifdef NEEDS_SSL_WITH_CURL\n+\t\tCURL_LIBCURL +=\t-lssl\n+\tendif\n+\tifdef NEEDS_CRYPTO_WITH_SSL\n+\t\tCURL_LIBCURL += -lcrypto\n+\tendif\n+\tifdef NEEDS_IDN_WITH_CURL\n+\t\tCURL_LIBCURL += -lidn\n+\tendif\n+\n \tREMOTE_CURL_PRIMARY = git-remote-http$X\n \tREMOTE_CURL_ALIASES = git-remote-https$X git-remote-ftp$X git-remote-ftps$X\n \tREMOTE_CURL_NAMES = $(REMOTE_CURL_PRIMARY) $(REMOTE_CURL_ALIASES)\n@@ -1326,7 +1350,7 @@ ifndef NO_OPENSSL\n \t\tOPENSSL_LINK =\n \tendif\n \tifdef NEEDS_CRYPTO_WITH_SSL\n-\t\tOPENSSL_LINK += -lcrypto\n+\t\tOPENSSL_LIBSSL += -lcrypto\n \tendif\n else\n \tBASIC_CFLAGS += -DNO_OPENSSL\n-- \n1.7.4.1\n"},{"id":"171708","messageId":"7vaaca7xx9.fsf@alter.siamese.dyndns.org","threadId":"27858","inReplyTo":"20110719162659.81020d7c.tcort@minix3.org","subject":"Re: [PATCH] Makefile: add Minix configuration options.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-07-19T21:39:14Z","receivedAt":"2011-07-19T21:39:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Cort <tcort@minix3.org> writes:\n\n>  * Adds a $(uname_S) case for Minix with the correct options.\n\nOk, but lose the asterisk and speak as if you are giving an order to the\ncodebase or the person who maintains it, i.e. \"Add $(uname_S) case...\".\n\n>  * Adds NEEDS_SSL_WITH_CURL and NEEDS_CRYPTO_WITH_SSL to the\n>    libcurl section. On Minix both -lssl and -lcrypto are\n>    needed when using -lcurl.\n\nThese...\n\n> +\tNEEDS_IDN_WITH_CURL = YesPlease\n> +\tNEEDS_SSL_WITH_CURL = YesPlease\n\n... are not described in the beginning of Makefile; add them.\n\n>  * Changes OPENSSL_LINK to OPENSSL_LIBSSL in the\n>    NEEDS_CRYPTO_WITH_SSL conditional in the libopenssl section.\n\nWhy is this change necessary?\n\n>    The -lcrypto needs to be in OPENSSL_LIBSSL.\n\nDitto.\n\nThanks.\n"}]}