{"thread":{"id":"2768","subject":"[PATCH] cg-object-id: comment the alternate id shortcut parsing","startedAt":"2005-12-07T21:39:43Z","lastAt":"2005-12-07T22:19:45Z","messageCount":4,"participants":["Jonas Fonseca","Petr Baudis"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"13331","messageId":"20051207213943.GC25890@diku.dk","threadId":"2768","inReplyTo":null,"subject":"[PATCH] cg-object-id: comment the alternate id shortcut parsing","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2005-12-07T21:39:43Z","receivedAt":"2005-12-07T21:39:43Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Add comment about why Cogito's own 4 digit id shortcut parser is needed.\n\nSigned-off-by: Jonas Fonseca \n\n---\ncommit 3c14cded46e110396127fc5b5e65883eb5cd60b9\ntree 593da711de14cfc3f8dc1fd5773990902568b42e\nparent 36c0d9fae209ab7fa889333e8eebef22e7f0f55c\nauthor Jonas Fonseca Wed, 07 Dec 2005 08:17:04 +0100\ncommitter Jonas Fonseca Wed, 07 Dec 2005 08:17:04 +0100\n\n cg-object-id | 4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/cg-object-id b/cg-object-id\nindex 56d9f91..ea04dca 100755\n--- a/cg-object-id\n+++ b/cg-object-id\n@@ -52,7 +52,9 @@ normalize_id()\n \t\tid=\"$revid\"\n \t\tvalid=1\n \n-\t# Short id's must be lower case and at least 4 digits.\n+\t# Short id's must be lower case and at least 4 digits. git-rev-parse(1)\n+\t# allows only down to 5 digits and we want to show the list of matched\n+\t# ids.\n \telif [[ \"$id\" == [0-9a-f][0-9a-f][0-9a-f][0-9a-f]* ]]; then\n \t\tidpref=${id:0:2}\n \t\tidpost=${id:2}\n\n-- \nJonas Fonseca\n"},{"id":"13337","messageId":"20051207220521.GM22159@pasky.or.cz","threadId":"2768","inReplyTo":"20051207213943.GC25890@diku.dk","subject":"Re: [PATCH] cg-object-id: comment the alternate id shortcut parsing","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2005-12-07T22:05:21Z","receivedAt":"2005-12-07T22:05:21Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Wed, Dec 07, 2005 at 10:39:43PM CET, I got a letter\nwhere Jonas Fonseca said that...\n> -\t# Short id's must be lower case and at least 4 digits.\n> +\t# Short id's must be lower case and at least 4 digits. git-rev-parse(1)\n> +\t# allows only down to 5 digits and we want to show the list of matched\n> +\t# ids.\n\nHuh. The code in sha1_name.c speaks differently and it works as well:\n\n\t$ git-rev-parse b1fc\n\tb1fcca45069d4f6b00a9ac7136be4268d09fd6b9\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nVI has two modes: the one in which it beeps and the one in which\nit doesn't.\n"},{"id":"13338","messageId":"20051207221449.GA27619@diku.dk","threadId":"2768","inReplyTo":"20051207220521.GM22159@pasky.or.cz","subject":"Re: [PATCH] cg-object-id: comment the alternate id shortcut parsing","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2005-12-07T22:14:49Z","receivedAt":"2005-12-07T22:14:49Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Petr Baudis wrote Wed, Dec 07, 2005:\n> Dear diary, on Wed, Dec 07, 2005 at 10:39:43PM CET, I got a letter\n> where Jonas Fonseca said that...\n> > -\t# Short id's must be lower case and at least 4 digits.\n> > +\t# Short id's must be lower case and at least 4 digits. git-rev-parse(1)\n> > +\t# allows only down to 5 digits and we want to show the list of matched\n> > +\t# ids.\n> \n> Huh. The code in sha1_name.c speaks differently and it works as well:\n> \n> \t$ git-rev-parse b1fc\n> \tb1fcca45069d4f6b00a9ac7136be4268d09fd6b9\n\nI had this one testcase:\n\n\t~/src/elinks/0.11 > cg-object-id --verify e6b6\n\tcg-object-id: unrecognized option `--verify'\n\t~/src/elinks/0.11 > cg-object-id e6b6\n\te6b65b543108bfeb95ea24978112b46e34cfde87\n\nCould it have something to do with the local packing?\n\n-- \nJonas Fonseca\n"},{"id":"13339","messageId":"20051207221945.GB27619@diku.dk","threadId":"2768","inReplyTo":"20051207221449.GA27619@diku.dk","subject":"Re: [PATCH] cg-object-id: comment the alternate id shortcut parsing","fromName":"Jonas Fonseca","fromEmail":"fonseca@diku.dk","sentAt":"2005-12-07T22:19:45Z","receivedAt":"2005-12-07T22:19:45Z","isPatch":true,"sender":{"key":"fonseca@diku.dk","avatar":"https://gravatar.com/avatar/f82f3ad698717c51873b020c750a92438c820a24056dc39fe4d07baa10a92264?d=mp&s=160"},"body":"Jonas Fonseca wrote Wed, Dec 07, 2005:\n> Petr Baudis wrote Wed, Dec 07, 2005:\n> > Dear diary, on Wed, Dec 07, 2005 at 10:39:43PM CET, I got a letter\n> > where Jonas Fonseca said that...\n> > > -\t# Short id's must be lower case and at least 4 digits.\n> > > +\t# Short id's must be lower case and at least 4 digits. git-rev-parse(1)\n> > > +\t# allows only down to 5 digits and we want to show the list of matched\n> > > +\t# ids.\n> > \n> > Huh. The code in sha1_name.c speaks differently and it works as well:\n> > \n> > \t$ git-rev-parse b1fc\n> > \tb1fcca45069d4f6b00a9ac7136be4268d09fd6b9\n> \n> I had this one testcase:\n> \n\t~/src/elinks/0.11 > git-rev-parse --verify e6b6\n\terror: short SHA1 e6b6 is ambiguous.\n\tfatal: Needed a single revision\n> \t~/src/elinks/0.11 > cg-object-id e6b6\n> \te6b65b543108bfeb95ea24978112b46e34cfde87\n> \n> Could it have something to do with the local packing?\n\n-- \nJonas Fonseca\n"}]}