{"thread":{"id":"27659","subject":"[PATCH/RFC] Move contents of libgit.a to lib subdirectory","startedAt":"2011-06-20T00:50:58Z","lastAt":"2011-06-20T14:55:58Z","messageCount":7,"participants":["Peter Foley","Shawn Pearce","Jonathan Nieder","Junio C Hamano","Thiago Farina"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"170271","messageId":"alpine.LNX.2.00.1106192014410.41113@linux.foleyremote.com","threadId":"27659","inReplyTo":null,"subject":"[PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Peter Foley","fromEmail":"pefoley2@verizon.net","sentAt":"2011-06-20T00:50:58Z","receivedAt":"2011-06-20T00:50:58Z","isPatch":true,"sender":{"key":"pefoley2@verizon.net","avatar":null},"body":"This patch tries to organize the git source tree by moving the files which \nmake up libgit.a to a lib subdirectory.\nBefore this patch the toplevel source directory contained 285 files. \nAfter this patch the root directory will contain 167 files and \nthe lib subdirectory will contain 119 files\n\nSigned-off-by: Peter Foley <pefoley2@verizon.net>\n---\n Makefile                                     |  258 +++++++++++++-------------\n abspath.c => lib/abspath.c                   |    0\n advice.c => lib/advice.c                     |    0\n alias.c => lib/alias.c                       |    0\n alloc.c => lib/alloc.c                       |    0\n archive-tar.c => lib/archive-tar.c           |    0\n archive-zip.c => lib/archive-zip.c           |    0\n archive.c => lib/archive.c                   |    0\n attr.c => lib/attr.c                         |    0\n base85.c => lib/base85.c                     |    0\n bisect.c => lib/bisect.c                     |    0\n blob.c => lib/blob.c                         |    0\n branch.c => lib/branch.c                     |    0\n bundle.c => lib/bundle.c                     |    0\n cache-tree.c => lib/cache-tree.c             |    0\n color.c => lib/color.c                       |    0\n combine-diff.c => lib/combine-diff.c         |    0\n commit.c => lib/commit.c                     |    0\n config.c => lib/config.c                     |    0\n connect.c => lib/connect.c                   |    0\n convert.c => lib/convert.c                   |    0\n copy.c => lib/copy.c                         |    0\n csum-file.c => lib/csum-file.c               |    0\n ctype.c => lib/ctype.c                       |    0\n date.c => lib/date.c                         |    0\n decorate.c => lib/decorate.c                 |    0\n diff-delta.c => lib/diff-delta.c             |    0\n diff-lib.c => lib/diff-lib.c                 |    0\n diff-no-index.c => lib/diff-no-index.c       |    0\n diff.c => lib/diff.c                         |    0\n diffcore-break.c => lib/diffcore-break.c     |    0\n diffcore-delta.c => lib/diffcore-delta.c     |    0\n diffcore-order.c => lib/diffcore-order.c     |    0\n diffcore-pickaxe.c => lib/diffcore-pickaxe.c |    0\n diffcore-rename.c => lib/diffcore-rename.c   |    0\n dir.c => lib/dir.c                           |    0\n editor.c => lib/editor.c                     |    0\n entry.c => lib/entry.c                       |    0\n environment.c => lib/environment.c           |    0\n exec_cmd.c => lib/exec_cmd.c                 |    0\n fsck.c => lib/fsck.c                         |    0\n gettext.c => lib/gettext.c                   |    0\n graph.c => lib/graph.c                       |    0\n grep.c => lib/grep.c                         |    0\n hash.c => lib/hash.c                         |    0\n help.c => lib/help.c                         |    0\n hex.c => lib/hex.c                           |    0\n ident.c => lib/ident.c                       |    0\n levenshtein.c => lib/levenshtein.c           |    0\n list-objects.c => lib/list-objects.c         |    0\n ll-merge.c => lib/ll-merge.c                 |    0\n lockfile.c => lib/lockfile.c                 |    0\n log-tree.c => lib/log-tree.c                 |    0\n mailmap.c => lib/mailmap.c                   |    0\n match-trees.c => lib/match-trees.c           |    0\n merge-file.c => lib/merge-file.c             |    0\n merge-recursive.c => lib/merge-recursive.c   |    0\n name-hash.c => lib/name-hash.c               |    0\n notes-cache.c => lib/notes-cache.c           |    0\n notes-merge.c => lib/notes-merge.c           |    0\n notes.c => lib/notes.c                       |    0\n object.c => lib/object.c                     |    0\n pack-check.c => lib/pack-check.c             |    0\n pack-refs.c => lib/pack-refs.c               |    0\n pack-revindex.c => lib/pack-revindex.c       |    0\n pack-write.c => lib/pack-write.c             |    0\n pager.c => lib/pager.c                       |    0\n parse-options.c => lib/parse-options.c       |    0\n patch-delta.c => lib/patch-delta.c           |    0\n patch-ids.c => lib/patch-ids.c               |    0\n path.c => lib/path.c                         |    0\n pkt-line.c => lib/pkt-line.c                 |    0\n preload-index.c => lib/preload-index.c       |    0\n pretty.c => lib/pretty.c                     |    0\n progress.c => lib/progress.c                 |    0\n quote.c => lib/quote.c                       |    0\n reachable.c => lib/reachable.c               |    0\n read-cache.c => lib/read-cache.c             |    0\n reflog-walk.c => lib/reflog-walk.c           |    0\n refs.c => lib/refs.c                         |    0\n remote.c => lib/remote.c                     |    0\n replace_object.c => lib/replace_object.c     |    0\n rerere.c => lib/rerere.c                     |    0\n resolve-undo.c => lib/resolve-undo.c         |    0\n revision.c => lib/revision.c                 |    0\n run-command.c => lib/run-command.c           |    0\n server-info.c => lib/server-info.c           |    0\n setup.c => lib/setup.c                       |    0\n sha1-array.c => lib/sha1-array.c             |    0\n sha1-lookup.c => lib/sha1-lookup.c           |    0\n sha1_file.c => lib/sha1_file.c               |    0\n sha1_name.c => lib/sha1_name.c               |    0\n shallow.c => lib/shallow.c                   |    0\n sideband.c => lib/sideband.c                 |    0\n sigchain.c => lib/sigchain.c                 |    0\n strbuf.c => lib/strbuf.c                     |    0\n string-list.c => lib/string-list.c           |    0\n submodule.c => lib/submodule.c               |    0\n symlinks.c => lib/symlinks.c                 |    0\n tag.c => lib/tag.c                           |    0\n thread-utils.c => lib/thread-utils.c         |    0\n trace.c => lib/trace.c                       |    0\n transport-helper.c => lib/transport-helper.c |    0\n transport.c => lib/transport.c               |    0\n tree-diff.c => lib/tree-diff.c               |    0\n tree-walk.c => lib/tree-walk.c               |    0\n tree.c => lib/tree.c                         |    0\n unpack-trees.c => lib/unpack-trees.c         |    0\n url.c => lib/url.c                           |    0\n usage.c => lib/usage.c                       |    0\n userdiff.c => lib/userdiff.c                 |    0\n utf8.c => lib/utf8.c                         |    0\n walker.c => lib/walker.c                     |    0\n wrapper.c => lib/wrapper.c                   |    0\n write_or_die.c => lib/write_or_die.c         |    0\n ws.c => lib/ws.c                             |    0\n wt-status.c => lib/wt-status.c               |    0\n xdiff-interface.c => lib/xdiff-interface.c   |    0\n zlib.c => lib/zlib.c                         |    0\n 119 files changed, 129 insertions(+), 129 deletions(-)\n rename abspath.c => lib/abspath.c (100%)\n rename advice.c => lib/advice.c (100%)\n rename alias.c => lib/alias.c (100%)\n rename alloc.c => lib/alloc.c (100%)\n rename archive-tar.c => lib/archive-tar.c (100%)\n rename archive-zip.c => lib/archive-zip.c (100%)\n rename archive.c => lib/archive.c (100%)\n rename attr.c => lib/attr.c (100%)\n rename base85.c => lib/base85.c (100%)\n rename bisect.c => lib/bisect.c (100%)\n rename blob.c => lib/blob.c (100%)\n rename branch.c => lib/branch.c (100%)\n rename bundle.c => lib/bundle.c (100%)\n rename cache-tree.c => lib/cache-tree.c (100%)\n rename color.c => lib/color.c (100%)\n rename combine-diff.c => lib/combine-diff.c (100%)\n rename commit.c => lib/commit.c (100%)\n rename config.c => lib/config.c (100%)\n rename connect.c => lib/connect.c (100%)\n rename convert.c => lib/convert.c (100%)\n rename copy.c => lib/copy.c (100%)\n rename csum-file.c => lib/csum-file.c (100%)\n rename ctype.c => lib/ctype.c (100%)\n rename date.c => lib/date.c (100%)\n rename decorate.c => lib/decorate.c (100%)\n rename diff-delta.c => lib/diff-delta.c (100%)\n rename diff-lib.c => lib/diff-lib.c (100%)\n rename diff-no-index.c => lib/diff-no-index.c (100%)\n rename diff.c => lib/diff.c (100%)\n rename diffcore-break.c => lib/diffcore-break.c (100%)\n rename diffcore-delta.c => lib/diffcore-delta.c (100%)\n rename diffcore-order.c => lib/diffcore-order.c (100%)\n rename diffcore-pickaxe.c => lib/diffcore-pickaxe.c (100%)\n rename diffcore-rename.c => lib/diffcore-rename.c (100%)\n rename dir.c => lib/dir.c (100%)\n rename editor.c => lib/editor.c (100%)\n rename entry.c => lib/entry.c (100%)\n rename environment.c => lib/environment.c (100%)\n rename exec_cmd.c => lib/exec_cmd.c (100%)\n rename fsck.c => lib/fsck.c (100%)\n rename gettext.c => lib/gettext.c (100%)\n rename graph.c => lib/graph.c (100%)\n rename grep.c => lib/grep.c (100%)\n rename hash.c => lib/hash.c (100%)\n rename help.c => lib/help.c (100%)\n rename hex.c => lib/hex.c (100%)\n rename ident.c => lib/ident.c (100%)\n rename levenshtein.c => lib/levenshtein.c (100%)\n rename list-objects.c => lib/list-objects.c (100%)\n rename ll-merge.c => lib/ll-merge.c (100%)\n rename lockfile.c => lib/lockfile.c (100%)\n rename log-tree.c => lib/log-tree.c (100%)\n rename mailmap.c => lib/mailmap.c (100%)\n rename match-trees.c => lib/match-trees.c (100%)\n rename merge-file.c => lib/merge-file.c (100%)\n rename merge-recursive.c => lib/merge-recursive.c (100%)\n rename name-hash.c => lib/name-hash.c (100%)\n rename notes-cache.c => lib/notes-cache.c (100%)\n rename notes-merge.c => lib/notes-merge.c (100%)\n rename notes.c => lib/notes.c (100%)\n rename object.c => lib/object.c (100%)\n rename pack-check.c => lib/pack-check.c (100%)\n rename pack-refs.c => lib/pack-refs.c (100%)\n rename pack-revindex.c => lib/pack-revindex.c (100%)\n rename pack-write.c => lib/pack-write.c (100%)\n rename pager.c => lib/pager.c (100%)\n rename parse-options.c => lib/parse-options.c (100%)\n rename patch-delta.c => lib/patch-delta.c (100%)\n rename patch-ids.c => lib/patch-ids.c (100%)\n rename path.c => lib/path.c (100%)\n rename pkt-line.c => lib/pkt-line.c (100%)\n rename preload-index.c => lib/preload-index.c (100%)\n rename pretty.c => lib/pretty.c (100%)\n rename progress.c => lib/progress.c (100%)\n rename quote.c => lib/quote.c (100%)\n rename reachable.c => lib/reachable.c (100%)\n rename read-cache.c => lib/read-cache.c (100%)\n rename reflog-walk.c => lib/reflog-walk.c (100%)\n rename refs.c => lib/refs.c (100%)\n rename remote.c => lib/remote.c (100%)\n rename replace_object.c => lib/replace_object.c (100%)\n rename rerere.c => lib/rerere.c (100%)\n rename resolve-undo.c => lib/resolve-undo.c (100%)\n rename revision.c => lib/revision.c (100%)\n rename run-command.c => lib/run-command.c (100%)\n rename server-info.c => lib/server-info.c (100%)\n rename setup.c => lib/setup.c (100%)\n rename sha1-array.c => lib/sha1-array.c (100%)\n rename sha1-lookup.c => lib/sha1-lookup.c (100%)\n rename sha1_file.c => lib/sha1_file.c (100%)\n rename sha1_name.c => lib/sha1_name.c (100%)\n rename shallow.c => lib/shallow.c (100%)\n rename sideband.c => lib/sideband.c (100%)\n rename sigchain.c => lib/sigchain.c (100%)\n rename strbuf.c => lib/strbuf.c (100%)\n rename string-list.c => lib/string-list.c (100%)\n rename submodule.c => lib/submodule.c (100%)\n rename symlinks.c => lib/symlinks.c (100%)\n rename tag.c => lib/tag.c (100%)\n rename thread-utils.c => lib/thread-utils.c (100%)\n rename trace.c => lib/trace.c (100%)\n rename transport-helper.c => lib/transport-helper.c (100%)\n rename transport.c => lib/transport.c (100%)\n rename tree-diff.c => lib/tree-diff.c (100%)\n rename tree-walk.c => lib/tree-walk.c (100%)\n rename tree.c => lib/tree.c (100%)\n rename unpack-trees.c => lib/unpack-trees.c (100%)\n rename url.c => lib/url.c (100%)\n rename usage.c => lib/usage.c (100%)\n rename userdiff.c => lib/userdiff.c (100%)\n rename utf8.c => lib/utf8.c (100%)\n rename walker.c => lib/walker.c (100%)\n rename wrapper.c => lib/wrapper.c (100%)\n rename write_or_die.c => lib/write_or_die.c (100%)\n rename ws.c => lib/ws.c (100%)\n rename wt-status.c => lib/wt-status.c (100%)\n rename xdiff-interface.c => lib/xdiff-interface.c (100%)\n rename zlib.c => lib/zlib.c (100%)\n\ndiff --git a/Makefile b/Makefile\nindex e40ac0c..9982d2d 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -568,122 +568,122 @@ LIB_H += utf8.h\n LIB_H += xdiff-interface.h\n LIB_H += xdiff/xdiff.h\n \n-LIB_OBJS += abspath.o\n-LIB_OBJS += advice.o\n-LIB_OBJS += alias.o\n-LIB_OBJS += alloc.o\n-LIB_OBJS += archive.o\n-LIB_OBJS += archive-tar.o\n-LIB_OBJS += archive-zip.o\n-LIB_OBJS += attr.o\n-LIB_OBJS += base85.o\n-LIB_OBJS += bisect.o\n-LIB_OBJS += blob.o\n-LIB_OBJS += branch.o\n-LIB_OBJS += bundle.o\n-LIB_OBJS += cache-tree.o\n-LIB_OBJS += color.o\n-LIB_OBJS += combine-diff.o\n-LIB_OBJS += commit.o\n-LIB_OBJS += config.o\n-LIB_OBJS += connect.o\n-LIB_OBJS += convert.o\n-LIB_OBJS += copy.o\n-LIB_OBJS += csum-file.o\n-LIB_OBJS += ctype.o\n-LIB_OBJS += date.o\n-LIB_OBJS += decorate.o\n-LIB_OBJS += diffcore-break.o\n-LIB_OBJS += diffcore-delta.o\n-LIB_OBJS += diffcore-order.o\n-LIB_OBJS += diffcore-pickaxe.o\n-LIB_OBJS += diffcore-rename.o\n-LIB_OBJS += diff-delta.o\n-LIB_OBJS += diff-lib.o\n-LIB_OBJS += diff-no-index.o\n-LIB_OBJS += diff.o\n-LIB_OBJS += dir.o\n-LIB_OBJS += editor.o\n-LIB_OBJS += entry.o\n-LIB_OBJS += environment.o\n-LIB_OBJS += exec_cmd.o\n-LIB_OBJS += fsck.o\n-LIB_OBJS += graph.o\n-LIB_OBJS += grep.o\n-LIB_OBJS += hash.o\n-LIB_OBJS += help.o\n-LIB_OBJS += hex.o\n-LIB_OBJS += ident.o\n-LIB_OBJS += levenshtein.o\n-LIB_OBJS += list-objects.o\n-LIB_OBJS += ll-merge.o\n-LIB_OBJS += lockfile.o\n-LIB_OBJS += log-tree.o\n-LIB_OBJS += mailmap.o\n-LIB_OBJS += match-trees.o\n-LIB_OBJS += merge-file.o\n-LIB_OBJS += merge-recursive.o\n-LIB_OBJS += name-hash.o\n-LIB_OBJS += notes.o\n-LIB_OBJS += notes-cache.o\n-LIB_OBJS += notes-merge.o\n-LIB_OBJS += object.o\n-LIB_OBJS += pack-check.o\n-LIB_OBJS += pack-refs.o\n-LIB_OBJS += pack-revindex.o\n-LIB_OBJS += pack-write.o\n-LIB_OBJS += pager.o\n-LIB_OBJS += parse-options.o\n-LIB_OBJS += patch-delta.o\n-LIB_OBJS += patch-ids.o\n-LIB_OBJS += path.o\n-LIB_OBJS += pkt-line.o\n-LIB_OBJS += preload-index.o\n-LIB_OBJS += pretty.o\n-LIB_OBJS += progress.o\n-LIB_OBJS += quote.o\n-LIB_OBJS += reachable.o\n-LIB_OBJS += read-cache.o\n-LIB_OBJS += reflog-walk.o\n-LIB_OBJS += refs.o\n-LIB_OBJS += remote.o\n-LIB_OBJS += replace_object.o\n-LIB_OBJS += rerere.o\n-LIB_OBJS += resolve-undo.o\n-LIB_OBJS += revision.o\n-LIB_OBJS += run-command.o\n-LIB_OBJS += server-info.o\n-LIB_OBJS += setup.o\n-LIB_OBJS += sha1-array.o\n-LIB_OBJS += sha1-lookup.o\n-LIB_OBJS += sha1_file.o\n-LIB_OBJS += sha1_name.o\n-LIB_OBJS += shallow.o\n-LIB_OBJS += sideband.o\n-LIB_OBJS += sigchain.o\n-LIB_OBJS += strbuf.o\n-LIB_OBJS += string-list.o\n-LIB_OBJS += submodule.o\n-LIB_OBJS += symlinks.o\n-LIB_OBJS += tag.o\n-LIB_OBJS += trace.o\n-LIB_OBJS += transport.o\n-LIB_OBJS += transport-helper.o\n-LIB_OBJS += tree-diff.o\n-LIB_OBJS += tree.o\n-LIB_OBJS += tree-walk.o\n-LIB_OBJS += unpack-trees.o\n-LIB_OBJS += url.o\n-LIB_OBJS += usage.o\n-LIB_OBJS += userdiff.o\n-LIB_OBJS += utf8.o\n-LIB_OBJS += walker.o\n-LIB_OBJS += wrapper.o\n-LIB_OBJS += write_or_die.o\n-LIB_OBJS += ws.o\n-LIB_OBJS += wt-status.o\n-LIB_OBJS += xdiff-interface.o\n-LIB_OBJS += zlib.o\n+LIB_OBJS += lib/abspath.o\n+LIB_OBJS += lib/advice.o\n+LIB_OBJS += lib/alias.o\n+LIB_OBJS += lib/alloc.o\n+LIB_OBJS += lib/archive.o\n+LIB_OBJS += lib/archive-tar.o\n+LIB_OBJS += lib/archive-zip.o\n+LIB_OBJS += lib/attr.o\n+LIB_OBJS += lib/base85.o\n+LIB_OBJS += lib/bisect.o\n+LIB_OBJS += lib/blob.o\n+LIB_OBJS += lib/branch.o\n+LIB_OBJS += lib/bundle.o\n+LIB_OBJS += lib/cache-tree.o\n+LIB_OBJS += lib/color.o\n+LIB_OBJS += lib/combine-diff.o\n+LIB_OBJS += lib/commit.o\n+LIB_OBJS += lib/config.o\n+LIB_OBJS += lib/connect.o\n+LIB_OBJS += lib/convert.o\n+LIB_OBJS += lib/copy.o\n+LIB_OBJS += lib/csum-file.o\n+LIB_OBJS += lib/ctype.o\n+LIB_OBJS += lib/date.o\n+LIB_OBJS += lib/decorate.o\n+LIB_OBJS += lib/diffcore-break.o\n+LIB_OBJS += lib/diffcore-delta.o\n+LIB_OBJS += lib/diffcore-order.o\n+LIB_OBJS += lib/diffcore-pickaxe.o\n+LIB_OBJS += lib/diffcore-rename.o\n+LIB_OBJS += lib/diff-delta.o\n+LIB_OBJS += lib/diff-lib.o\n+LIB_OBJS += lib/diff-no-index.o\n+LIB_OBJS += lib/diff.o\n+LIB_OBJS += lib/dir.o\n+LIB_OBJS += lib/editor.o\n+LIB_OBJS += lib/entry.o\n+LIB_OBJS += lib/environment.o\n+LIB_OBJS += lib/exec_cmd.o\n+LIB_OBJS += lib/fsck.o\n+LIB_OBJS += lib/graph.o\n+LIB_OBJS += lib/grep.o\n+LIB_OBJS += lib/hash.o\n+LIB_OBJS += lib/help.o\n+LIB_OBJS += lib/hex.o\n+LIB_OBJS += lib/ident.o\n+LIB_OBJS += lib/levenshtein.o\n+LIB_OBJS += lib/list-objects.o\n+LIB_OBJS += lib/ll-merge.o\n+LIB_OBJS += lib/lockfile.o\n+LIB_OBJS += lib/log-tree.o\n+LIB_OBJS += lib/mailmap.o\n+LIB_OBJS += lib/match-trees.o\n+LIB_OBJS += lib/merge-file.o\n+LIB_OBJS += lib/merge-recursive.o\n+LIB_OBJS += lib/name-hash.o\n+LIB_OBJS += lib/notes.o\n+LIB_OBJS += lib/notes-cache.o\n+LIB_OBJS += lib/notes-merge.o\n+LIB_OBJS += lib/object.o\n+LIB_OBJS += lib/pack-check.o\n+LIB_OBJS += lib/pack-refs.o\n+LIB_OBJS += lib/pack-revindex.o\n+LIB_OBJS += lib/pack-write.o\n+LIB_OBJS += lib/pager.o\n+LIB_OBJS += lib/parse-options.o\n+LIB_OBJS += lib/patch-delta.o\n+LIB_OBJS += lib/patch-ids.o\n+LIB_OBJS += lib/path.o\n+LIB_OBJS += lib/pkt-line.o\n+LIB_OBJS += lib/preload-index.o\n+LIB_OBJS += lib/pretty.o\n+LIB_OBJS += lib/progress.o\n+LIB_OBJS += lib/quote.o\n+LIB_OBJS += lib/reachable.o\n+LIB_OBJS += lib/read-cache.o\n+LIB_OBJS += lib/reflog-walk.o\n+LIB_OBJS += lib/refs.o\n+LIB_OBJS += lib/remote.o\n+LIB_OBJS += lib/replace_object.o\n+LIB_OBJS += lib/rerere.o\n+LIB_OBJS += lib/resolve-undo.o\n+LIB_OBJS += lib/revision.o\n+LIB_OBJS += lib/run-command.o\n+LIB_OBJS += lib/server-info.o\n+LIB_OBJS += lib/setup.o\n+LIB_OBJS += lib/sha1-array.o\n+LIB_OBJS += lib/sha1-lookup.o\n+LIB_OBJS += lib/sha1_file.o\n+LIB_OBJS += lib/sha1_name.o\n+LIB_OBJS += lib/shallow.o\n+LIB_OBJS += lib/sideband.o\n+LIB_OBJS += lib/sigchain.o\n+LIB_OBJS += lib/strbuf.o\n+LIB_OBJS += lib/string-list.o\n+LIB_OBJS += lib/submodule.o\n+LIB_OBJS += lib/symlinks.o\n+LIB_OBJS += lib/tag.o\n+LIB_OBJS += lib/trace.o\n+LIB_OBJS += lib/transport.o\n+LIB_OBJS += lib/transport-helper.o\n+LIB_OBJS += lib/tree-diff.o\n+LIB_OBJS += lib/tree.o\n+LIB_OBJS += lib/tree-walk.o\n+LIB_OBJS += lib/unpack-trees.o\n+LIB_OBJS += lib/url.o\n+LIB_OBJS += lib/usage.o\n+LIB_OBJS += lib/userdiff.o\n+LIB_OBJS += lib/utf8.o\n+LIB_OBJS += lib/walker.o\n+LIB_OBJS += lib/wrapper.o\n+LIB_OBJS += lib/write_or_die.o\n+LIB_OBJS += lib/ws.o\n+LIB_OBJS += lib/wt-status.o\n+LIB_OBJS += lib/xdiff-interface.o\n+LIB_OBJS += lib/zlib.o\n \n BUILTIN_OBJS += builtin/add.o\n BUILTIN_OBJS += builtin/annotate.o\n@@ -1389,7 +1389,7 @@ ifdef NO_SYMLINK_HEAD\n \tBASIC_CFLAGS += -DNO_SYMLINK_HEAD\n endif\n ifdef GETTEXT_POISON\n-\tLIB_OBJS += gettext.o\n+\tLIB_OBJS += lib/gettext.o\n \tBASIC_CFLAGS += -DGETTEXT_POISON\n endif\n ifdef NO_STRCASESTR\n@@ -1547,7 +1547,7 @@ ifdef NO_PTHREADS\n else\n \tBASIC_CFLAGS += $(PTHREAD_CFLAGS)\n \tEXTLIBS += $(PTHREAD_LIBS)\n-\tLIB_OBJS += thread-utils.o\n+\tLIB_OBJS += lib/thread-utils.o\n endif\n \n ifdef HAVE_PATHS_H\n@@ -1710,7 +1710,7 @@ git$X: git.o $(BUILTIN_OBJS) $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ git.o \\\n \t\t$(BUILTIN_OBJS) $(ALL_LDFLAGS) $(LIBS)\n \n-help.sp help.o: common-cmds.h\n+lib/help.sp lib/help.o: common-cmds.h\n \n builtin/help.sp builtin/help.o: common-cmds.h\n builtin/help.sp builtin/help.s builtin/help.o: EXTRA_CPPFLAGS = \\\n@@ -1973,7 +1973,7 @@ $(VCSSVN_OBJS) $(VCSSVN_TEST_OBJS): $(LIB_H) \\\n test-svn-fe.o: vcs-svn/svndump.h\n endif\n \n-exec_cmd.sp exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \\\n+lib/exec_cmd.sp lib/exec_cmd.s lib/exec_cmd.o: EXTRA_CPPFLAGS = \\\n \t'-DGIT_EXEC_PATH=\"$(gitexecdir_SQ)\"' \\\n \t'-DBINDIR=\"$(bindir_relative_SQ)\"' \\\n \t'-DPREFIX=\"$(prefix_SQ)\"'\n@@ -1981,10 +1981,10 @@ exec_cmd.sp exec_cmd.s exec_cmd.o: EXTRA_CPPFLAGS = \\\n builtin/init-db.sp builtin/init-db.s builtin/init-db.o: EXTRA_CPPFLAGS = \\\n \t-DDEFAULT_GIT_TEMPLATE_DIR='\"$(template_dir_SQ)\"'\n \n-config.sp config.s config.o: EXTRA_CPPFLAGS = \\\n+lib/config.sp lib/config.s lib/config.o: EXTRA_CPPFLAGS = \\\n \t-DETC_GITCONFIG='\"$(ETC_GITCONFIG_SQ)\"'\n \n-attr.sp attr.s attr.o: EXTRA_CPPFLAGS = \\\n+lib/attr.sp lib/attr.s lib/attr.o: EXTRA_CPPFLAGS = \\\n \t-DETC_GITATTRIBUTES='\"$(ETC_GITATTRIBUTES_SQ)\"'\n \n http.sp http.s http.o: EXTRA_CPPFLAGS = \\\n@@ -2011,10 +2011,10 @@ git-imap-send$X: imap-send.o $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO)\n \n-git-http-fetch$X: revision.o http.o http-walker.o http-fetch.o $(GITLIBS)\n+git-http-fetch$X: lib/revision.o http.o http-walker.o http-fetch.o $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL)\n-git-http-push$X: revision.o http.o http-push.o $(GITLIBS)\n+git-http-push$X: lib/revision.o http.o http-push.o $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \\\n \t\t$(LIBS) $(CURL_LIBCURL) $(EXPAT_LIBEXPAT)\n \n@@ -2149,15 +2149,15 @@ export NO_SVN_TESTS\n test: all\n \t$(MAKE) -C t/ all\n \n-test-ctype$X: ctype.o\n+test-ctype$X: lib/ctype.o\n \n-test-date$X: date.o ctype.o\n+test-date$X: lib/date.o lib/ctype.o\n \n-test-delta$X: diff-delta.o patch-delta.o\n+test-delta$X: lib/diff-delta.o lib/patch-delta.o\n \n test-line-buffer$X: vcs-svn/lib.a\n \n-test-parse-options$X: parse-options.o\n+test-parse-options$X: lib/parse-options.o\n \n test-string-pool$X: vcs-svn/lib.a\n \n@@ -2350,7 +2350,7 @@ distclean: clean\n \n clean:\n \t$(RM) *.o block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \\\n-\t\tbuiltin/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB)\n+\t\tbuiltin/*.o lib/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB)\n \t$(RM) $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) git$X\n \t$(RM) $(TEST_PROGRAMS)\n \t$(RM) -r bin-wrappers\ndiff --git a/abspath.c b/lib/abspath.c\nsimilarity index 100%\nrename from abspath.c\nrename to lib/abspath.c\ndiff --git a/advice.c b/lib/advice.c\nsimilarity index 100%\nrename from advice.c\nrename to lib/advice.c\ndiff --git a/alias.c b/lib/alias.c\nsimilarity index 100%\nrename from alias.c\nrename to lib/alias.c\ndiff --git a/alloc.c b/lib/alloc.c\nsimilarity index 100%\nrename from alloc.c\nrename to lib/alloc.c\ndiff --git a/archive-tar.c b/lib/archive-tar.c\nsimilarity index 100%\nrename from archive-tar.c\nrename to lib/archive-tar.c\ndiff --git a/archive-zip.c b/lib/archive-zip.c\nsimilarity index 100%\nrename from archive-zip.c\nrename to lib/archive-zip.c\ndiff --git a/archive.c b/lib/archive.c\nsimilarity index 100%\nrename from archive.c\nrename to lib/archive.c\ndiff --git a/attr.c b/lib/attr.c\nsimilarity index 100%\nrename from attr.c\nrename to lib/attr.c\ndiff --git a/base85.c b/lib/base85.c\nsimilarity index 100%\nrename from base85.c\nrename to lib/base85.c\ndiff --git a/bisect.c b/lib/bisect.c\nsimilarity index 100%\nrename from bisect.c\nrename to lib/bisect.c\ndiff --git a/blob.c b/lib/blob.c\nsimilarity index 100%\nrename from blob.c\nrename to lib/blob.c\ndiff --git a/branch.c b/lib/branch.c\nsimilarity index 100%\nrename from branch.c\nrename to lib/branch.c\ndiff --git a/bundle.c b/lib/bundle.c\nsimilarity index 100%\nrename from bundle.c\nrename to lib/bundle.c\ndiff --git a/cache-tree.c b/lib/cache-tree.c\nsimilarity index 100%\nrename from cache-tree.c\nrename to lib/cache-tree.c\ndiff --git a/color.c b/lib/color.c\nsimilarity index 100%\nrename from color.c\nrename to lib/color.c\ndiff --git a/combine-diff.c b/lib/combine-diff.c\nsimilarity index 100%\nrename from combine-diff.c\nrename to lib/combine-diff.c\ndiff --git a/commit.c b/lib/commit.c\nsimilarity index 100%\nrename from commit.c\nrename to lib/commit.c\ndiff --git a/config.c b/lib/config.c\nsimilarity index 100%\nrename from config.c\nrename to lib/config.c\ndiff --git a/connect.c b/lib/connect.c\nsimilarity index 100%\nrename from connect.c\nrename to lib/connect.c\ndiff --git a/convert.c b/lib/convert.c\nsimilarity index 100%\nrename from convert.c\nrename to lib/convert.c\ndiff --git a/copy.c b/lib/copy.c\nsimilarity index 100%\nrename from copy.c\nrename to lib/copy.c\ndiff --git a/csum-file.c b/lib/csum-file.c\nsimilarity index 100%\nrename from csum-file.c\nrename to lib/csum-file.c\ndiff --git a/ctype.c b/lib/ctype.c\nsimilarity index 100%\nrename from ctype.c\nrename to lib/ctype.c\ndiff --git a/date.c b/lib/date.c\nsimilarity index 100%\nrename from date.c\nrename to lib/date.c\ndiff --git a/decorate.c b/lib/decorate.c\nsimilarity index 100%\nrename from decorate.c\nrename to lib/decorate.c\ndiff --git a/diff-delta.c b/lib/diff-delta.c\nsimilarity index 100%\nrename from diff-delta.c\nrename to lib/diff-delta.c\ndiff --git a/diff-lib.c b/lib/diff-lib.c\nsimilarity index 100%\nrename from diff-lib.c\nrename to lib/diff-lib.c\ndiff --git a/diff-no-index.c b/lib/diff-no-index.c\nsimilarity index 100%\nrename from diff-no-index.c\nrename to lib/diff-no-index.c\ndiff --git a/diff.c b/lib/diff.c\nsimilarity index 100%\nrename from diff.c\nrename to lib/diff.c\ndiff --git a/diffcore-break.c b/lib/diffcore-break.c\nsimilarity index 100%\nrename from diffcore-break.c\nrename to lib/diffcore-break.c\ndiff --git a/diffcore-delta.c b/lib/diffcore-delta.c\nsimilarity index 100%\nrename from diffcore-delta.c\nrename to lib/diffcore-delta.c\ndiff --git a/diffcore-order.c b/lib/diffcore-order.c\nsimilarity index 100%\nrename from diffcore-order.c\nrename to lib/diffcore-order.c\ndiff --git a/diffcore-pickaxe.c b/lib/diffcore-pickaxe.c\nsimilarity index 100%\nrename from diffcore-pickaxe.c\nrename to lib/diffcore-pickaxe.c\ndiff --git a/diffcore-rename.c b/lib/diffcore-rename.c\nsimilarity index 100%\nrename from diffcore-rename.c\nrename to lib/diffcore-rename.c\ndiff --git a/dir.c b/lib/dir.c\nsimilarity index 100%\nrename from dir.c\nrename to lib/dir.c\ndiff --git a/editor.c b/lib/editor.c\nsimilarity index 100%\nrename from editor.c\nrename to lib/editor.c\ndiff --git a/entry.c b/lib/entry.c\nsimilarity index 100%\nrename from entry.c\nrename to lib/entry.c\ndiff --git a/environment.c b/lib/environment.c\nsimilarity index 100%\nrename from environment.c\nrename to lib/environment.c\ndiff --git a/exec_cmd.c b/lib/exec_cmd.c\nsimilarity index 100%\nrename from exec_cmd.c\nrename to lib/exec_cmd.c\ndiff --git a/fsck.c b/lib/fsck.c\nsimilarity index 100%\nrename from fsck.c\nrename to lib/fsck.c\ndiff --git a/gettext.c b/lib/gettext.c\nsimilarity index 100%\nrename from gettext.c\nrename to lib/gettext.c\ndiff --git a/graph.c b/lib/graph.c\nsimilarity index 100%\nrename from graph.c\nrename to lib/graph.c\ndiff --git a/grep.c b/lib/grep.c\nsimilarity index 100%\nrename from grep.c\nrename to lib/grep.c\ndiff --git a/hash.c b/lib/hash.c\nsimilarity index 100%\nrename from hash.c\nrename to lib/hash.c\ndiff --git a/help.c b/lib/help.c\nsimilarity index 100%\nrename from help.c\nrename to lib/help.c\ndiff --git a/hex.c b/lib/hex.c\nsimilarity index 100%\nrename from hex.c\nrename to lib/hex.c\ndiff --git a/ident.c b/lib/ident.c\nsimilarity index 100%\nrename from ident.c\nrename to lib/ident.c\ndiff --git a/levenshtein.c b/lib/levenshtein.c\nsimilarity index 100%\nrename from levenshtein.c\nrename to lib/levenshtein.c\ndiff --git a/list-objects.c b/lib/list-objects.c\nsimilarity index 100%\nrename from list-objects.c\nrename to lib/list-objects.c\ndiff --git a/ll-merge.c b/lib/ll-merge.c\nsimilarity index 100%\nrename from ll-merge.c\nrename to lib/ll-merge.c\ndiff --git a/lockfile.c b/lib/lockfile.c\nsimilarity index 100%\nrename from lockfile.c\nrename to lib/lockfile.c\ndiff --git a/log-tree.c b/lib/log-tree.c\nsimilarity index 100%\nrename from log-tree.c\nrename to lib/log-tree.c\ndiff --git a/mailmap.c b/lib/mailmap.c\nsimilarity index 100%\nrename from mailmap.c\nrename to lib/mailmap.c\ndiff --git a/match-trees.c b/lib/match-trees.c\nsimilarity index 100%\nrename from match-trees.c\nrename to lib/match-trees.c\ndiff --git a/merge-file.c b/lib/merge-file.c\nsimilarity index 100%\nrename from merge-file.c\nrename to lib/merge-file.c\ndiff --git a/merge-recursive.c b/lib/merge-recursive.c\nsimilarity index 100%\nrename from merge-recursive.c\nrename to lib/merge-recursive.c\ndiff --git a/name-hash.c b/lib/name-hash.c\nsimilarity index 100%\nrename from name-hash.c\nrename to lib/name-hash.c\ndiff --git a/notes-cache.c b/lib/notes-cache.c\nsimilarity index 100%\nrename from notes-cache.c\nrename to lib/notes-cache.c\ndiff --git a/notes-merge.c b/lib/notes-merge.c\nsimilarity index 100%\nrename from notes-merge.c\nrename to lib/notes-merge.c\ndiff --git a/notes.c b/lib/notes.c\nsimilarity index 100%\nrename from notes.c\nrename to lib/notes.c\ndiff --git a/object.c b/lib/object.c\nsimilarity index 100%\nrename from object.c\nrename to lib/object.c\ndiff --git a/pack-check.c b/lib/pack-check.c\nsimilarity index 100%\nrename from pack-check.c\nrename to lib/pack-check.c\ndiff --git a/pack-refs.c b/lib/pack-refs.c\nsimilarity index 100%\nrename from pack-refs.c\nrename to lib/pack-refs.c\ndiff --git a/pack-revindex.c b/lib/pack-revindex.c\nsimilarity index 100%\nrename from pack-revindex.c\nrename to lib/pack-revindex.c\ndiff --git a/pack-write.c b/lib/pack-write.c\nsimilarity index 100%\nrename from pack-write.c\nrename to lib/pack-write.c\ndiff --git a/pager.c b/lib/pager.c\nsimilarity index 100%\nrename from pager.c\nrename to lib/pager.c\ndiff --git a/parse-options.c b/lib/parse-options.c\nsimilarity index 100%\nrename from parse-options.c\nrename to lib/parse-options.c\ndiff --git a/patch-delta.c b/lib/patch-delta.c\nsimilarity index 100%\nrename from patch-delta.c\nrename to lib/patch-delta.c\ndiff --git a/patch-ids.c b/lib/patch-ids.c\nsimilarity index 100%\nrename from patch-ids.c\nrename to lib/patch-ids.c\ndiff --git a/path.c b/lib/path.c\nsimilarity index 100%\nrename from path.c\nrename to lib/path.c\ndiff --git a/pkt-line.c b/lib/pkt-line.c\nsimilarity index 100%\nrename from pkt-line.c\nrename to lib/pkt-line.c\ndiff --git a/preload-index.c b/lib/preload-index.c\nsimilarity index 100%\nrename from preload-index.c\nrename to lib/preload-index.c\ndiff --git a/pretty.c b/lib/pretty.c\nsimilarity index 100%\nrename from pretty.c\nrename to lib/pretty.c\ndiff --git a/progress.c b/lib/progress.c\nsimilarity index 100%\nrename from progress.c\nrename to lib/progress.c\ndiff --git a/quote.c b/lib/quote.c\nsimilarity index 100%\nrename from quote.c\nrename to lib/quote.c\ndiff --git a/reachable.c b/lib/reachable.c\nsimilarity index 100%\nrename from reachable.c\nrename to lib/reachable.c\ndiff --git a/read-cache.c b/lib/read-cache.c\nsimilarity index 100%\nrename from read-cache.c\nrename to lib/read-cache.c\ndiff --git a/reflog-walk.c b/lib/reflog-walk.c\nsimilarity index 100%\nrename from reflog-walk.c\nrename to lib/reflog-walk.c\ndiff --git a/refs.c b/lib/refs.c\nsimilarity index 100%\nrename from refs.c\nrename to lib/refs.c\ndiff --git a/remote.c b/lib/remote.c\nsimilarity index 100%\nrename from remote.c\nrename to lib/remote.c\ndiff --git a/replace_object.c b/lib/replace_object.c\nsimilarity index 100%\nrename from replace_object.c\nrename to lib/replace_object.c\ndiff --git a/rerere.c b/lib/rerere.c\nsimilarity index 100%\nrename from rerere.c\nrename to lib/rerere.c\ndiff --git a/resolve-undo.c b/lib/resolve-undo.c\nsimilarity index 100%\nrename from resolve-undo.c\nrename to lib/resolve-undo.c\ndiff --git a/revision.c b/lib/revision.c\nsimilarity index 100%\nrename from revision.c\nrename to lib/revision.c\ndiff --git a/run-command.c b/lib/run-command.c\nsimilarity index 100%\nrename from run-command.c\nrename to lib/run-command.c\ndiff --git a/server-info.c b/lib/server-info.c\nsimilarity index 100%\nrename from server-info.c\nrename to lib/server-info.c\ndiff --git a/setup.c b/lib/setup.c\nsimilarity index 100%\nrename from setup.c\nrename to lib/setup.c\ndiff --git a/sha1-array.c b/lib/sha1-array.c\nsimilarity index 100%\nrename from sha1-array.c\nrename to lib/sha1-array.c\ndiff --git a/sha1-lookup.c b/lib/sha1-lookup.c\nsimilarity index 100%\nrename from sha1-lookup.c\nrename to lib/sha1-lookup.c\ndiff --git a/sha1_file.c b/lib/sha1_file.c\nsimilarity index 100%\nrename from sha1_file.c\nrename to lib/sha1_file.c\ndiff --git a/sha1_name.c b/lib/sha1_name.c\nsimilarity index 100%\nrename from sha1_name.c\nrename to lib/sha1_name.c\ndiff --git a/shallow.c b/lib/shallow.c\nsimilarity index 100%\nrename from shallow.c\nrename to lib/shallow.c\ndiff --git a/sideband.c b/lib/sideband.c\nsimilarity index 100%\nrename from sideband.c\nrename to lib/sideband.c\ndiff --git a/sigchain.c b/lib/sigchain.c\nsimilarity index 100%\nrename from sigchain.c\nrename to lib/sigchain.c\ndiff --git a/strbuf.c b/lib/strbuf.c\nsimilarity index 100%\nrename from strbuf.c\nrename to lib/strbuf.c\ndiff --git a/string-list.c b/lib/string-list.c\nsimilarity index 100%\nrename from string-list.c\nrename to lib/string-list.c\ndiff --git a/submodule.c b/lib/submodule.c\nsimilarity index 100%\nrename from submodule.c\nrename to lib/submodule.c\ndiff --git a/symlinks.c b/lib/symlinks.c\nsimilarity index 100%\nrename from symlinks.c\nrename to lib/symlinks.c\ndiff --git a/tag.c b/lib/tag.c\nsimilarity index 100%\nrename from tag.c\nrename to lib/tag.c\ndiff --git a/thread-utils.c b/lib/thread-utils.c\nsimilarity index 100%\nrename from thread-utils.c\nrename to lib/thread-utils.c\ndiff --git a/trace.c b/lib/trace.c\nsimilarity index 100%\nrename from trace.c\nrename to lib/trace.c\ndiff --git a/transport-helper.c b/lib/transport-helper.c\nsimilarity index 100%\nrename from transport-helper.c\nrename to lib/transport-helper.c\ndiff --git a/transport.c b/lib/transport.c\nsimilarity index 100%\nrename from transport.c\nrename to lib/transport.c\ndiff --git a/tree-diff.c b/lib/tree-diff.c\nsimilarity index 100%\nrename from tree-diff.c\nrename to lib/tree-diff.c\ndiff --git a/tree-walk.c b/lib/tree-walk.c\nsimilarity index 100%\nrename from tree-walk.c\nrename to lib/tree-walk.c\ndiff --git a/tree.c b/lib/tree.c\nsimilarity index 100%\nrename from tree.c\nrename to lib/tree.c\ndiff --git a/unpack-trees.c b/lib/unpack-trees.c\nsimilarity index 100%\nrename from unpack-trees.c\nrename to lib/unpack-trees.c\ndiff --git a/url.c b/lib/url.c\nsimilarity index 100%\nrename from url.c\nrename to lib/url.c\ndiff --git a/usage.c b/lib/usage.c\nsimilarity index 100%\nrename from usage.c\nrename to lib/usage.c\ndiff --git a/userdiff.c b/lib/userdiff.c\nsimilarity index 100%\nrename from userdiff.c\nrename to lib/userdiff.c\ndiff --git a/utf8.c b/lib/utf8.c\nsimilarity index 100%\nrename from utf8.c\nrename to lib/utf8.c\ndiff --git a/walker.c b/lib/walker.c\nsimilarity index 100%\nrename from walker.c\nrename to lib/walker.c\ndiff --git a/wrapper.c b/lib/wrapper.c\nsimilarity index 100%\nrename from wrapper.c\nrename to lib/wrapper.c\ndiff --git a/write_or_die.c b/lib/write_or_die.c\nsimilarity index 100%\nrename from write_or_die.c\nrename to lib/write_or_die.c\ndiff --git a/ws.c b/lib/ws.c\nsimilarity index 100%\nrename from ws.c\nrename to lib/ws.c\ndiff --git a/wt-status.c b/lib/wt-status.c\nsimilarity index 100%\nrename from wt-status.c\nrename to lib/wt-status.c\ndiff --git a/xdiff-interface.c b/lib/xdiff-interface.c\nsimilarity index 100%\nrename from xdiff-interface.c\nrename to lib/xdiff-interface.c\ndiff --git a/zlib.c b/lib/zlib.c\nsimilarity index 100%\nrename from zlib.c\nrename to lib/zlib.c\n-- \n1.7.5.3\n"},{"id":"170272","messageId":"BANLkTimjixOT=j9Xf=Ti-04cRw2noC0NiQ@mail.gmail.com","threadId":"27659","inReplyTo":"alpine.LNX.2.00.1106192014410.41113@linux.foleyremote.com","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2011-06-20T01:06:24Z","receivedAt":"2011-06-20T01:06:24Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"On Sun, Jun 19, 2011 at 17:50, Peter Foley <pefoley2@verizon.net> wrote:\n> This patch tries to organize the git source tree by moving the files which\n> make up libgit.a to a lib subdirectory.\n> Before this patch the toplevel source directory contained 285 files.\n> After this patch the root directory will contain 167 files and\n> the lib subdirectory will contain 119 files\n...\n\nThanks. But why is this amount of churn necessary or being\nrecommended? What problem does this address? Is that worth the pain\nthis puts on every other in-flight change that is still being\ndeveloped, or is already in the review pipeline?\n\n-- \nShawn.\n"},{"id":"170273","messageId":"20110620011245.GA25836@elie","threadId":"27659","inReplyTo":"alpine.LNX.2.00.1106192014410.41113@linux.foleyremote.com","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-06-20T01:12:45Z","receivedAt":"2011-06-20T01:12:45Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nPeter Foley wrote:\n\n> This patch tries to organize the git source tree by moving the files which \n> make up libgit.a to a lib subdirectory.\n> Before this patch the toplevel source directory contained 285 files. \n> After this patch the root directory will contain 167 files and \n> the lib subdirectory will contain 119 files\n>\n> Signed-off-by: Peter Foley <pefoley2@verizon.net>\n> ---\n>  Makefile                                     |  258 +++++++++++++-------------\n>  abspath.c => lib/abspath.c                   |    0\n>  advice.c => lib/advice.c                     |    0\n[...]\n>  zlib.c => lib/zlib.c                         |    0\n\nThanks for a reminder.  I had some vague hope that some \"log --follow\"\nimprovements[0] would arrive to make commands like \"git log --follow\nlib/branch.c\" less painful, but that doesn't seem to be happening.\nIt's probably best not to wait forever.\n\nAs for the patch itself: my main thought is that I prefer to see\n\"branch.c\" and \"branch.h\" in the same directory.  Aside from that, I\nlike it.  See [1] for some related discussion.\n\nRegards,\nJonathan\n\n[0] https://git.wiki.kernel.org/index.php/SoC2011Ideas#Better_git_log_--follow_support\n[1] http://thread.gmane.org/gmane.comp.version-control.git/166424/focus=167154\n"},{"id":"170274","messageId":"alpine.LNX.2.00.1106192111250.18284@linux.foleyremote.com","threadId":"27659","inReplyTo":"BANLkTimjixOT=j9Xf=Ti-04cRw2noC0NiQ@mail.gmail.com","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Peter Foley","fromEmail":"pefoley2@verizon.net","sentAt":"2011-06-20T01:21:42Z","receivedAt":"2011-06-20T01:21:42Z","isPatch":true,"sender":{"key":"pefoley2@verizon.net","avatar":null},"body":"\n\nOn Sun, 19 Jun 2011, Shawn Pearce wrote:\n\n> On Sun, Jun 19, 2011 at 17:50, Peter Foley <pefoley2@verizon.net> wrote:\n> > This patch tries to organize the git source tree by moving the files which\n> > make up libgit.a to a lib subdirectory.\n> > Before this patch the toplevel source directory contained 285 files.\n> > After this patch the root directory will contain 167 files and\n> > the lib subdirectory will contain 119 files\n> ...\n> \n> Thanks. But why is this amount of churn necessary or being\n> recommended? What problem does this address? Is that worth the pain\n> this puts on every other in-flight change that is still being\n> developed, or is already in the review pipeline?\n> \n> -- \n> Shawn.\n> \n\nThe basic idea is to organize the git source directory more than it is \nright now (a flat directory with all the source files at the toplevel).\nMoving the contents of libgit.a seemed to be a logical way to start.\n \nThanks,\n\nPeter\n"},{"id":"170278","messageId":"7vd3i9dow4.fsf@alter.siamese.dyndns.org","threadId":"27659","inReplyTo":"BANLkTimjixOT=j9Xf=Ti-04cRw2noC0NiQ@mail.gmail.com","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-06-20T05:59:23Z","receivedAt":"2011-06-20T05:59:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shawn Pearce <spearce@spearce.org> writes:\n\n> ... But why is this amount of churn necessary or being\n> recommended? What problem does this address? Is that worth the pain\n> this puts on every other in-flight change that is still being\n> developed, or is already in the review pipeline?\n\nNo reason and not recommended; nothing; not worth.\n\nEspecially during the pre-release freeze.\n"},{"id":"170280","messageId":"20110620064713.GA27992@elie","threadId":"27659","inReplyTo":"7vd3i9dow4.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-06-20T06:47:13Z","receivedAt":"2011-06-20T06:47:13Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Junio C Hamano wrote:\n> Shawn Pearce <spearce@spearce.org> writes:\n\n>> ... But why is this amount of churn necessary or being\n>> recommended? What problem does this address? Is that worth the pain\n>> this puts on every other in-flight change that is still being\n>> developed, or is already in the review pipeline?\n>\n> No reason and not recommended; nothing; not worth.\n>\n> Especially during the pre-release freeze.\n\nIt's unlikely the patch would be cooked by the time there is a\nrelease, or even in the moments of quiet after that.  If this were a\npatch intended for immediate inclusion, the timing would be\nunfortunate, but for an RFC I wouldn't have expected the release\ntiming to be very relevant.\n\nA better thought out version of this patch, meaning timed\nappropriately and taking into account the comments that came up the\nlast times the subject was discussed, would imho be a good thing.\nPart of thinking it through is to consider the effect on in-flight\npatches and to consider whether it's possible to mitigate that.\n\nIn other words, I think Shawn's questions get right to the point.\nI hope the above answers --- which do seem to correctly reflect the\nstate of things in absence of such thinking --- will not dissuade\nsomeone from finding a good answer.\n\nMore prior discussion for the sort of masochistic person who wants to\nwork on it: [1].  I admit I can imagine easier tasks. :)\n\nJust my two cents,\nJonathan\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/165748/focus=165801\n"},{"id":"170298","messageId":"BANLkTimo71oftT2h4tXJhX7=zqjZipV3qw@mail.gmail.com","threadId":"27659","inReplyTo":"BANLkTimjixOT=j9Xf=Ti-04cRw2noC0NiQ@mail.gmail.com","subject":"Re: [PATCH/RFC] Move contents of libgit.a to lib subdirectory","fromName":"Thiago Farina","fromEmail":"tfransosi@gmail.com","sentAt":"2011-06-20T14:55:58Z","receivedAt":"2011-06-20T14:55:58Z","isPatch":true,"sender":{"key":"tfransosi@gmail.com","avatar":"https://avatars.githubusercontent.com/u/970071?v=4"},"body":"On Sun, Jun 19, 2011 at 10:06 PM, Shawn Pearce <spearce@spearce.org> wrote:\n> On Sun, Jun 19, 2011 at 17:50, Peter Foley <pefoley2@verizon.net> wrote:\n>> This patch tries to organize the git source tree by moving the files which\n>> make up libgit.a to a lib subdirectory.\n>> Before this patch the toplevel source directory contained 285 files.\n>> After this patch the root directory will contain 167 files and\n>> the lib subdirectory will contain 119 files\n> ...\n>\n> Thanks. But why is this amount of churn necessary or being\n> recommended?\nIf that becomes from time to time as Jonathan pointed out, probably it\nmeans that other people thinks the physical layout of the source files\ncould be improved.\n\n> What problem does this address?\nI think it's the big number of source files at the toplevel directory.\n"}]}