{"thread":{"id":"27635","subject":"[PATCH] Fix typo: existant->existent","startedAt":"2011-06-16T11:26:35Z","lastAt":"2011-06-16T13:42:48Z","messageCount":4,"participants":["Dmitry Ivankov","Carlos Martín Nieto"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"170124","messageId":"1308223595-6319-1-git-send-email-divanorama@gmail.com","threadId":"27635","inReplyTo":null,"subject":"[PATCH] Fix typo: existant->existent","fromName":"Dmitry Ivankov","fromEmail":"divanorama@gmail.com","sentAt":"2011-06-16T11:26:35Z","receivedAt":"2011-06-16T11:26:35Z","isPatch":true,"sender":{"key":"divanorama@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158999?v=4"},"body":"refs.c had a error message \"Trying to write ref with nonexistent object\".\nAnd no tests relied on the wrong spelling.\nAlso typo was present in some test scripts internals, these tests still pass.\n\nSigned-off-by: Dmitry Ivankov <divanorama@gmail.com>\n---\nThis is a reroll of previously sent series \nhttp://thread.gmane.org/gmane.comp.version-control.git/174910/focus=174909, git-gui patch will go separately.\nExistant is a valid word in French, so in po/fr it's ok.\n\n refs.c                        |    2 +-\n t/t3903-stash.sh              |    2 +-\n t/t4203-mailmap.sh            |    2 +-\n t/t4205-log-pretty-formats.sh |    2 +-\n t/t5506-remote-groups.sh      |    6 +++---\n t/t5516-fetch-push.sh         |   10 +++++-----\n t/t9300-fast-import.sh        |    4 ++--\n 7 files changed, 14 insertions(+), 14 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex e3c0511..b10419a 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -1451,7 +1451,7 @@ int write_ref_sha1(struct ref_lock *lock,\n \t}\n \to = parse_object(sha1);\n \tif (!o) {\n-\t\terror(\"Trying to write ref %s with nonexistant object %s\",\n+\t\terror(\"Trying to write ref %s with nonexistent object %s\",\n \t\t\tlock->ref_name, sha1_to_hex(sha1));\n \t\tunlock_ref(lock);\n \t\treturn -1;\ndiff --git a/t/t3903-stash.sh b/t/t3903-stash.sh\nindex 5c72540..7197aae 100755\n--- a/t/t3903-stash.sh\n+++ b/t/t3903-stash.sh\n@@ -536,7 +536,7 @@ test_expect_success 'stash pop - fail early if specified stash is not a stash re\n \tgit reset --hard HEAD\n '\n \n-test_expect_success 'ref with non-existant reflog' '\n+test_expect_success 'ref with non-existent reflog' '\n \tgit stash clear &&\n \techo bar5 > file &&\n \techo bar6 > file2 &&\ndiff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh\nindex e818de6..1f182f6 100755\n--- a/t/t4203-mailmap.sh\n+++ b/t/t4203-mailmap.sh\n@@ -94,7 +94,7 @@ nick1 (1):\n \n EOF\n \n-test_expect_success 'mailmap.file non-existant' '\n+test_expect_success 'mailmap.file non-existent' '\n \trm internal_mailmap/.mailmap &&\n \trmdir internal_mailmap &&\n \tgit shortlog HEAD >actual &&\ndiff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh\nindex cb9f2bd..2ae9faa 100755\n--- a/t/t4205-log-pretty-formats.sh\n+++ b/t/t4205-log-pretty-formats.sh\n@@ -45,7 +45,7 @@ test_expect_success 'alias user-defined tformat' '\n \ttest_cmp expected actual\n '\n \n-test_expect_success 'alias non-existant format' '\n+test_expect_success 'alias non-existent format' '\n \tgit config pretty.test-alias format-that-will-never-exist &&\n \ttest_must_fail git log --pretty=test-alias\n '\ndiff --git a/t/t5506-remote-groups.sh b/t/t5506-remote-groups.sh\nindex b7b7dda..530b016 100755\n--- a/t/t5506-remote-groups.sh\n+++ b/t/t5506-remote-groups.sh\n@@ -43,10 +43,10 @@ test_expect_success 'no group updates all' '\n \trepo_fetched two\n '\n \n-test_expect_success 'nonexistant group produces error' '\n-\tmark nonexistant &&\n+test_expect_success 'nonexistent group produces error' '\n+\tmark nonexistent &&\n \tupdate_repos &&\n-\ttest_must_fail git remote update nonexistant &&\n+\ttest_must_fail git remote update nonexistent &&\n \t! repo_fetched one &&\n \t! repo_fetched two\n '\ndiff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh\nindex d73731e..3abb290 100755\n--- a/t/t5516-fetch-push.sh\n+++ b/t/t5516-fetch-push.sh\n@@ -367,7 +367,7 @@ test_expect_success 'push with colon-less refspec (4)' '\n \n '\n \n-test_expect_success 'push head with non-existant, incomplete dest' '\n+test_expect_success 'push head with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit push testrepo master:branch &&\n@@ -375,7 +375,7 @@ test_expect_success 'push head with non-existant, incomplete dest' '\n \n '\n \n-test_expect_success 'push tag with non-existant, incomplete dest' '\n+test_expect_success 'push tag with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit tag -f v1.0 &&\n@@ -384,14 +384,14 @@ test_expect_success 'push tag with non-existant, incomplete dest' '\n \n '\n \n-test_expect_success 'push sha1 with non-existant, incomplete dest' '\n+test_expect_success 'push sha1 with non-existent, incomplete dest' '\n \n \tmk_test &&\n \ttest_must_fail git push testrepo `git rev-parse master`:foo\n \n '\n \n-test_expect_success 'push ref expression with non-existant, incomplete dest' '\n+test_expect_success 'push ref expression with non-existent, incomplete dest' '\n \n \tmk_test &&\n \ttest_must_fail git push testrepo master^:branch\n@@ -436,7 +436,7 @@ test_expect_success 'push with +HEAD' '\n \n '\n \n-test_expect_success 'push HEAD with non-existant, incomplete dest' '\n+test_expect_success 'push HEAD with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit checkout master &&\ndiff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh\nindex 6b1ba6c..2a53640 100755\n--- a/t/t9300-fast-import.sh\n+++ b/t/t9300-fast-import.sh\n@@ -1893,7 +1893,7 @@ test_expect_success \\\n     test_cmp marks.out marks.new'\n \n cat >input <<EOF\n-feature import-marks=nonexistant.marks\n+feature import-marks=nonexistent.marks\n feature export-marks=marks.new\n EOF\n \n@@ -1904,7 +1904,7 @@ test_expect_success \\\n \n \n cat >input <<EOF\n-feature import-marks=nonexistant.marks\n+feature import-marks=nonexistent.marks\n feature export-marks=combined.marks\n EOF\n \n-- \n1.7.3.4\n"},{"id":"170127","messageId":"20110616131938.GA7751@centaur.lab.cmartin.tk","threadId":"27635","inReplyTo":"1308223595-6319-1-git-send-email-divanorama@gmail.com","subject":"Re: [PATCH] Fix typo: existant->existent","fromName":"Carlos Martín Nieto","fromEmail":"carlos@cmartin.tk","sentAt":"2011-06-16T13:19:40Z","receivedAt":"2011-06-16T13:19:40Z","isPatch":true,"sender":{"key":"carlos@cmartin.tk","avatar":"https://gravatar.com/avatar/956bfe8371004f2960febf266a6af789f60cdc01fbae48bb151ad4c9b532c3a2?d=mp&s=160"},"body":"On Thu, Jun 16, 2011 at 05:26:35PM +0600, Dmitry Ivankov wrote:\n> refs.c had a error message \"Trying to write ref with nonexistent object\".\n\nFrom the patch, ITYM to say \"with nonexistant object\" here\n\nCheers,\n   cmn\n-- \nCarlos Martín Nieto | http://cmartin.tk\n\n\"¿Cómo voy a decir bobadas si soy mudo?\" -- CACHAI\n"},{"id":"170129","messageId":"BANLkTikMrtHSpMTSO2_mL_RDGBUL2cO0ow@mail.gmail.com","threadId":"27635","inReplyTo":"20110616131938.GA7751@centaur.lab.cmartin.tk","subject":"Re: [PATCH] Fix typo: existant->existent","fromName":"Dmitry Ivankov","fromEmail":"divanorama@gmail.com","sentAt":"2011-06-16T13:28:11Z","receivedAt":"2011-06-16T13:28:11Z","isPatch":true,"sender":{"key":"divanorama@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158999?v=4"},"body":"On Thu, Jun 16, 2011 at 7:19 PM, Carlos Martín Nieto <carlos@cmartin.tk> wrote:\n> On Thu, Jun 16, 2011 at 05:26:35PM +0600, Dmitry Ivankov wrote:\n>> refs.c had a error message \"Trying to write ref with nonexistent object\".\n>\n> From the patch, ITYM to say \"with nonexistant object\" here\nOops, that's true, thanks for spotting.\n\n>\n> Cheers,\n>   cmn\n> --\n> Carlos Martín Nieto | http://cmartin.tk\n>\n> \"¿Cómo voy a decir bobadas si soy mudo?\" -- CACHAI\n>\n"},{"id":"170132","messageId":"1308231768-11817-1-git-send-email-divanorama@gmail.com","threadId":"27635","inReplyTo":"1308223595-6319-1-git-send-email-divanorama@gmail.com","subject":"[PATCH] Fix typo: existant->existent","fromName":"Dmitry Ivankov","fromEmail":"divanorama@gmail.com","sentAt":"2011-06-16T13:42:48Z","receivedAt":"2011-06-16T13:42:48Z","isPatch":true,"sender":{"key":"divanorama@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158999?v=4"},"body":"refs.c had a error message \"Trying to write ref with nonexistant object\".\nAnd no tests relied on the wrong spelling.\nAlso typo was present in some test scripts internals, these tests still pass.\n\nSigned-off-by: Dmitry Ivankov <divanorama@gmail.com>\n---\nFixup the commit log. Error message quoted should be the original one, with the typo.\n\n refs.c                        |    2 +-\n t/t3903-stash.sh              |    2 +-\n t/t4203-mailmap.sh            |    2 +-\n t/t4205-log-pretty-formats.sh |    2 +-\n t/t5506-remote-groups.sh      |    6 +++---\n t/t5516-fetch-push.sh         |   10 +++++-----\n t/t9300-fast-import.sh        |    4 ++--\n 7 files changed, 14 insertions(+), 14 deletions(-)\n\ndiff --git a/refs.c b/refs.c\nindex e3c0511..b10419a 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -1451,7 +1451,7 @@ int write_ref_sha1(struct ref_lock *lock,\n \t}\n \to = parse_object(sha1);\n \tif (!o) {\n-\t\terror(\"Trying to write ref %s with nonexistant object %s\",\n+\t\terror(\"Trying to write ref %s with nonexistent object %s\",\n \t\t\tlock->ref_name, sha1_to_hex(sha1));\n \t\tunlock_ref(lock);\n \t\treturn -1;\ndiff --git a/t/t3903-stash.sh b/t/t3903-stash.sh\nindex 5c72540..7197aae 100755\n--- a/t/t3903-stash.sh\n+++ b/t/t3903-stash.sh\n@@ -536,7 +536,7 @@ test_expect_success 'stash pop - fail early if specified stash is not a stash re\n \tgit reset --hard HEAD\n '\n \n-test_expect_success 'ref with non-existant reflog' '\n+test_expect_success 'ref with non-existent reflog' '\n \tgit stash clear &&\n \techo bar5 > file &&\n \techo bar6 > file2 &&\ndiff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh\nindex e818de6..1f182f6 100755\n--- a/t/t4203-mailmap.sh\n+++ b/t/t4203-mailmap.sh\n@@ -94,7 +94,7 @@ nick1 (1):\n \n EOF\n \n-test_expect_success 'mailmap.file non-existant' '\n+test_expect_success 'mailmap.file non-existent' '\n \trm internal_mailmap/.mailmap &&\n \trmdir internal_mailmap &&\n \tgit shortlog HEAD >actual &&\ndiff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh\nindex cb9f2bd..2ae9faa 100755\n--- a/t/t4205-log-pretty-formats.sh\n+++ b/t/t4205-log-pretty-formats.sh\n@@ -45,7 +45,7 @@ test_expect_success 'alias user-defined tformat' '\n \ttest_cmp expected actual\n '\n \n-test_expect_success 'alias non-existant format' '\n+test_expect_success 'alias non-existent format' '\n \tgit config pretty.test-alias format-that-will-never-exist &&\n \ttest_must_fail git log --pretty=test-alias\n '\ndiff --git a/t/t5506-remote-groups.sh b/t/t5506-remote-groups.sh\nindex b7b7dda..530b016 100755\n--- a/t/t5506-remote-groups.sh\n+++ b/t/t5506-remote-groups.sh\n@@ -43,10 +43,10 @@ test_expect_success 'no group updates all' '\n \trepo_fetched two\n '\n \n-test_expect_success 'nonexistant group produces error' '\n-\tmark nonexistant &&\n+test_expect_success 'nonexistent group produces error' '\n+\tmark nonexistent &&\n \tupdate_repos &&\n-\ttest_must_fail git remote update nonexistant &&\n+\ttest_must_fail git remote update nonexistent &&\n \t! repo_fetched one &&\n \t! repo_fetched two\n '\ndiff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh\nindex d73731e..3abb290 100755\n--- a/t/t5516-fetch-push.sh\n+++ b/t/t5516-fetch-push.sh\n@@ -367,7 +367,7 @@ test_expect_success 'push with colon-less refspec (4)' '\n \n '\n \n-test_expect_success 'push head with non-existant, incomplete dest' '\n+test_expect_success 'push head with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit push testrepo master:branch &&\n@@ -375,7 +375,7 @@ test_expect_success 'push head with non-existant, incomplete dest' '\n \n '\n \n-test_expect_success 'push tag with non-existant, incomplete dest' '\n+test_expect_success 'push tag with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit tag -f v1.0 &&\n@@ -384,14 +384,14 @@ test_expect_success 'push tag with non-existant, incomplete dest' '\n \n '\n \n-test_expect_success 'push sha1 with non-existant, incomplete dest' '\n+test_expect_success 'push sha1 with non-existent, incomplete dest' '\n \n \tmk_test &&\n \ttest_must_fail git push testrepo `git rev-parse master`:foo\n \n '\n \n-test_expect_success 'push ref expression with non-existant, incomplete dest' '\n+test_expect_success 'push ref expression with non-existent, incomplete dest' '\n \n \tmk_test &&\n \ttest_must_fail git push testrepo master^:branch\n@@ -436,7 +436,7 @@ test_expect_success 'push with +HEAD' '\n \n '\n \n-test_expect_success 'push HEAD with non-existant, incomplete dest' '\n+test_expect_success 'push HEAD with non-existent, incomplete dest' '\n \n \tmk_test &&\n \tgit checkout master &&\ndiff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh\nindex 6b1ba6c..2a53640 100755\n--- a/t/t9300-fast-import.sh\n+++ b/t/t9300-fast-import.sh\n@@ -1893,7 +1893,7 @@ test_expect_success \\\n     test_cmp marks.out marks.new'\n \n cat >input <<EOF\n-feature import-marks=nonexistant.marks\n+feature import-marks=nonexistent.marks\n feature export-marks=marks.new\n EOF\n \n@@ -1904,7 +1904,7 @@ test_expect_success \\\n \n \n cat >input <<EOF\n-feature import-marks=nonexistant.marks\n+feature import-marks=nonexistent.marks\n feature export-marks=combined.marks\n EOF\n \n-- \n1.7.3.4\n"}]}