{"thread":{"id":"27566","subject":"[PATCH] t3703: skip more tests using colons in file names on Windows","startedAt":"2011-06-07T13:43:55Z","lastAt":"2011-06-08T10:44:01Z","messageCount":3,"participants":["Alex Riesen","Johannes Sixt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"169445","messageId":"BANLkTik3K2GVZ5rzegYSXRrvROU_bzBdVw@mail.gmail.com","threadId":"27566","inReplyTo":null,"subject":"[PATCH] t3703: skip more tests using colons in file names on Windows","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2011-06-07T13:43:55Z","receivedAt":"2011-06-07T13:43:55Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Use the same test and prerequisite as introduced in similar\nfix in 650af7ae8bdf92bd92df2.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n\nWhy didn't Johannes noticed it, I wonder. The failing test was\nhere all the time.\n\nOTOH, I update my Windows repo very irregularly lately, may be\nit is the same with Johannes. Windows is just not very friendly\ndevelopment environment (more of a breaking environment).\n\n t/t3703-add-magic-pathspec.sh |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\n\ndiff --git a/t/t3703-add-magic-pathspec.sh b/t/t3703-add-magic-pathspec.sh\nindex e508246..5115de7 100755\n--- a/t/t3703-add-magic-pathspec.sh\n+++ b/t/t3703-add-magic-pathspec.sh\n@@ -38,17 +38,17 @@ cat >expected <<EOF\n add 'sub/foo'\n EOF\n\n-test_expect_success 'a file with the same (long) magic name exists' '\n-\t: >\":(icase)ha\" &&\n-\ttest_must_fail git add -n \":(icase)ha\" &&\n-\tgit add -n \"./:(icase)ha\"\n-'\n-\n if mkdir \":\" 2>/dev/null\n then\n \ttest_set_prereq COLON_DIR\n fi\n\n+test_expect_success COLON_DIR 'a file with the same (long) magic name exists' '\n+\t: >\":(icase)ha\" &&\n+\ttest_must_fail git add -n \":(icase)ha\" &&\n+\tgit add -n \"./:(icase)ha\"\n+'\n+\n test_expect_success COLON_DIR 'a file with the same (short) magic\nname exists' '\n \t: >\":/bar\" &&\n \ttest_must_fail git add -n :/bar &&\n-- \n1.7.5.1.407.g53f4f\n\n\nFrom bca3fa7df30b946841bd05d6ce7aac239721c097 Mon Sep 17 00:00:00 2001\nFrom: Alex Riesen <raa.lkml@gmail.com>\nDate: Tue, 7 Jun 2011 11:49:44 +0200\nSubject: [PATCH] t3703: skip more tests using colons in file names on Windows\n\nUse the same test and prerequisite as introduced in similar\nfix in 650af7ae8bdf92bd92df2.\n\nSigned-off-by: Alex Riesen <raa.lkml@gmail.com>\n---\n t/t3703-add-magic-pathspec.sh |   12 ++++++------\n 1 files changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t3703-add-magic-pathspec.sh b/t/t3703-add-magic-pathspec.sh\nindex e508246..5115de7 100755\n--- a/t/t3703-add-magic-pathspec.sh\n+++ b/t/t3703-add-magic-pathspec.sh\n@@ -38,17 +38,17 @@ cat >expected <<EOF\n add 'sub/foo'\n EOF\n \n-test_expect_success 'a file with the same (long) magic name exists' '\n-\t: >\":(icase)ha\" &&\n-\ttest_must_fail git add -n \":(icase)ha\" &&\n-\tgit add -n \"./:(icase)ha\"\n-'\n-\n if mkdir \":\" 2>/dev/null\n then\n \ttest_set_prereq COLON_DIR\n fi\n \n+test_expect_success COLON_DIR 'a file with the same (long) magic name exists' '\n+\t: >\":(icase)ha\" &&\n+\ttest_must_fail git add -n \":(icase)ha\" &&\n+\tgit add -n \"./:(icase)ha\"\n+'\n+\n test_expect_success COLON_DIR 'a file with the same (short) magic name exists' '\n \t: >\":/bar\" &&\n \ttest_must_fail git add -n :/bar &&\n-- \n1.7.5.1.407.g53f4f\n\n"},{"id":"169534","messageId":"4DEF152C.5060005@viscovery.net","threadId":"27566","inReplyTo":"BANLkTik3K2GVZ5rzegYSXRrvROU_bzBdVw@mail.gmail.com","subject":"Re: [PATCH] t3703: skip more tests using colons in file names on Windows","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2011-06-08T06:22:36Z","receivedAt":"2011-06-08T06:22:36Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 6/7/2011 15:43, schrieb Alex Riesen:\n> Use the same test and prerequisite as introduced in similar\n> fix in 650af7ae8bdf92bd92df2.\n> \n> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>\n> ---\n> \n> Why didn't Johannes noticed it, I wonder. The failing test was\n> here all the time.\n\nGood catch! Here's the explanation:\n\n> -test_expect_success 'a file with the same (long) magic name exists' '\n> -\t: >\":(icase)ha\" &&\n\n\":foo\" is the name of an alternate data stream on the current directory.\nBash can successfully open and write such a \"file\". (But there is no way\nto list it, even though test -f detects its existence.)\n\n> -\ttest_must_fail git add -n \":(icase)ha\" &&\n\nThis 'git add' fails, either for the intended reason, or because regular\ndirectory listing functions do not detect the alternate data stream; I do\nnot know.\n\n> -\tgit add -n \"./:(icase)ha\"\n\nThis obviously succeeds because a regular open() call can open the\nalternate data stream just like any file.\n\nTherefore, the test passes. This is on Windows XP with NTFS.\n\n-- Hannes\n"},{"id":"169591","messageId":"BANLkTikL-cBw95RMqcU7-B6mL0qfTVQ-5A@mail.gmail.com","threadId":"27566","inReplyTo":"4DEF152C.5060005@viscovery.net","subject":"Re: [PATCH] t3703: skip more tests using colons in file names on Windows","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2011-06-08T10:44:01Z","receivedAt":"2011-06-08T10:44:01Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Jun 8, 2011 at 08:22, Johannes Sixt <j.sixt@viscovery.net> wrote:\n>> -test_expect_success 'a file with the same (long) magic name exists' '\n>> -     : >\":(icase)ha\" &&\n>\n> \":foo\" is the name of an alternate data stream on the current directory.\n\nAh, right. Forgot about that \"feature\". For some reasons, Cygwin does not\nallow use of alternative data streams on \".\" or \"\" (zero-length string).\n\n> Therefore, the test passes. This is on Windows XP with NTFS.\n\nSame here, just under Cygwin.\n"}]}