{"thread":{"id":"27490","subject":"Documentation doesn't build anymore on old asciidoc due to i18n series","startedAt":"2011-05-28T11:40:22Z","lastAt":"2011-05-30T08:09:41Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"168910","messageId":"BANLkTikjfyxAzLu2e5aJFVhgKq8UBiJAQw@mail.gmail.com","threadId":"27490","inReplyTo":null,"subject":"Documentation doesn't build anymore on old asciidoc due to i18n series","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-05-28T11:40:22Z","receivedAt":"2011-05-28T11:40:22Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"I can submit a patch for this later, just thought I'd note it and\nsolicit feedback on the best solution to this.\n\nOn my Debian box with asciidoc 8.6.4 Git builds just fine from master.\n\nBut on a Centos 5.5 box with asciidoc 8.2.5 I get:\n\n    rm -f git-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.html && \\\n            asciidoc -b xhtml11 -d manpage -f asciidoc.conf \\\n                     -a asciidoc7compatible -a no-inline-literal -a\ngit-asciidoc-no-roff -agit_version=1.7.5.3.367.ga9930 -o\ngit-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.txt && \\\n            mv git-sh-i18n--envsubst.html+ git-sh-i18n--envsubst.html\n    ERROR: git-sh-i18n--envsubst.txt: line 9: second section must be\nnamed SYNOPSIS\n    make[1]: *** [git-sh-i18n--envsubst.html] Error 1\n\nThe solution is obvious: just add a SYNOPSIS section for\nconsistency. I'll do that later, unless we want to provide some option\n(which old asciidoc may or may not support) to not have a SYNOPSIS\nthere, which we arguably can just omit for purely internal tooling\nlike this.\n\nI'll submit patches soon for adding a SYNOPSIS unless we want to go\nthat route.\n"},{"id":"168938","messageId":"1306666835-8978-1-git-send-email-avarab@gmail.com","threadId":"27490","inReplyTo":"BANLkTikjfyxAzLu2e5aJFVhgKq8UBiJAQw@mail.gmail.com","subject":"[PATCH] git-sh-i18n--envsubst: add SYNOPSIS section to the documentation","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-05-29T11:00:35Z","receivedAt":"2011-05-29T11:00:35Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the documentation for the git-sh-i18n--envsubst program to\ninclude a SYNOPSIS section. Include the invocation of the program from\ngit-sh-i18n.sh.\n\nNot having a SYNOPSIS section caused the \"doc\" target to fail on\nCentos 5.5 with asciidoc 8.2.5, while building with 8.6.4 on Debian\nworks just fine.\n\nThe relevant error was:\n\n    ERROR: git-sh-i18n--envsubst.txt: line 9: second section must be named SYNOPSIS\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Documentation/git-sh-i18n--envsubst.txt |   10 ++++++++++\n 1 files changed, 10 insertions(+), 0 deletions(-)\n\ndiff --git a/Documentation/git-sh-i18n--envsubst.txt b/Documentation/git-sh-i18n--envsubst.txt\nindex f5bbf77..61e4c08 100644\n--- a/Documentation/git-sh-i18n--envsubst.txt\n+++ b/Documentation/git-sh-i18n--envsubst.txt\n@@ -5,6 +5,16 @@ NAME\n ----\n git-sh-i18n--envsubst - Git's own envsubst(1) for i18n fallbacks\n \n+SYNOPSIS\n+--------\n+[verse]\n+eval_gettext () {\n+\tprintf \"%s\" \"$1\" | (\n+\t\texport PATH $('git sh-i18n--envsubst' --variables \"$1\");\n+\t\t'git sh-i18n--envsubst' \"$1\"\n+\t)\n+}\n+\n DESCRIPTION\n -----------\n \n-- \n1.7.5.1\n"},{"id":"168980","messageId":"7vaae4obi2.fsf@alter.siamese.dyndns.org","threadId":"27490","inReplyTo":"1306666835-8978-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] git-sh-i18n--envsubst: add SYNOPSIS section to the documentation","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-05-30T08:09:41Z","receivedAt":"2011-05-30T08:09:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:\n\n> Not having a SYNOPSIS section caused the \"doc\" target to fail on\n> Centos 5.5 with asciidoc 8.2.5, while building with 8.6.4 on Debian\n> works just fine.\n\nSo does FC13 and FC15, both of which has 8.4.5.\n\nWill queue; thanks.\n"}]}