{"thread":{"id":"27465","subject":"[PATCH] plug a DIR buffer leak in rerere.c","startedAt":"2011-05-26T13:55:50Z","lastAt":"2011-05-26T18:32:33Z","messageCount":3,"participants":["Jim Meyering","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"168763","messageId":"8762ox7ehl.fsf@rho.meyering.net","threadId":"27465","inReplyTo":null,"subject":"[PATCH] plug a DIR buffer leak in rerere.c","fromName":"Jim Meyering","fromEmail":"jim@meyering.net","sentAt":"2011-05-26T13:55:50Z","receivedAt":"2011-05-26T13:55:50Z","isPatch":true,"sender":{"key":"jim@meyering.net","avatar":"https://avatars.githubusercontent.com/u/710630?v=4"},"body":"\n* rerere.c (rerere_gc): Don't leak a DIR buffer.\n---\nSpotted by coverity, and since I was already looking at this\nparticular file...\nLike the preceding patch, this is relative to \"next\".\n\n rerere.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/rerere.c b/rerere.c\nindex cb8e5ba..dcb525a 100644\n--- a/rerere.c\n+++ b/rerere.c\n@@ -745,6 +745,7 @@ void rerere_gc(struct string_list *rr)\n \t\tif (then < now - cutoff * 86400)\n \t\t\tstring_list_append(&to_remove, e->d_name);\n \t}\n+\tclosedir(dir);\n \tfor (i = 0; i < to_remove.nr; i++)\n \t\tunlink_rr_item(to_remove.items[i].string);\n \tstring_list_clear(&to_remove, 0);\n--\n1.7.5.2.660.g9f46c\n"},{"id":"168808","messageId":"7v7h9dxqzj.fsf@alter.siamese.dyndns.org","threadId":"27465","inReplyTo":"8762ox7ehl.fsf@rho.meyering.net","subject":"Re: [PATCH] plug a DIR buffer leak in rerere.c","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-05-26T18:21:20Z","receivedAt":"2011-05-26T18:21:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; I assume both of these are signed-off?\n"},{"id":"168811","messageId":"877h9d48ji.fsf@rho.meyering.net","threadId":"27465","inReplyTo":"7v7h9dxqzj.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] plug a DIR buffer leak in rerere.c","fromName":"Jim Meyering","fromEmail":"jim@meyering.net","sentAt":"2011-05-26T18:32:33Z","receivedAt":"2011-05-26T18:32:33Z","isPatch":true,"sender":{"key":"jim@meyering.net","avatar":"https://avatars.githubusercontent.com/u/710630?v=4"},"body":"Junio C Hamano wrote:\n> Thanks; I assume both of these are signed-off?\n\nYes.  Sorry about the omission.\n"}]}