{"thread":{"id":"2741","subject":"gitk - ewww","startedAt":"2005-12-04T01:27:06Z","lastAt":"2005-12-06T22:54:39Z","messageCount":7,"participants":["Ben Clifford","Linus Torvalds","H. Peter Anvin","Junio C Hamano","Nikolai Weibull","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"13162","messageId":"6CC092B0-101F-4D98-9761-B4E24A7CA35A@hawaga.org.uk","threadId":"2741","inReplyTo":null,"subject":"gitk - ewww","fromName":"Ben Clifford","fromEmail":"benc@hawaga.org.uk","sentAt":"2005-12-04T01:27:06Z","receivedAt":"2005-12-04T01:27:06Z","isPatch":false,"sender":{"key":"benc@hawaga.org.uk","avatar":"https://gravatar.com/avatar/c7ce083471287f8e77b69dd147f757799d1efdd740727fd7e3003f33e88be898?d=mp&s=160"},"body":"Here's a screen shot that surprised me with a really high 'ewwww'  \nfactor when I fired up gitk this morning on my local git repo, given  \nthat it looks pretty the rest of the time.\n\nThis repo tracking git master with just one extra commit that I've  \nadded and rebase off origin repeatedly.\n\nThe area around where the 'master' green tag is displayed  \n(specifically the two lines below it) are surprisingly poor.\n\nI'm not going to learn tcl/tk and how gitk works to investigate,  \nthough, but maybe someone else cares enough and/or can see a trivial  \nfix...\n\nScreen shot is at:\nhttp://www/hawaga.org.uk/ben/tech/gitk-eww-1.png\n\nIf trying to recreate, e011472b550b27a4644403c6fa99543ee9004a63 is  \nonly on my local machine, but I can supply a copy of my tree too.\n\n\n$ cg status\nHeads:\n    >master      e011472b550b27a4644403c6fa99543ee9004a63\n   R origin      56b5e946f2ba4fd57bbe14f9e3ec2e0ae314d5e6\n\n\n-- \nBen • ベン • Бэн • 벤 • 班明\nhttp://www.hawaga.org.uk/ben/\nMy email is high latency but best way to contact me. Alternatively,  \nSMS number(s) at above URL.\n"},{"id":"13164","messageId":"Pine.LNX.4.64.0512032040240.3099@g5.osdl.org","threadId":"2741","inReplyTo":"6CC092B0-101F-4D98-9761-B4E24A7CA35A@hawaga.org.uk","subject":"Re: gitk - ewww","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-12-04T04:44:46Z","receivedAt":"2005-12-04T04:44:46Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sun, 4 Dec 2005, Ben Clifford wrote:\n> \n> Screen shot is at:\n> http://www/hawaga.org.uk/ben/tech/gitk-eww-1.png\n\nYes. gitk doesn't look wonderful with octopus merges, the lines start \ncrossing. Oh well. I think you have to live with it, it's done this for a \nlong time.\n\nWhat makes _me_ go \"eww\" in that screenshot is that tcl/tk doesn't do \nanti-aliased fonts, but maybe that's just me, and that's apparently 8.5 \nhas that fixed (at a horrible performance impact, I'm sure, but hey, one \nlook at your screenshot and I'm saying \"bring it on\").\n\n\t\tLinus\n"},{"id":"13165","messageId":"4392871B.1030300@zytor.com","threadId":"2741","inReplyTo":"Pine.LNX.4.64.0512032040240.3099@g5.osdl.org","subject":"Re: gitk - ewww","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-12-04T06:05:15Z","receivedAt":"2005-12-04T06:05:15Z","isPatch":false,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Linus Torvalds wrote:\n> \n> On Sun, 4 Dec 2005, Ben Clifford wrote:\n> \n>>Screen shot is at:\n>>http://www/hawaga.org.uk/ben/tech/gitk-eww-1.png\n> \n> \n> Yes. gitk doesn't look wonderful with octopus merges, the lines start \n> crossing. Oh well. I think you have to live with it, it's done this for a \n> long time.\n> \n> What makes _me_ go \"eww\" in that screenshot is that tcl/tk doesn't do \n> anti-aliased fonts, but maybe that's just me, and that's apparently 8.5 \n> has that fixed (at a horrible performance impact, I'm sure, but hey, one \n> look at your screenshot and I'm saying \"bring it on\").\n> \n\nIt usually work OK for me, running on Fedora Core 4.\n\nClearly, though, it's Tcl/Tk version dependent; especially since it \nlooks absolutely *awful* on Cygwin.\n\n\t-hpa\n"},{"id":"13169","messageId":"7vpsodtm6j.fsf@assigned-by-dhcp.cox.net","threadId":"2741","inReplyTo":"Pine.LNX.4.64.0512032040240.3099@g5.osdl.org","subject":"Re: gitk - ewww","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-12-04T06:23:48Z","receivedAt":"2005-12-04T06:23:48Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Linus Torvalds <torvalds@osdl.org> writes:\n\n> On Sun, 4 Dec 2005, Ben Clifford wrote:\n>> \n>> Screen shot is at:\n>> http://www/hawaga.org.uk/ben/tech/gitk-eww-1.png\n>\n> Yes. gitk doesn't look wonderful with octopus merges, the lines start \n> crossing. Oh well. I think you have to live with it, it's done this for a \n> long time.\n\nFWIW, when the first ever Octopus was made, it looked wonderful.\nThe way gitk renders octopus is somehow quite different these\ndays.\n"},{"id":"13179","messageId":"408B7182-4EE2-45F8-ADC0-57108781B073@hawaga.org.uk","threadId":"2741","inReplyTo":"4392871B.1030300@zytor.com","subject":"Re: gitk - ewww","fromName":"Ben Clifford","fromEmail":"benc@hawaga.org.uk","sentAt":"2005-12-04T09:38:54Z","receivedAt":"2005-12-04T09:38:54Z","isPatch":false,"sender":{"key":"benc@hawaga.org.uk","avatar":"https://gravatar.com/avatar/c7ce083471287f8e77b69dd147f757799d1efdd740727fd7e3003f33e88be898?d=mp&s=160"},"body":"\n>> What makes _me_ go \"eww\" in that screenshot is that tcl/tk doesn't  \n>> do anti-aliased fonts, but maybe that's just me, and that's  \n>> apparently 8.5 has that fixed (at a horrible performance impact,  \n>> I'm sure, but hey, one look at your screenshot and I'm saying  \n>> \"bring it on\").\n>>\n>\n> It usually work OK for me, running on Fedora Core 4.\n>\n> Clearly, though, it's Tcl/Tk version dependent; especially since it  \n> looks absolutely *awful* on Cygwin.\n\nThe Wish/About Tcl & Tk menu option reports tcl/tk 8.4.7 - so I'd  \nguess any changes made for 8.5 won't have arrived at this host yet.\n\nThis is under Mac OS X 10.4.2.\n\n-- \nBen • ベン • Бэн • 벤 • 班明\nhttp://www.hawaga.org.uk/ben/\nMy email is high latency but best way to contact me. Alternatively,  \nSMS number(s) at above URL.\n"},{"id":"13176","messageId":"20051204171206.GA8819@puritan.petwork","threadId":"2741","inReplyTo":"Pine.LNX.4.64.0512032040240.3099@g5.osdl.org","subject":"Re: gitk - ewww","fromName":"Nikolai Weibull","fromEmail":"mailing-lists.git@rawuncut.elitemail.org","sentAt":"2005-12-04T17:12:06Z","receivedAt":"2005-12-04T17:12:06Z","isPatch":false,"sender":{"key":"mailing-lists.git@rawuncut.elitemail.org","avatar":null},"body":"Linus Torvalds wrote:\n\n> On Sun, 4 Dec 2005, Ben Clifford wrote:\n\n> > Screen shot is at:\n> > http://www/hawaga.org.uk/ben/tech/gitk-eww-1.png\n\n> What makes _me_ go \"eww\" in that screenshot is that tcl/tk doesn't do\n> anti-aliased fonts, but maybe that's just me, and that's apparently\n> 8.5 has that fixed (at a horrible performance impact, I'm sure, but\n> hey, one look at your screenshot and I'm saying \"bring it on\").\n\nJust use a slightly larger font and it should be fine.  The lower-right\nfield, whatever that lists (changed files?) - I have never used gitk,\nuses anti-aliasing, and the only problem I see is that the\ncommit-message listing uses a font that is way too small (or is badly\ndesigned).  The top pane is easily readable, although it could use a\nslightly larger point-size.\n\nAnti-aliasing is only a hack for displaying text on a screen.  It's not\na substitute for choosing your fonts and point sizes with care.  A\nbitmapped font designed for small point-sizes will always look more\ncrisp than a generic TTF at small point-sizes.\n\n        nikolai\n\n-- \nNikolai Weibull: now available free of charge at http://bitwi.se/!\nBorn in Chicago, IL USA; currently residing in Gothenburg, Sweden.\nmain(){printf(&linux[\"\\021%six\\012\\0\"],(linux)[\"have\"]+\"fun\"-97);}\n"},{"id":"13299","messageId":"17302.5807.533467.200693@cargo.ozlabs.ibm.com","threadId":"2741","inReplyTo":"6CC092B0-101F-4D98-9761-B4E24A7CA35A@hawaga.org.uk","subject":"Re: gitk - ewww","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2005-12-06T22:54:39Z","receivedAt":"2005-12-06T22:54:39Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Ben Clifford writes:\n\n> The area around where the 'master' green tag is displayed  \n> (specifically the two lines below it) are surprisingly poor.\n\nYes.\n\n> I'm not going to learn tcl/tk and how gitk works to investigate,  \n> though, but maybe someone else cares enough and/or can see a trivial  \n> fix...\n\nI'm working on changes which should fix this and also speed it up, but\nit's not trivial... :)\n\nPaul.\n"}]}