{"thread":{"id":"27370","subject":"[RFC/PATCH] completion: __git_ps1() returns exit status now","startedAt":"2011-05-16T13:23:29Z","lastAt":"2011-05-16T13:23:29Z","messageCount":1,"participants":["Sergei Gavrikov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"167992","messageId":"alpine.DEB.2.00.1105161615430.3397@sg-pc.belvok.com","threadId":"27370","inReplyTo":null,"subject":"[RFC/PATCH] completion: __git_ps1() returns exit status now","fromName":"Sergei Gavrikov","fromEmail":"sergei.gavrikov@gmail.com","sentAt":"2011-05-16T13:23:29Z","receivedAt":"2011-05-16T13:23:29Z","isPatch":true,"sender":{"key":"sergei.gavrikov@gmail.com","avatar":null},"body":"SYNOPSIS\n\n        $(__git_ps1 || __other_vcs_ps1)\n\nIt would be great if __git_ps1() could return exit status on it's\nfinish, otherwise they have to check git_ps1 text output or recall\n__gitdir() to suppress alternative VCS prompt(s).\n\nPatch attached, although I would prefer to check it at once, e.g.,\n\n        if [ -z \"$g\" ]; then return 1; fi\n        ...\n        return 0\n\nhowever, I was in doubt about more verbose delta in such a case.\n\nIf I request the bad things or miss something, please, forget it.\n\nSigned-off-by: Sergei Gavrikov <sergei.gavrikov@gmail.com>\n---\n contrib/completion/git-completion.bash |    7 ++++++-\n 1 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex b81f444..8b660ca 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -222,7 +222,8 @@ __git_ps1_show_upstream ()\n \n \n # __git_ps1 accepts 0 or 1 arguments (i.e., format string)\n-# returns text to add to bash PS1 prompt (includes branch name)\n+# prints text to add to bash PS1 prompt (includes branch name),\n+# returns 0 (exit status) if gitdir was processed, otherwise 1.\n __git_ps1 ()\n {\n \tlocal g=\"$(__gitdir)\"\n@@ -313,7 +314,11 @@ __git_ps1 ()\n \n \t\tlocal f=\"$w$i$s$u\"\n \t\tprintf \"${1:- (%s)}\" \"$c${b##refs/heads/}${f:+ $f}$r$p\"\n+\n+\t\treturn 0\n \tfi\n+\n+\treturn 1\n }\n \n # __gitcomp_1 requires 2 arguments\n-- \n1.7.0.4\n"}]}