{"thread":{"id":"27333","subject":"[PATCH] Tweak t3102-ls-tree-wildcards to run on Windows","startedAt":"2011-05-12T08:37:22Z","lastAt":"2011-05-12T12:19:59Z","messageCount":2,"participants":["Johannes Sixt","Nguyen Thai Ngoc Duy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"167714","messageId":"4DCB9C42.5070806@viscovery.net","threadId":"27333","inReplyTo":null,"subject":"[PATCH] Tweak t3102-ls-tree-wildcards to run on Windows","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2011-05-12T08:37:22Z","receivedAt":"2011-05-12T08:37:22Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"From: Johannes Sixt <j6t@kdbg.org>\n\nThe test case fails on Windows, because \"a*\" is an invalid file name.\nTherefore, use \"a[a]\" instead.\n\nSigned-off-by: Johannes Sixt <j6t@kdbg.org>\n---\n Regarding the change from * to [], I do not know whether the result\n still tests the same thing. Please advise!\n\n -- Hannes\n\n t/t3102-ls-tree-wildcards.sh |   14 +++++++-------\n 1 files changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/t/t3102-ls-tree-wildcards.sh b/t/t3102-ls-tree-wildcards.sh\nindex f2b2a52..c286854 100755\n--- a/t/t3102-ls-tree-wildcards.sh\n+++ b/t/t3102-ls-tree-wildcards.sh\n@@ -1,21 +1,21 @@\n #!/bin/sh\n \n-test_description='ls-tree with(out) wildcards'\n+test_description='ls-tree with(out) globs'\n \n . ./test-lib.sh\n \n test_expect_success 'setup' '\n-\tmkdir a aa \"a*\" &&\n-\ttouch a/one aa/two \"a*/three\" &&\n-\tgit add a/one aa/two \"a*/three\" &&\n+\tmkdir a aa \"a[a]\" &&\n+\ttouch a/one aa/two \"a[a]/three\" &&\n+\tgit add a/one aa/two \"a[a]/three\" &&\n \tgit commit -m test\n '\n \n-test_expect_success 'ls-tree a* matches literally' '\n+test_expect_success 'ls-tree a[a] matches literally' '\n \tcat >expected <<EOF &&\n-100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391\ta*/three\n+100644 blob e69de29bb2d1d6434b8b29ae775ad8c2e48c5391\ta[a]/three\n EOF\n-\tgit ls-tree -r HEAD \"a*\" >actual &&\n+\tgit ls-tree -r HEAD \"a[a]\" >actual &&\n \ttest_cmp expected actual\n '\n \n-- \n1.7.5.1.1646.g44dd\n"},{"id":"167728","messageId":"BANLkTino-zmbRqNat-TO8YcQHCrMr4A06A@mail.gmail.com","threadId":"27333","inReplyTo":"4DCB9C42.5070806@viscovery.net","subject":"Re: [PATCH] Tweak t3102-ls-tree-wildcards to run on Windows","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2011-05-12T12:19:59Z","receivedAt":"2011-05-12T12:19:59Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"2011/5/12 Johannes Sixt <j.sixt@viscovery.net>:\n> From: Johannes Sixt <j6t@kdbg.org>\n>\n> The test case fails on Windows, because \"a*\" is an invalid file name.\n> Therefore, use \"a[a]\" instead.\n>\n> Signed-off-by: Johannes Sixt <j6t@kdbg.org>\n> ---\n>  Regarding the change from * to [], I do not know whether the result\n>  still tests the same thing. Please advise!\n\nThe result is correct. Whatever pattern you throw at ls-tree should be\ninterpreted literally, no magic at all.\n\nAcked-by: me.\n-- \nDuy\n"}]}