{"thread":{"id":"27322","subject":"Re: http.receivepack==false && authenticated => Service not enabled","startedAt":"2011-05-11T10:21:20Z","lastAt":"2011-05-11T10:26:29Z","messageCount":2,"participants":["Robert"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"167656","messageId":"BANLkTikZdvW1ptVNBiJpCX7jdrqxq=CaDA@mail.gmail.com","threadId":"27322","inReplyTo":null,"subject":"http.receivepack==false && authenticated => Service not enabled","fromName":"Robert","fromEmail":"yayooo@gmail.com","sentAt":"2011-05-11T10:21:20Z","receivedAt":"2011-05-11T10:21:20Z","isPatch":false,"sender":{"key":"yayooo@gmail.com","avatar":null},"body":"Even a authenticated  user can not push when http.receivepack set to false.\nwhen\ngit config http.receivepack false\nsvc->enabled was set to 0 not -1\nso we should initialize with 0 not -1\n\n--- http-backend.c      Thu May  5 01:16:14 2011\n+++ http-backend.c   Wed May 11 09:57:52 2011\n@@ -23,7 +23,7 @@\n\n static struct rpc_service rpc_service[] = {\n        { \"upload-pack\", \"uploadpack\", 1 },\n-       { \"receive-pack\", \"receivepack\", -1 },\n+       { \"receive-pack\", \"receivepack\", 0 },\n };\n\n static struct string_list *get_parameters(void)\n@@ -260,8 +260,8 @@\n        if (!svc)\n                forbidden(\"Unsupported service: '%s'\", name);\n\n-       if (svc->enabled < 0) {\n                const char *user = getenv(\"REMOTE_USER\");\n+       if (!svc->enabled) {\n                svc->enabled = (user && *user) ? 1 : 0;\n        }\n        if (!svc->enabled)\n"},{"id":"167655","messageId":"BANLkTi=14G2WvfoHfhJn_u_NDHnL+6cqCQ@mail.gmail.com","threadId":"27322","inReplyTo":"BANLkTikZdvW1ptVNBiJpCX7jdrqxq=CaDA@mail.gmail.com","subject":"Re: http.receivepack==false && authenticated => Service not enabled","fromName":"Robert","fromEmail":"yayooo@gmail.com","sentAt":"2011-05-11T10:26:29Z","receivedAt":"2011-05-11T10:26:29Z","isPatch":false,"sender":{"key":"yayooo@gmail.com","avatar":null},"body":"Sorry！It is my wrong ! It is not a bug !\n\nOn Wed, May 11, 2011 at 10:21, Robert <yayooo@gmail.com> wrote:\n> Even a authenticated  user can not push when http.receivepack set to false.\n> when\n> git config http.receivepack false\n> svc->enabled was set to 0 not -1\n> so we should initialize with 0 not -1\n>\n> --- http-backend.c      Thu May  5 01:16:14 2011\n> +++ http-backend.c   Wed May 11 09:57:52 2011\n> @@ -23,7 +23,7 @@\n>\n>  static struct rpc_service rpc_service[] = {\n>        { \"upload-pack\", \"uploadpack\", 1 },\n> -       { \"receive-pack\", \"receivepack\", -1 },\n> +       { \"receive-pack\", \"receivepack\", 0 },\n>  };\n>\n>  static struct string_list *get_parameters(void)\n> @@ -260,8 +260,8 @@\n>        if (!svc)\n>                forbidden(\"Unsupported service: '%s'\", name);\n>\n> -       if (svc->enabled < 0) {\n>                const char *user = getenv(\"REMOTE_USER\");\n> +       if (!svc->enabled) {\n>                svc->enabled = (user && *user) ? 1 : 0;\n>        }\n>        if (!svc->enabled)\n>\n"}]}