{"thread":{"id":"27268","subject":"[PATCH] Fix test t3701-add-interactive.sh","startedAt":"2011-05-05T16:50:29Z","lastAt":"2011-05-05T18:53:56Z","messageCount":3,"participants":["Kacper Kornet","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"167123","messageId":"20110505165029.GD31229@camk.edu.pl","threadId":"27268","inReplyTo":null,"subject":"[PATCH] Fix test t3701-add-interactive.sh","fromName":"Kacper Kornet","fromEmail":"draenog@pld-linux.org","sentAt":"2011-05-05T16:50:29Z","receivedAt":"2011-05-05T16:50:29Z","isPatch":true,"sender":{"key":"draenog@pld-linux.org","avatar":"https://avatars.githubusercontent.com/u/608762?v=4"},"body":"One of the tests used to fail due to EOF not in the first column and not\ncontinued &&.\n\nSigned-off-by: Kacper Kornet <draenog@pld-linux.org>\n---\n t/t3701-add-interactive.sh |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh\nindex d6327e7..018f5d9 100755\n--- a/t/t3701-add-interactive.sh\n+++ b/t/t3701-add-interactive.sh\n@@ -83,9 +83,9 @@ EOF\n \n test_expect_success PERL 'setup fake editor' '\n \tcat >fake_editor.sh <<EOF\n-\tEOF\n+EOF\n \tchmod a+x fake_editor.sh &&\n-\ttest_set_editor \"$(pwd)/fake_editor.sh\" &&\n+\ttest_set_editor \"$(pwd)/fake_editor.sh\"\n '\n \n test_expect_success PERL 'dummy edit works' '\n-- \n1.7.5\n\n-- \n  Kacper Kornet\n"},{"id":"167142","messageId":"7vzkn16m0q.fsf@alter.siamese.dyndns.org","threadId":"27268","inReplyTo":"20110505165029.GD31229@camk.edu.pl","subject":"Re: [PATCH] Fix test t3701-add-interactive.sh","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-05-05T18:27:17Z","receivedAt":"2011-05-05T18:27:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kacper Kornet <draenog@pld-linux.org> writes:\n\n> One of the tests used to fail due to EOF not in the first column and not\n> continued &&.\n>\n> Signed-off-by: Kacper Kornet <draenog@pld-linux.org>\n> ---\n>  t/t3701-add-interactive.sh |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh\n> index d6327e7..018f5d9 100755\n> --- a/t/t3701-add-interactive.sh\n> +++ b/t/t3701-add-interactive.sh\n> @@ -83,9 +83,9 @@ EOF\n>  \n>  test_expect_success PERL 'setup fake editor' '\n>  \tcat >fake_editor.sh <<EOF\n> -\tEOF\n> +EOF\n>  \tchmod a+x fake_editor.sh &&\n> -\ttest_set_editor \"$(pwd)/fake_editor.sh\" &&\n> +\ttest_set_editor \"$(pwd)/fake_editor.sh\"\n>  '\n\nVery curious. I never saw the breakage.  We are getting:\n\n./test-lib.sh: line 450: warning: here-document at line 447 delimited by\nend-of-file (wanted `EOF')\n\nWell spotted.  Thanks.\n"},{"id":"167154","messageId":"20110505185355.GG31229@camk.edu.pl","threadId":"27268","inReplyTo":"7vzkn16m0q.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Fix test t3701-add-interactive.sh","fromName":"Kacper Kornet","fromEmail":"draenog@pld-linux.org","sentAt":"2011-05-05T18:53:56Z","receivedAt":"2011-05-05T18:53:56Z","isPatch":true,"sender":{"key":"draenog@pld-linux.org","avatar":"https://avatars.githubusercontent.com/u/608762?v=4"},"body":"On Thu, May 05, 2011 at 11:27:17AM -0700, Junio C Hamano wrote:\n> Kacper Kornet <draenog@pld-linux.org> writes:\n\n> > One of the tests used to fail due to EOF not in the first column and not\n> > continued &&.\n\n> > Signed-off-by: Kacper Kornet <draenog@pld-linux.org>\n> > ---\n> >  t/t3701-add-interactive.sh |    4 ++--\n> >  1 files changed, 2 insertions(+), 2 deletions(-)\n\n> > diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh\n> > index d6327e7..018f5d9 100755\n> > --- a/t/t3701-add-interactive.sh\n> > +++ b/t/t3701-add-interactive.sh\n> > @@ -83,9 +83,9 @@ EOF\n\n> >  test_expect_success PERL 'setup fake editor' '\n> >  \tcat >fake_editor.sh <<EOF\n> > -\tEOF\n> > +EOF\n> >  \tchmod a+x fake_editor.sh &&\n> > -\ttest_set_editor \"$(pwd)/fake_editor.sh\" &&\n> > +\ttest_set_editor \"$(pwd)/fake_editor.sh\"\n> >  '\n\n> Very curious. I never saw the breakage.  We are getting:\n\nIt is probably we are using a different shell as /bin/sh.\n\n> Well spotted.  Thanks.\n\nBy the way. The credit shoud probably go to qboosh@pld-linux.org. I have\njust rediscovered it in my private build.\n-- \n  Kacper Kornet\n"}]}