{"thread":{"id":"27225","subject":"[PATCH] git-send-email: fix missing space in error message","startedAt":"2011-04-29T18:23:24Z","lastAt":"2011-04-30T07:52:39Z","messageCount":4,"participants":["Sylvain Rabot","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"166769","messageId":"1304101404-4571-1-git-send-email-sylvain@abstraction.fr","threadId":"27225","inReplyTo":null,"subject":"[PATCH] git-send-email: fix missing space in error message","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2011-04-29T18:23:24Z","receivedAt":"2011-04-29T18:23:24Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"Signed-off-by: Sylvain Rabot \n---\n git-send-email.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 76565de..98ab33a 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion\n \t\t\t \"VALUES: server=$smtp_server \",\n \t\t\t \"encryption=$smtp_encryption \",\n \t\t\t \"hello=$smtp_domain\",\n-\t\t\t defined $smtp_server_port ? \"port=$smtp_server_port\" : \"\";\n+\t\t\t defined $smtp_server_port ? \" port=$smtp_server_port\" : \"\";\n \t\t}\n \n \t\tif (defined $smtp_authuser) {\n-- \n1.7.5\n"},{"id":"166770","messageId":"7vmxj8x5yj.fsf@alter.siamese.dyndns.org","threadId":"27225","inReplyTo":"1304101404-4571-1-git-send-email-sylvain@abstraction.fr","subject":"Re: [PATCH] git-send-email: fix missing space in error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-04-29T18:33:56Z","receivedAt":"2011-04-29T18:33:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sylvain Rabot writes:\n\n> Signed-off-by: Sylvain Rabot \n\nPlease keep in mind that these individual commits will eventually need an\nentry added to Documentation/Relnotes/1.7.5.1.txt where I describe what\nbug was fixed in a single paragraph, and it almost always talks about how\na bug would have been triggered so that the readers can tell if the fix\nwould benefit them.\n\nIt would have been perfect if you wrote under what condition the user\nwould see this error message in the body of the commit.\n\n> ---\n> git-send-email.perl | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 76565de..98ab33a 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion\n> \t\t\t \"VALUES: server=$smtp_server \",\n> \t\t\t \"encryption=$smtp_encryption \",\n> \t\t\t \"hello=$smtp_domain\",\n> -\t\t\t defined $smtp_server_port ? \"port=$smtp_server_port\" : \"\";\n> +\t\t\t defined $smtp_server_port ? \" port=$smtp_server_port\" : \"\";\n\nIf I were writing this from scratch, I probably would have written it\nby having leading SP for all options, perhaps like this:\n\n\t\"VALUES:\",\n \" option=value\",\n \" option=value\",\n (showoption) ? \" option=value\" : \"\",\n (showoption) ? \" option=value\" : \"\",\n ...\n\nThanks.\n"},{"id":"166771","messageId":"7viptwx5s4.fsf@alter.siamese.dyndns.org","threadId":"27225","inReplyTo":"7vmxj8x5yj.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-send-email: fix missing space in error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-04-29T18:37:47Z","receivedAt":"2011-04-29T18:37:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Sylvain Rabot writes:\n>\n>> Signed-off-by: Sylvain Rabot \n>\n> Please keep in mind that these individual commits will eventually need an\n> entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what\n> bug was fixed in a single paragraph, and it almost always talks about how\n> a bug would have been triggered so that the readers can tell if the fix\n> would benefit them.\n>\n> It would have been perfect if you wrote under what condition the user\n> would see this error message in the body of the commit.\n\nWill queue this; thanks.\n\nAuthor: Sylvain Rabot \nDate: Fri Apr 29 20:23:24 2011 +0200\n\n git-send-email: fix missing space in error message\n \n When the command cannot make a connection to the SMTP server the error\n message to diagnose the broken configuration is issued. However, when an\n optional smtp-server-port is given and needs to be reported, the message\n lacked a space between \"hello=\" and \"port=\".\n \n Signed-off-by: Sylvain Rabot \n Signed-off-by: Junio C Hamano \n"},{"id":"166797","messageId":"1304149959.1850.4.camel@kheops","threadId":"27225","inReplyTo":"7vmxj8x5yj.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-send-email: fix missing space in error message","fromName":"Sylvain Rabot","fromEmail":"sylvain@abstraction.fr","sentAt":"2011-04-30T07:52:39Z","receivedAt":"2011-04-30T07:52:39Z","isPatch":true,"sender":{"key":"sylvain@abstraction.fr","avatar":"https://avatars.githubusercontent.com/u/153052?v=4"},"body":"Sorry about that. Was thinking this was not worth an entry in\nthe release note.\n\nOn Fri, 2011-04-29 at 11:33 -0700, Junio C Hamano wrote:\n> Sylvain Rabot writes:\n> \n> > Signed-off-by: Sylvain Rabot \n> \n> Please keep in mind that these individual commits will eventually need an\n> entry added to Documentation/Relnotes/1.7.5.1.txt where I describe what\n> bug was fixed in a single paragraph, and it almost always talks about how\n> a bug would have been triggered so that the readers can tell if the fix\n> would benefit them.\n> \n> It would have been perfect if you wrote under what condition the user\n> would see this error message in the body of the commit.\n> \n> > ---\n> > git-send-email.perl | 2 +-\n> > 1 files changed, 1 insertions(+), 1 deletions(-)\n> >\n> > diff --git a/git-send-email.perl b/git-send-email.perl\n> > index 76565de..98ab33a 100755\n> > --- a/git-send-email.perl\n> > +++ b/git-send-email.perl\n> > @@ -1091,7 +1091,7 @@ X-Mailer: git-send-email $gitversion\n> > \t\t\t \"VALUES: server=$smtp_server \",\n> > \t\t\t \"encryption=$smtp_encryption \",\n> > \t\t\t \"hello=$smtp_domain\",\n> > -\t\t\t defined $smtp_server_port ? \"port=$smtp_server_port\" : \"\";\n> > +\t\t\t defined $smtp_server_port ? \" port=$smtp_server_port\" : \"\";\n> \n> If I were writing this from scratch, I probably would have written it\n> by having leading SP for all options, perhaps like this:\n> \n> \t\"VALUES:\",\n> \" option=value\",\n> \" option=value\",\n> (showoption) ? \" option=value\" : \"\",\n> (showoption) ? \" option=value\" : \"\",\n> ...\n> \n> Thanks.\n\n"}]}