{"thread":{"id":"27161","subject":"[PATCH 0/2] Documentation fixes for git-svn.txt","startedAt":"2011-04-22T17:03:37Z","lastAt":"2011-04-26T11:34:19Z","messageCount":9,"participants":["Valentin Haenel","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"166224","messageId":"1303491819-9850-1-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":null,"subject":"[PATCH 0/2] Documentation fixes for git-svn.txt","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-22T17:03:37Z","receivedAt":"2011-04-22T17:03:37Z","isPatch":true,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"Hi,\n\nthe command documentation for 'git svn fetch' lists the following two\noptions:\n\n --use-log-author\n\nand\n\n --add-author-from\n\nHowever, as the current description of both states, they are also\napplicable to 'git svn' subcommands other than fetch. The first patch\nmoves them, the second patch applies some cosmetics.\n\nMy remaining question regarding the second option, '--add-author-from',\nis about the subcommands which it is applicable to. The current\ndocumentation states 'commit' and 'dcommit'. My feeling is that 'commit'\nis a typo, since 'git svn' does not have a 'commit' subcommand. I had a\nlook at the code, and while I am not familiar with perl, it seems to me\nthat the three subcommands that use the option are 'commit-diff',\n'set-tree' and 'dcommit'. But this is non-trivial -- feedback is\nappreciated.\n\nV-\n\nValentin Haenel (2):\n git-svn.txt: move option descriptions\n git-svn.txt: small typeface improvements\n\n Documentation/git-svn.txt | 23 ++++++++++++-----------\n 1 files changed, 12 insertions(+), 11 deletions(-)\n"},{"id":"166226","messageId":"1303491819-9850-2-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"1303491819-9850-1-git-send-email-valentin.haenel@gmx.de","subject":"[PATCH 1/2] git-svn.txt: move option descriptions","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-22T17:03:38Z","receivedAt":"2011-04-22T17:03:38Z","isPatch":true,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"The options '---use-log-author' and '--add-author-from' are applicable to other\nsubcommands except 'fetch' -- therefore move them from the 'fetch' section to\nthe more general 'options' section\n\nSigned-off-by: Valentin Haenel \n---\n Documentation/git-svn.txt | 22 +++++++++++-----------\n 1 files changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 30a6748..e12f9f8 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -145,17 +145,6 @@ Skip \"branches\" and \"tags\" of first level directories;;\n ------------------------------------------------------------------------\n --\n \n---use-log-author;;\n-\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n-\tdcommit operations), look for the first From: or Signed-off-by: line\n-\tin the log message and use that as the author string.\n---add-author-from;;\n-\tWhen committing to svn from git (as part of commit or dcommit\n-\toperations), if the existing log message doesn't already have a\n-\tFrom: or Signed-off-by: line, append a From: line based on the\n-\tgit commit's author string. If you use this, then --use-log-author\n-\twill retrieve a valid author string for all commits.\n-\n 'clone'::\n \tRuns 'init' and 'fetch'. It will automatically create a\n \tdirectory based on the basename of the URL passed to it;\n@@ -572,6 +561,17 @@ repository that will be fetched from.\n For 'branch' and 'tag', display the urls that will be used for copying when\n creating the branch or tag.\n \n+--use-log-author::\n+\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n+\tdcommit operations), look for the first From: or Signed-off-by: line\n+\tin the log message and use that as the author string.\n+--add-author-from::\n+\tWhen committing to svn from git (as part of commit or dcommit\n+\toperations), if the existing log message doesn't already have a\n+\tFrom: or Signed-off-by: line, append a From: line based on the\n+\tgit commit's author string. If you use this, then --use-log-author\n+\twill retrieve a valid author string for all commits.\n+\n \n ADVANCED OPTIONS\n ----------------\n-- \n1.7.1\n"},{"id":"166225","messageId":"1303491819-9850-3-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"1303491819-9850-1-git-send-email-valentin.haenel@gmx.de","subject":"[PATCH 2/2] git-svn.txt: small typeface improvements","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-22T17:03:39Z","receivedAt":"2011-04-22T17:03:39Z","isPatch":true,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"Signed-off-by: Valentin Haenel \n---\n Documentation/git-svn.txt | 11 ++++++-----\n 1 files changed, 6 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex e12f9f8..5c75d71 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -562,14 +562,15 @@ For 'branch' and 'tag', display the urls that will be used for copying when\n creating the branch or tag.\n \n --use-log-author::\n-\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n-\tdcommit operations), look for the first From: or Signed-off-by: line\n+\tWhen retrieving svn commits into git (as part of 'fetch', 'rebase', or\n+\t'dcommit' operations), look for the first `From:` or `Signed-off-by:` line\n \tin the log message and use that as the author string.\n---add-author-from::\n \tWhen committing to svn from git (as part of commit or dcommit\n+--add-author-from::\n+\tWhen committing to svn from git (as part of 'commit' or 'dcommit'\n \toperations), if the existing log message doesn't already have a\n-\tFrom: or Signed-off-by: line, append a From: line based on the\n-\tgit commit's author string. If you use this, then --use-log-author\n+\t`From:` or `Signed-off-by:` line, append a `From:` line based on the\n+\tgit commit's author string. If you use this, then `--use-log-author`\n \twill retrieve a valid author string for all commits.\n \n \n-- \n1.7.1\n"},{"id":"166332","messageId":"20110425210623.GB13953@dcvr.yhbt.net","threadId":"27161","inReplyTo":"1303491819-9850-1-git-send-email-valentin.haenel@gmx.de","subject":"Re: [PATCH 0/2] Documentation fixes for git-svn.txt","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2011-04-25T21:06:23Z","receivedAt":"2011-04-25T21:06:23Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Valentin Haenel wrote:\n> My remaining question regarding the second option, '--add-author-from',\n> is about the subcommands which it is applicable to. The current\n> documentation states 'commit' and 'dcommit'. My feeling is that 'commit'\n> is a typo, since 'git svn' does not have a 'commit' subcommand. I had a\n> look at the code, and while I am not familiar with perl, it seems to me\n> that the three subcommands that use the option are 'commit-diff',\n> 'set-tree' and 'dcommit'. But this is non-trivial -- feedback is\n> appreciated.\n\nYes, commit-diff, set-tree, and dcommit all use --add-author-from.\n\nI don't have time to build the docs and test formatting, but your\nchanges all look reasonable, consider them:\n\nAcked-by: Eric Wong \n\nThanks!\n\n-- \nEric Wong\n"},{"id":"166334","messageId":"1303767375-14887-1-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"20110425210623.GB13953@dcvr.yhbt.net","subject":"[PATCH] git-svn.txt: fix usage of --add-author-from","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-25T21:36:15Z","receivedAt":"2011-04-25T21:36:15Z","isPatch":true,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"The option '--add-author-from' is used in 'commit-diff', 'set-tree', and\n'dcommit'\n\nSigned-off-by: Valentin Haenel \nAcked-by: Eric Wong \n---\n Documentation/git-svn.txt | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex 5c75d71..4865007 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -567,7 +567,7 @@ creating the branch or tag.\n \tin the log message and use that as the author string.\n \tWhen committing to svn from git (as part of commit or dcommit\n --add-author-from::\n-\tWhen committing to svn from git (as part of 'commit' or 'dcommit'\n+\tWhen committing to svn from git (as part of 'commit-diff', 'set-tree' or 'dcommit'\n \toperations), if the existing log message doesn't already have a\n \t`From:` or `Signed-off-by:` line, append a `From:` line based on the\n \tgit commit's author string. If you use this, then `--use-log-author`\n-- \n1.7.1\n"},{"id":"166335","messageId":"7vfwp6hu3b.fsf@alter.siamese.dyndns.org","threadId":"27161","inReplyTo":"1303767375-14887-1-git-send-email-valentin.haenel@gmx.de","subject":"Re: [PATCH] git-svn.txt: fix usage of --add-author-from","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-04-25T21:58:00Z","receivedAt":"2011-04-25T21:58:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks for a resend. Very much appreciated.\n"},{"id":"166371","messageId":"1303817659-26541-1-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"20110425210623.GB13953@dcvr.yhbt.net","subject":"[PATCHv2 0/2] Documentation fixes for git-svn.txt","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-26T11:34:17Z","receivedAt":"2011-04-26T11:34:17Z","isPatch":false,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"Two patches I failed to resend. Now Rebased against current pu and added\nAcked-by line.\n\nValentin Haenel (2):\n git-svn.txt: move option descriptions\n git-svn.txt: small typeface improvements\n\n Documentation/git-svn.txt | 22 +++++++++++-----------\n 1 files changed, 11 insertions(+), 11 deletions(-)\n"},{"id":"166372","messageId":"1303817659-26541-2-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"20110425210623.GB13953@dcvr.yhbt.net","subject":"[PATCHv2 1/2] git-svn.txt: move option descriptions","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-26T11:34:18Z","receivedAt":"2011-04-26T11:34:18Z","isPatch":false,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"The options '---use-log-author' and '--add-author-from' are applicable to other\nsubcommands except 'fetch' -- therefore move them from the 'fetch' section to\nthe more general 'options' section\n\nSigned-off-by: Valentin Haenel \nAcked-by: Eric Wong \n---\n Documentation/git-svn.txt | 22 +++++++++++-----------\n 1 files changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex c07b2ad..ba8a95e 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -145,17 +145,6 @@ Skip \"branches\" and \"tags\" of first level directories;;\n ------------------------------------------------------------------------\n --\n \n---use-log-author;;\n-\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n-\tdcommit operations), look for the first From: or Signed-off-by: line\n-\tin the log message and use that as the author string.\n---add-author-from;;\n-\tWhen committing to svn from git (as part of 'commit-diff', 'set-tree' or 'dcommit'\n-\toperations), if the existing log message doesn't already have a\n-\tFrom: or Signed-off-by: line, append a From: line based on the\n-\tgit commit's author string. If you use this, then --use-log-author\n-\twill retrieve a valid author string for all commits.\n-\n 'clone'::\n \tRuns 'init' and 'fetch'. It will automatically create a\n \tdirectory based on the basename of the URL passed to it;\n@@ -574,6 +563,17 @@ repository that will be fetched from.\n For 'branch' and 'tag', display the urls that will be used for copying when\n creating the branch or tag.\n \n+--use-log-author::\n+\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n+\tdcommit operations), look for the first From: or Signed-off-by: line\n+\tin the log message and use that as the author string.\n+--add-author-from::\n+\tWhen committing to svn from git (as part of 'commit-diff', 'set-tree' or 'dcommit'\n+\toperations), if the existing log message doesn't already have a\n+\tFrom: or Signed-off-by: line, append a From: line based on the\n+\tgit commit's author string. If you use this, then --use-log-author\n+\twill retrieve a valid author string for all commits.\n+\n \n ADVANCED OPTIONS\n ----------------\n-- \n1.7.1\n"},{"id":"166373","messageId":"1303817659-26541-3-git-send-email-valentin.haenel@gmx.de","threadId":"27161","inReplyTo":"20110425210623.GB13953@dcvr.yhbt.net","subject":"[PATCHv2 2/2] git-svn.txt: small typeface improvements","fromName":"Valentin Haenel","fromEmail":"valentin.haenel@gmx.de","sentAt":"2011-04-26T11:34:19Z","receivedAt":"2011-04-26T11:34:19Z","isPatch":false,"sender":{"key":"valentin.haenel@gmx.de","avatar":"https://avatars.githubusercontent.com/u/41563?v=4"},"body":"Signed-off-by: Valentin Haenel \nAcked-by: Eric Wong \n---\n Documentation/git-svn.txt | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex ba8a95e..713e523 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -564,14 +564,14 @@ For 'branch' and 'tag', display the urls that will be used for copying when\n creating the branch or tag.\n \n --use-log-author::\n-\tWhen retrieving svn commits into git (as part of fetch, rebase, or\n-\tdcommit operations), look for the first From: or Signed-off-by: line\n+\tWhen retrieving svn commits into git (as part of 'fetch', 'rebase', or\n+\t'dcommit' operations), look for the first `From:` or `Signed-off-by:` line\n \tin the log message and use that as the author string.\n --add-author-from::\n \tWhen committing to svn from git (as part of 'commit-diff', 'set-tree' or 'dcommit'\n \toperations), if the existing log message doesn't already have a\n-\tFrom: or Signed-off-by: line, append a From: line based on the\n-\tgit commit's author string. If you use this, then --use-log-author\n+\t`From:` or `Signed-off-by:` line, append a `From:` line based on the\n+\tgit commit's author string. If you use this, then `--use-log-author`\n \twill retrieve a valid author string for all commits.\n \n \n-- \n1.7.1\n"}]}