{"thread":{"id":"27054","subject":"[PATCH] Makefile: extract Q_() source strings as ngettext()","startedAt":"2011-04-10T19:37:01Z","lastAt":"2011-04-11T21:38:43Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"165575","messageId":"1302464221-23381-1-git-send-email-avarab@gmail.com","threadId":"27054","inReplyTo":null,"subject":"[PATCH] Makefile: extract Q_() source strings as ngettext()","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2011-04-10T19:37:01Z","receivedAt":"2011-04-10T19:37:01Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The patch adding the Q_() wrapper function around ngettext[1] didn't\ncontain a corresponding update to the \"pot\" target in the Makefile. As\na result \"make pot\" wouldn't extract gettext messages using the plural\nform.\n\n1. added by Jonathan Nieder in v1.7.5-rc0~54^2~2 (i18n: add stub Q_()\n   wrapper for ngettext).\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 92c1c5e..2441d56 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2051,7 +2051,7 @@ XGETTEXT_FLAGS = \\\n \t--add-comments \\\n \t--msgid-bugs-address=\"Git Mailing List <git@vger.kernel.org>\" \\\n \t--from-code=UTF-8\n-XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --keyword=_ --keyword=N_ --language=C\n+XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --keyword=_ --keyword=N_ --keyword=\"Q_:1,2\" --language=C\n LOCALIZED_C := $(C_OBJ:o=c)\n \n po/git.pot: $(LOCALIZED_C)\n-- \n1.7.4.1\n"},{"id":"165577","messageId":"20110410195436.GD28163@elie","threadId":"27054","inReplyTo":"1302464221-23381-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] Makefile: extract Q_() source strings as ngettext()","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-04-10T19:54:36Z","receivedAt":"2011-04-10T19:54:36Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ævar Arnfjörð Bjarmason wrote:\n\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2051,7 +2051,7 @@ XGETTEXT_FLAGS = \\\n>  \t--add-comments \\\n>  \t--msgid-bugs-address=\"Git Mailing List <git@vger.kernel.org>\" \\\n>  \t--from-code=UTF-8\n> -XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --keyword=_ --keyword=N_ --language=C\n> +XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --keyword=_ --keyword=N_ --keyword=\"Q_:1,2\" --language=C\n>  LOCALIZED_C := $(C_OBJ:o=c)\n\nAck.  The line is getting long.  Maybe it would make sense to split\nit up (like this)?\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n Makefile |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 2441d56..2dbe555 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2051,7 +2051,8 @@ XGETTEXT_FLAGS = \\\n \t--add-comments \\\n \t--msgid-bugs-address=\"Git Mailing List <git@vger.kernel.org>\" \\\n \t--from-code=UTF-8\n-XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --keyword=_ --keyword=N_ --keyword=\"Q_:1,2\" --language=C\n+XGETTEXT_FLAGS_C = $(XGETTEXT_FLAGS) --language=C \\\n+\t--keyword=_ --keyword=N_ --keyword=Q_:1,2\n LOCALIZED_C := $(C_OBJ:o=c)\n \n po/git.pot: $(LOCALIZED_C)\n-- \n1.7.5.rc0\n"},{"id":"165652","messageId":"7v1v18v57g.fsf@alter.siamese.dyndns.org","threadId":"27054","inReplyTo":"20110410195436.GD28163@elie","subject":"Re: [PATCH] Makefile: extract Q_() source strings as ngettext()","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-04-11T21:38:43Z","receivedAt":"2011-04-11T21:38:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Ack.  The line is getting long.  Maybe it would make sense to split\n> it up (like this)?\n\nMakes sense, thanks both.\n\nI've re-written the commit log message, by the way.  Instead of saying \"X\nforgot to do Y and broke Z\", I prefer to say \"To make sure Z happens, we\nneed to do Y to augment what X did, and W is how we do Y\".\n"}]}