{"thread":{"id":"2705","subject":"[PATCH] git-clone --shared should imply --local","startedAt":"2005-11-29T06:20:49Z","lastAt":"2005-11-29T07:52:55Z","messageCount":4,"participants":["Pavel Roskin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"12913","messageId":"1133245249.27750.77.camel@dv","threadId":"2705","inReplyTo":null,"subject":"[PATCH] git-clone --shared should imply --local","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-11-29T06:20:49Z","receivedAt":"2005-11-29T06:20:49Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"The \"--shared\" option to git-clone is silently ignored if \"--local\" is\nnot specified.  The manual doesn't mention such dependency.  Make\n\"--shared\" imply \"--local\".\n\nSigned-off-by: Pavel Roskin <proski@gnu.org>\n\ndiff --git a/git-clone.sh b/git-clone.sh\nindex c09979a..699205e 100755\n--- a/git-clone.sh\n+++ b/git-clone.sh\n@@ -73,7 +73,7 @@ while\n \t*,-n) no_checkout=yes ;;\n \t*,-l|*,--l|*,--lo|*,--loc|*,--loca|*,--local) use_local=yes ;;\n         *,-s|*,--s|*,--sh|*,--sha|*,--shar|*,--share|*,--shared) \n-          local_shared=yes ;;\n+          local_shared=yes; use_local=yes ;;\n \t*,-q|*,--quiet) quiet=-q ;;\n \t1,-u|1,--upload-pack) usage ;;\n \t*,-u|*,--upload-pack)\n\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"12918","messageId":"7viruclymo.fsf@assigned-by-dhcp.cox.net","threadId":"2705","inReplyTo":"1133245249.27750.77.camel@dv","subject":"Re: [PATCH] git-clone --shared should imply --local","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-29T07:08:31Z","receivedAt":"2005-11-29T07:08:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pavel Roskin <proski@gnu.org> writes:\n\n> The \"--shared\" option to git-clone is silently ignored if \"--local\" is\n> not specified.  The manual doesn't mention such dependency.  Make\n> \"--shared\" imply \"--local\".\n>\n> Signed-off-by: Pavel Roskin <proski@gnu.org>\n\nHmph, then probably the manual should say it implies it...\n"},{"id":"12917","messageId":"1133248651.27750.82.camel@dv","threadId":"2705","inReplyTo":"7viruclymo.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] git-clone --shared should imply --local","fromName":"Pavel Roskin","fromEmail":"proski@gnu.org","sentAt":"2005-11-29T07:17:31Z","receivedAt":"2005-11-29T07:17:31Z","isPatch":true,"sender":{"key":"proski@gnu.org","avatar":null},"body":"On Mon, 2005-11-28 at 23:08 -0800, Junio C Hamano wrote:\n> Pavel Roskin <proski@gnu.org> writes:\n> \n> > The \"--shared\" option to git-clone is silently ignored if \"--local\" is\n> > not specified.  The manual doesn't mention such dependency.  Make\n> > \"--shared\" imply \"--local\".\n> >\n> > Signed-off-by: Pavel Roskin <proski@gnu.org>\n> \n> Hmph, then probably the manual should say it implies it...\n\nActually, from the user point of view --local and --shared are\nalternatives to each other and to the default behavior.  --local copies\nfiles, --shared makes a reference.\n\nSaying that --shared implies --local could sound like git-clone would\nstill copy all objects.\n\nMy description was from the implementation point of view.\n\n-- \nRegards,\nPavel Roskin\n"},{"id":"12920","messageId":"7v4q5vlwko.fsf@assigned-by-dhcp.cox.net","threadId":"2705","inReplyTo":"1133248651.27750.82.camel@dv","subject":"Re: [PATCH] git-clone --shared should imply --local","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-29T07:52:55Z","receivedAt":"2005-11-29T07:52:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pavel Roskin <proski@gnu.org> writes:\n\n> On Mon, 2005-11-28 at 23:08 -0800, Junio C Hamano wrote:\n>> Pavel Roskin <proski@gnu.org> writes:\n>> \n>> > The \"--shared\" option to git-clone is silently ignored if \"--local\" is\n>> > not specified.  The manual doesn't mention such dependency.  Make\n>> > \"--shared\" imply \"--local\".\n>> >\n>> > Signed-off-by: Pavel Roskin <proski@gnu.org>\n>> \n>> Hmph, then probably the manual should say it implies it...\n>\n> Actually, from the user point of view --local and --shared are\n> alternatives to each other and to the default behavior.  --local copies\n> files, --shared makes a reference.\n>\n> Saying that --shared implies --local could sound like git-clone would\n> still copy all objects.\n>\n> My description was from the implementation point of view.\n\nAh.  Makes sense.\n"}]}