{"thread":{"id":"26927","subject":"[PATCH] Documentation/git-update-index.txt: Remove obsolete note","startedAt":"2011-03-30T13:01:57Z","lastAt":"2011-04-02T08:52:07Z","messageCount":5,"participants":["Jakob Pfender","Nguyen Thai Ngoc Duy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"164686","messageId":"4D9329C5.3060809@elegosoft.com","threadId":"26927","inReplyTo":null,"subject":"[PATCH] Documentation/git-update-index.txt: Remove obsolete note","fromName":"Jakob Pfender","fromEmail":"jpfender@elegosoft.com","sentAt":"2011-03-30T13:01:57Z","receivedAt":"2011-03-30T13:01:57Z","isPatch":true,"sender":{"key":"jpfender@elegosoft.com","avatar":null},"body":"8dcf39 (Prevent bogus paths from being added to the index) introduced a\ncheck for files beginning with '.', preventing path names such as\n`./file`, `dir/./file` or `dir/../file` from being added. This was\nreflected in the man page.\n\nd089eba (setup: sanitize absolute and funny paths in get_pathspec())\nremoved this check without reflecting the change in the man page.\n\nSigned-off-by: Jakob Pfender \n---\n Documentation/git-update-index.txt | 6 ++----\n 1 files changed, 2 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/git-update-index.txt \nb/Documentation/git-update-index.txt\nindex 1ca56c8..f0dcd1f 100644\n--- a/Documentation/git-update-index.txt\n+++ b/Documentation/git-update-index.txt\n@@ -152,10 +152,8 @@ you will need to handle the situation manually.\n\n ::\n \tFiles to act on.\n-\tNote that files beginning with '.' are discarded. This includes\n-\t`./file` and `dir/./file`. If you don't want this, then use\n-\tcleaner names.\n-\tThe same applies to directories ending '/' and paths with '//'\n+\tNote that directories ending in '/' and paths with '//' are\n+\tdiscarded.\n\n Using --refresh\n ---------------\n-- \n1.7.0.4\n"},{"id":"164782","messageId":"AANLkTik3nEE2mtpRVwuQxfoNZd8Ejpgc=T=GS_jEpXsB@mail.gmail.com","threadId":"26927","inReplyTo":"4D9329C5.3060809@elegosoft.com","subject":"Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2011-03-31T12:15:43Z","receivedAt":"2011-03-31T12:15:43Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Mar 30, 2011 at 8:01 PM, Jakob Pfender wrote:\n> 8dcf39 (Prevent bogus paths from being added to the index) introduced a\n> check for files beginning with '.', preventing path names such as\n> `./file`, `dir/./file` or `dir/../file` from being added. This was\n> reflected in the man page.\n>\n> d089eba (setup: sanitize absolute and funny paths in get_pathspec())\n> removed this check without reflecting the change in the man page.\n\nSounds good.\n\n>  ::\n>        Files to act on.\n> -       Note that files beginning with '.' are discarded. This includes\n> -       `./file` and `dir/./file`. If you don't want this, then use\n> -       cleaner names.\n> -       The same applies to directories ending '/' and paths with '//'\n> +       Note that directories ending in '/' and paths with '//' are\n> +       discarded.\n\nDo you mean the slashes or the directories are discarded? Directories\nare not, I believe.\n-- \nDuy\n"},{"id":"164803","messageId":"4D949B53.80801@elegosoft.com","threadId":"26927","inReplyTo":"AANLkTik3nEE2mtpRVwuQxfoNZd8Ejpgc=T=GS_jEpXsB@mail.gmail.com","subject":"Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note","fromName":"Jakob Pfender","fromEmail":"jpfender@elegosoft.com","sentAt":"2011-03-31T15:18:43Z","receivedAt":"2011-03-31T15:18:43Z","isPatch":true,"sender":{"key":"jpfender@elegosoft.com","avatar":null},"body":"On 03/31/2011 02:15 PM, Nguyen Thai Ngoc Duy wrote:\n > On Wed, Mar 30, 2011 at 8:01 PM, Jakob \nPfender wrote:\n >> 8dcf39 (Prevent bogus paths from being added to the index) introduced a\n >> check for files beginning with '.', preventing path names such as\n >> `./file`, `dir/./file` or `dir/../file` from being added. This was\n >> reflected in the man page.\n >>\n >> d089eba (setup: sanitize absolute and funny paths in get_pathspec())\n >> removed this check without reflecting the change in the man page.\n >\n > Sounds good.\n >\n >> ::\n >> Files to act on.\n >> - Note that files beginning with '.' are discarded. This includes\n >> - `./file` and `dir/./file`. If you don't want this, then use\n >> - cleaner names.\n >> - The same applies to directories ending '/' and paths with '//'\n >> + Note that directories ending in '/' and paths with '//' are\n >> + discarded.\n >\n > Do you mean the slashes or the directories are discarded? Directories\n > are not, I believe.\n\nSince we're talking about update-index, yes, directories are actually\ndiscarded, as update-index only accepts files. Directories can be added\nvia git-add as git-add just passes the single files in the directory to\nupdate-index.\n"},{"id":"164834","messageId":"7v7hbfj7d6.fsf@alter.siamese.dyndns.org","threadId":"26927","inReplyTo":"AANLkTik3nEE2mtpRVwuQxfoNZd8Ejpgc=T=GS_jEpXsB@mail.gmail.com","subject":"Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-03-31T21:41:09Z","receivedAt":"2011-03-31T21:41:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nguyen Thai Ngoc Duy writes:\n\n> On Wed, Mar 30, 2011 at 8:01 PM, Jakob Pfender wrote:\n>> 8dcf39 (Prevent bogus paths from being added to the index) introduced a\n>> check for files beginning with '.', preventing path names such as\n>> `./file`, `dir/./file` or `dir/../file` from being added. This was\n>> reflected in the man page.\n>>\n>> d089eba (setup: sanitize absolute and funny paths in get_pathspec())\n>> removed this check without reflecting the change in the man page.\n>\n> Sounds good.\n\nWhen I first read it, however, I thought that the \"removal\" meant that the\nrewrite made the code riskier by accepting nonsense, which turns out not\nto be what the author meant. It was more like \"instead of rejecting,\naccept these paths after normalizing\", no?\n"},{"id":"164946","messageId":"BANLkTi=gadRz0XXp2Jd1Jnv7hH4fbnE45Q@mail.gmail.com","threadId":"26927","inReplyTo":"7v7hbfj7d6.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note","fromName":"Nguyen Thai Ngoc Duy","fromEmail":"pclouds@gmail.com","sentAt":"2011-04-02T08:52:07Z","receivedAt":"2011-04-02T08:52:07Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Apr 1, 2011 at 4:41 AM, Junio C Hamano wrote:\n> Nguyen Thai Ngoc Duy writes:\n>\n>> On Wed, Mar 30, 2011 at 8:01 PM, Jakob Pfender wrote:\n>>> 8dcf39 (Prevent bogus paths from being added to the index) introduced a\n>>> check for files beginning with '.', preventing path names such as\n>>> `./file`, `dir/./file` or `dir/../file` from being added. This was\n>>> reflected in the man page.\n>>>\n>>> d089eba (setup: sanitize absolute and funny paths in get_pathspec())\n>>> removed this check without reflecting the change in the man page.\n>>\n>> Sounds good.\n>\n> When I first read it, however, I thought that the \"removal\" meant that the\n> rewrite made the code riskier by accepting nonsense, which turns out not\n> to be what the author meant.  It was more like \"instead of rejecting,\n> accept these paths after normalizing\", no?\n>\n\nYes it's more like that.\n-- \nDuy\n"}]}